[#MDL-14650] Chat: Merge bugs fix and improments

Issue Details (XML | Word | Printable)

Key:	MDL-14650
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Dongsheng Cai
Reporter:	Dongsheng Cai
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-8224

Chat: Merge bugs fix and improments

Created: 02/May/08 10:25 AM Updated: 11/Dec/08 11:42 AM

Return to search

Component/s:

Chat

Affects Version/s:

1.9.1

Fix Version/s:

2.0

Environment:

Ubuntu, apache2, php5

Participants:	Dongsheng Cai and Eloy Lafuente (stronk7)
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	11/Dec/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

So many changes, these need to merge step by step

All

Comments

Change History

Version Control

Sort Order:

Dongsheng Cai made changes - 02/May/08 10:26 AM

Field	Original Value	New Value
Status	Open [ 1 ]	In Progress [ 3 ]

Dongsheng Cai made changes - 02/May/08 10:27 AM

Summary

Fix bugs

Chat: Merge bugs fix and improments

Dongsheng Cai made changes - 13/Jun/08 11:45 AM

Status

In Progress [ 3 ]

Open [ 1 ]

Dongsheng Cai committed 12 files to 'Moodle CVS' - 24/Jul/08 11:15 AM

~~MDL-14650~~, create a new table `chat_messages_current` to save latest 8 hours messages, could improve performance. The expired message will be deleted in chat_cron function

MODIFY	mod/chat/gui_header_js/jsupdate.php	Rev. 1.41	(+2 -2 lines)
MODIFY	mod/chat/gui_header_js/insert.php	Rev. 1.15	(+4 -4 lines)
MODIFY	mod/chat/chatd.php	Rev. 1.37	(+5 -1 lines)
MODIFY	mod/chat/lib.php	Rev. 1.118	(+26 -17 lines)
MODIFY	mod/chat/db/install.xml	Rev. 1.4	(+22 -2 lines)
MODIFY	mod/chat/gui_header_js/jsupdated.php	Rev. 1.13	(+2 -2 lines)
MODIFY	mod/chat/version.php	Rev. 1.28	(+2 -2 lines)
MODIFY	mod/chat/gui_basic/index.php	Rev. 1.9	(+4 -4 lines)
MODIFY	mod/chat/db/upgrade.php	Rev. 1.6	(+53 -3 lines)
MODIFY	mod/chat/gui_header_js/users.php	Rev. 1.21	(+3 -2 lines)
MODIFY	mod/chat/view.php	Rev. 1.69	(+6 -6 lines)
MODIFY	mod/chat/gui_header_js/index.php	Rev. 1.32	(+3 -3 lines)

Dongsheng Cai committed 2 files to 'Moodle CVS' - 24/Jul/08 01:28 PM

~~MDL-14650~~, fix the problem of upgrade script

MODIFY	mod/chat/db/upgrade.php		Rev. 1.7		(+26 -44 lines)
MODIFY	mod/chat/version.php		Rev. 1.29		(+2 -2 lines)

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 25/Jul/08 01:25 AM

Hi Dongsheng. Great to see the "current" table to store recent messages. Sure it helps a lot! B-)

Reviewing code, I've seen, in index.php this line:

+ if (!$DB->insert_record('chat_messages', $newmessage) && !$DB->insert_record('chat_messages_current', $newmessage)) {

just guessing it should be || instead of &&.

Ciao

Dongsheng Cai committed 1 file to 'Moodle CVS' - 25/Jul/08 11:09 AM

~~MDL-14650~~, fix incorrect use of &&

MODIFY

mod/chat/gui_basic/index.php

Rev. 1.10

(+2 -2 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 25/Jul/08 11:09 AM

Sorry

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 25/Jul/08 02:55 PM

np! great work! B-)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 11/Dec/08 11:42 AM

Further changes go to ~~MDL-14651~~

Dongsheng Cai made changes - 11/Dec/08 11:42 AM

Fix Version/s		2.0 [ 10122 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.