Moodle

Make install.php XHTML compliant

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Installation
  • Labels:
    None
  • Environment:
    Any
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

It seems that the install.php script isn't XHTML compliant at all. Fix that.

Ciao

Attachments

  1. Text File
    MDL-14656_moodle_install_stringnames.txt.patch
    07/May/08 10:11 AM
    0.9 kB
    Jerome Mouneyrac
  2. Text File
    MDL-14656_moodle_lang_en_utf8_install.php.patch
    08/May/08 9:43 AM
    4 kB
    Jerome Mouneyrac
  3. Text File
    MDL-14656_welcome.html.patch
    12/May/08 1:16 PM
    0.9 kB
    Jerome Mouneyrac
  4. Text File
    MDL-14656.moodle_install.php.patch
    07/May/08 10:11 AM
    20 kB
    Jerome Mouneyrac

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jerome Mouneyrac added a comment - - edited

I fixed xhtml in the install script + english pack.

Show
Jerome Mouneyrac added a comment - - edited I fixed xhtml in the install script + english pack.
Hide
Permalink
Jerome Mouneyrac added a comment -

Maybe translators would you like to have a look to the language packs:

in order to fix xhtml:
1. <font color=\"red\">...</font> => <strong class=\"errormsg\">...</strong>
(color attribut is not allowed in <font> tag)
2. <p><blockquote>...</blockquote></p> => <blockquote><div>...</div></blockquote>
(here 2 problems: first the <blockquote> tag can not be into a <p> tag, secondly you can not write text directly into <blockquote> tag.)

missing translation:
1. $string['globalsquoteshelp'] = ... (even in english language pack, the text is missing)
2. $string['fileuploadshelp']
3. $string['magicquotesruntimehelp']
4. $string['safemodehelp']
5. $string['sessionautostarthelp']

Show
Jerome Mouneyrac added a comment - Maybe translators would you like to have a look to the language packs: in order to fix xhtml: 1. <font color=\"red\">...</font> => <strong class=\"errormsg\">...</strong> (color attribut is not allowed in <font> tag) 2. <p><blockquote>...</blockquote></p> => <blockquote><div>...</div></blockquote> (here 2 problems: first the <blockquote> tag can not be into a <p> tag, secondly you can not write text directly into <blockquote> tag.) missing translation: 1. $string['globalsquoteshelp'] = ... (even in english language pack, the text is missing) 2. $string['fileuploadshelp'] 3. $string['magicquotesruntimehelp'] 4. $string['safemodehelp'] 5. $string['sessionautostarthelp']
Hide
Permalink
Jerome Mouneyrac added a comment -

I fixed the install script XHTML however, I stopped testing once the config.php is created (last page of the install script).
I haven't tested/fixed table creation pages. It's using admin/index.php, and it isn't XHTML valid. I opened a new issue for it: MDL-14717

Show
Jerome Mouneyrac added a comment - I fixed the install script XHTML however, I stopped testing once the config.php is created (last page of the install script). I haven't tested/fixed table creation pages. It's using admin/index.php, and it isn't XHTML valid. I opened a new issue for it: MDL-14717
Hide
Permalink
Martin Dougiamas added a comment -

+1 to go into HEAD, I don't see anything controversial there.

Show
Martin Dougiamas added a comment - +1 to go into HEAD, I don't see anything controversial there.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Agree with Martin about this going to HEAD, 2 comments:

1) You must not modify manually install/lang/xxxx files. Just edit the originals in complete language pack + keep the list in install/stringnames.txt updated and daily, one script will recreate the install/lang/xxxx ones automatically. So your patch 3) above is not necessary.

2) Can you try to mimic these changes to http://cvs.moodle.org/contrib/tools/m4w_builder/installer/ (the Windows installed, only version 2.0)

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - Agree with Martin about this going to HEAD, 2 comments: 1) You must not modify manually install/lang/xxxx files. Just edit the originals in complete language pack + keep the list in install/stringnames.txt updated and daily, one script will recreate the install/lang/xxxx ones automatically. So your patch 3) above is not necessary. 2) Can you try to mimic these changes to http://cvs.moodle.org/contrib/tools/m4w_builder/installer/ (the Windows installed, only version 2.0) TIA and ciao
Hide
Permalink
Jerome Mouneyrac added a comment - - edited

1. I did the change in lang/install.php (and remove the patches for the files into install/lang)
2. Windows Installer will be optimized in MDL-14721

All has been commited in 1.9 and HEAD
Note: in HEAD, stringnames.txt was already fixed

Show
Jerome Mouneyrac added a comment - - edited 1. I did the change in lang/install.php (and remove the patches for the files into install/lang) 2. Windows Installer will be optimized in MDL-14721 All has been commited in 1.9 and HEAD Note: in HEAD, stringnames.txt was already fixed
Hide
Permalink
Jerome Mouneyrac added a comment -

Please if you can retest on 1.9 and 2.0 it would be better (as the 2.0 was already fixed for the stringnames.txt file)
In order to retest you need to go through all cases (activate and desactivate PHP option).
Thanks a lot.

Show
Jerome Mouneyrac added a comment - Please if you can retest on 1.9 and 2.0 it would be better (as the 2.0 was already fixed for the stringnames.txt file) In order to retest you need to go through all cases (activate and desactivate PHP option). Thanks a lot.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Getting QA of this... I'll test this tomorrow (waiting for 1.9 strings to be properly generated). Anyway, I've looked at applied patches and they look ok. Good work!

Show
Eloy Lafuente (stronk7) added a comment - Getting QA of this... I'll test this tomorrow (waiting for 1.9 strings to be properly generated). Anyway, I've looked at applied patches and they look ok. Good work!
Hide
Permalink
Jerome Mouneyrac added a comment -

I added the patch: 'MDL-14656_welcome.html.patch'
It fixes XHTML for the welcome text (for example, you can see it when you install Moodle with Windows Installer. It is displayed on the first page.)

Show
Jerome Mouneyrac added a comment - I added the patch: 'MDL-14656_welcome.html.patch' It fixes XHTML for the welcome text (for example, you can see it when you install Moodle with Windows Installer. It is displayed on the first page.)
Hide
Permalink
Jerome Mouneyrac added a comment -

I commited the patch described in the previous comment. (HEAD and 1.9)

No need to retest everything. Just check the first page of the installation script. Check if the xhtml is valid when the welcome text is displayed.

Show
Jerome Mouneyrac added a comment - I commited the patch described in the previous comment. (HEAD and 1.9) No need to retest everything. Just check the first page of the installation script. Check if the xhtml is valid when the welcome text is displayed.
Hide
Permalink
Petr Škoda (skodak) added a comment -

reviewed and tested, thanks

Show
Petr Škoda (skodak) added a comment - reviewed and tested, thanks

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.