Issue Details (XML | Word | Printable)

Key: MDL-14656
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Make install.php XHTML compliant

Created: 02/May/08 05:18 PM   Updated: 13/May/08 04:33 PM
Component/s: Installation
Affects Version/s: 1.9
Fix Version/s: 1.9.1

File Attachments: 1. Text File MDL-14656.moodle_install.php.patch (20 kB)
2. Text File MDL-14656_moodle_install_stringnames.txt.patch (0.9 kB)
3. Text File MDL-14656_moodle_lang_en_utf8_install.php.patch (4 kB)
4. Text File MDL-14656_welcome.html.patch (0.9 kB)
Environment: Any

Database: Any
Participants: Eloy Lafuente (stronk7), Jerome Mouneyrac, Martin Dougiamas and Petr Skoda (frankenstein)
Security Level: None
QA Assignee: Petr Skoda (frankenstein)
Resolved date: 12/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
It seems that the install.php script isn't XHTML compliant at all. Fix that.

Ciao



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 07/May/08 10:11 AM - edited
I fixed xhtml in the install script + english pack.

[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 07/May/08 11:28 AM
Maybe translators would you like to have a look to the language packs:

in order to fix xhtml:
1. <font color=\"red\">...</font> => <strong class=\"errormsg\">...</strong>
(color attribut is not allowed in <font> tag)
2. <p><blockquote>...</blockquote></p> => <blockquote><div>...</div></blockquote>
(here 2 problems: first the <blockquote> tag can not be into a <p> tag, secondly you can not write text directly into <blockquote> tag.)

missing translation:
1. $string['globalsquoteshelp'] = ... (even in english language pack, the text is missing)
2. $string['fileuploadshelp']
3. $string['magicquotesruntimehelp']
4. $string['safemodehelp']
5. $string['sessionautostarthelp']


[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 07/May/08 11:42 AM
I fixed the install script XHTML however, I stopped testing once the config.php is created (last page of the install script).
I haven't tested/fixed table creation pages. It's using admin/index.php, and it isn't XHTML valid. I opened a new issue for it: MDL-14717

[ Permalink | « Hide ]
Martin Dougiamas added a comment - 07/May/08 02:58 PM
+1 to go into HEAD, I don't see anything controversial there.

[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 08/May/08 12:05 AM
Agree with Martin about this going to HEAD, 2 comments:

1) You must not modify manually install/lang/xxxx files. Just edit the originals in complete language pack + keep the list in install/stringnames.txt updated and daily, one script will recreate the install/lang/xxxx ones automatically. So your patch 3) above is not necessary.

2) Can you try to mimic these changes to http://cvs.moodle.org/contrib/tools/m4w_builder/installer/ (the Windows installed, only version 2.0)

TIA and ciao


[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 08/May/08 10:27 AM - edited
1. I did the change in lang/install.php (and remove the patches for the files into install/lang)
2. Windows Installer will be optimized in MDL-14721

All has been commited in 1.9 and HEAD
Note: in HEAD, stringnames.txt was already fixed


[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 08/May/08 10:31 AM
Please if you can retest on 1.9 and 2.0 it would be better (as the 2.0 was already fixed for the stringnames.txt file)
In order to retest you need to go through all cases (activate and desactivate PHP option).
Thanks a lot.

[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 09/May/08 01:57 AM
Getting QA of this... I'll test this tomorrow (waiting for 1.9 strings to be properly generated). Anyway, I've looked at applied patches and they look ok. Good work!

[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 12/May/08 01:16 PM
I added the patch: 'MDL-14656_welcome.html.patch'
It fixes XHTML for the welcome text (for example, you can see it when you install Moodle with Windows Installer. It is displayed on the first page.)

[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 12/May/08 01:24 PM
I commited the patch described in the previous comment. (HEAD and 1.9)

No need to retest everything. Just check the first page of the installation script. Check if the xhtml is valid when the welcome text is displayed.


[ Permalink | « Hide ]
Petr Skoda (frankenstein) added a comment - 13/May/08 04:33 PM
reviewed and tested, thanks


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators