Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.5
• Fix Version/s: 1.8.5, 1.9, 2.0
• Component/s: Feedback
• Labels:

  None
• Environment:

  Spotted at MOODLE_18_STABLE checked out from CONTRIB

PostgreSQL does not like queries with
... WHERE id = ''

The following code in mod_form.php (around line# 61) throws error:

if ($feedback = get_record("feedback", "id", $this->_instance)) {
$completedFeedbackCount = feedback_get_completeds_group_count($feedback);
} else {
$completedFeedbackCount = false;
}

My proposal is to use:

if (is_numeric($this->_instance) && ($feedback = get_record("feedback", "id", $this->_instance))) {
$completedFeedbackCount = feedback_get_completeds_group_count($feedback);
} else {
$completedFeedbackCount = false;
}

• Assignee:

  Andreas Grabs

  Reporter:

  David Mudrak

  Participants:

  Andreas Grabs, David Mudrak

• Created:

  02/May/08 5:32 PM

  Updated:

  17/Dec/10 1:03 PM

  Resolved:

  04/May/08 5:44 AM