Moodle

META: DB layer 2.0

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None

Description

General collection of tasks and bugs related to datalib rewrite for Moodle 2.0

Issue Links

This issue is blocked by:
MDL-15094 M2-M3-M4 Upgrade all code using DML Blocker Closed
This issue will be resolved by:
CONTRIB-3451 replace missing field non-standard workarounds in hotpot_restore_record() with new $DB->get_columns() Minor Closed
This issue has a non-specific relationship to:
MDL-17491 Implement native Oracle DML driver Minor Closed
MDL-24192 Finish implementation of sqlsrv/mssql drivers Minor Closed
This issue has been marked as being related by:
MDL-6605 switch datalib functions (wherever they are now) to use placeholders Minor Closed
Progress
Resolved Sub-Tasks

Sub-Tasks

1.
 adodb does not support blob and clob updates with bound parameters Sub-task Closed Closed Petr Škoda (skodak)
 
2.
 pgsql does not support bound parameters in comments Sub-task Closed Closed Petr Škoda (skodak)
 
3.
 pgsql does not support bound queries in field default values Sub-task Closed Closed Petr Škoda (skodak)
 
4.
 some unknown problem in big query (1.5MB) test Sub-task Closed Closed Petr Škoda (skodak)
 
5.
 Use proper placeholders for IN senteces Sub-task Closed Closed Petr Škoda (skodak)
 
6.
 rename xmldb stuff to follow lowercase guidelines Sub-task Closed Closed Eloy Lafuente (stronk7)
 
7.
 Installer script is broken Sub-task Closed Closed Petr Škoda (skodak)
 
8.
 prefix check shouldn't be perfomed by moodle_database classes Sub-task Closed Closed Petr Škoda (skodak)
 
9.
 preconfigure_dbconnection() stuff must be implemented in some way Sub-task Closed Closed Petr Škoda (skodak)
 
10.
 Fix one error in SetFetchMode() + minor clean Sub-task Closed Closed Eloy Lafuente (stronk7)
 
11.
 ADOdb Insert_ID() function under MSSQL, using placeholders doesn't work Sub-task Closed Closed Eloy Lafuente (stronk7)
 
12.
 M2: Implement mssql_adodb driver Sub-task Closed Closed Eloy Lafuente (stronk7)
 
13.
 M2: Implement oci8po_adodb driver Sub-task Closed Closed Eloy Lafuente (stronk7)
 
14.
 Move function emulate_bound_params() to adodb_moodle_database Sub-task Closed Closed Eloy Lafuente (stronk7)
 
15.
 Make generators stuff reentrant Sub-task Closed Closed Eloy Lafuente (stronk7)
 
16.
 M2: DDL and DML functional tests Sub-task Closed Closed Nicolas Connault
 
17.
 moodle_database should have one disconnect method Sub-task Closed Closed Petr Škoda (skodak)
 
18.
 M2: Modify XMLDB Editor to suggest PHP code using the manager Sub-task Closed Closed Eloy Lafuente (stronk7)
 
19.
 M2: Modify XMLDB Editor to suggest creation conditional code Sub-task Closed Closed Eloy Lafuente (stronk7)
 
20.
 M2: Exception handling in DDL stuff Sub-task Closed Closed Petr Škoda (skodak)
 
21.
 M2: Normalize results returned from get_tables() get_indexes() and get_columns() Sub-task Closed Closed Petr Škoda (skodak)
 
22.
 M2: Tests get_tables() get_indexes() get_columns() Sub-task Closed Closed Nicolas Connault
 
23.
 M2: Move moodle_recordset to separate class into lib/dml Sub-task Closed Closed Petr Škoda (skodak)
 
24.
 M2-M3-M4 Upgrade all code using DML Sub-task Closed Closed Petr Škoda (skodak)
 
25.
 reset_columns() implementation... Sub-task Closed Closed Petr Škoda (skodak)
 
26.
 Cleanup up deprecated functions so that we do not need to convert them Sub-task Closed Closed Petr Škoda (skodak)
 
27.
 add optional dmllib regex search support Sub-task Closed Closed Petr Škoda (skodak)
 
28.
 add magic quotes stripping option into data_submitted() Sub-task Closed Closed Petr Škoda (skodak)
 
29.
 M2: Move emulate_bound_params() from adodb drivers to adodb_moodle_database Sub-task Closed Closed Eloy Lafuente (stronk7)
 
30.
 undefined variable in oci raw insert $primarykey Sub-task Closed Closed Eloy Lafuente (stronk7)
 
31.
 M2: Enable dml/ddl functional tests for MSSQL and Oracle Sub-task Closed Closed Petr Škoda (skodak)
 
32.
 M2: adodb sessions switched to moodle sessions Sub-task Closed Closed Petr Škoda (skodak)
 
33.
 M2: implement some workaround for Oracle recordset rewind Sub-task Closed Closed Petr Škoda (skodak)
 
34.
 M2: delete_records should truncate table of delete of all records requested Sub-task Closed Closed Petr Škoda (skodak)
 
35.
 M2: implement full temp table support in ddl Sub-task Closed Closed Eloy Lafuente (stronk7)
 
36.
 M4: stop using magic quotes Sub-task Closed Closed Petr Škoda (skodak)
 
37.
 M4: remove all dependencies on adodb code (except dml itself) Sub-task Closed Closed Petr Škoda (skodak)
 
38.
 M2: review missing $this-> inside dml/ddl code Sub-task Closed Closed Eloy Lafuente (stronk7)
 
39.
 Create one script to detect old uses of dml/ddl stuff Sub-task Closed Closed Eloy Lafuente (stronk7)
 
40.
 M2: basic read/write perf counter in moodle_database Sub-task Closed Closed Petr Škoda (skodak)
 
41.
 pdo patches from Andrei Sub-task Closed Closed Petr Škoda (skodak)
 
42.
 implement upgrade savepoints for mods and plugins Sub-task Closed Closed Eloy Lafuente (stronk7)
 
43.
 Some oddities in admin/report/courseoverview Sub-task Closed Closed Petr Škoda (skodak)
 
44.
 M5: Test all sql_xxx() helper functions Sub-task Closed Closed Petr Škoda (skodak)
 
45.
 Named parameters must accept repetitions Sub-task Closed Closed Petr Škoda (skodak)
 
46.
 M5: Add some more tests about CLOBs and BLOBs Sub-task Closed Closed Nicolas Connault
 
47.
 cleanup the last stripslashes and friends Sub-task Closed Closed Petr Škoda (skodak)
 
48.
 Make sql_substr() to accept parameters instead of simply returning function name Sub-task Closed Closed Petr Škoda (skodak)
 
49.
 add new native mysqli dml driver Sub-task Closed Closed Petr Škoda (skodak)
 
50.
 implement exceptions instead of error() and print_error() in ddl, dml and dtl Sub-task Closed Closed Petr Škoda (skodak)
 
51.
 add new native pgsql dml driver Sub-task Closed Closed Petr Škoda (skodak)
 
52.
 move dbpersist option into dboptions Sub-task Closed Closed Petr Škoda (skodak)
 
53.
 implement dml_exceptions in drivers Sub-task Closed Closed Petr Škoda (skodak)
 
54.
 obsolete $CFG->dbfamily Sub-task Closed Closed Petr Škoda (skodak)
 
55.
 implement exceptions in all DML drivers Sub-task Closed Closed Petr Škoda (skodak)
 
56.
 make native drivers default if library not specified in config.php Sub-task Closed Closed Petr Škoda (skodak)
 
57.
 move reset_sequence into dbmanager Sub-task Closed Closed Petr Škoda (skodak)
 
58.
 Need to put back the debug code that tells you if your first column is not unique in get_records_sql Sub-task Closed Closed Petr Škoda (skodak)
 
59.
 postgres native driver, socket connection not working for me Sub-task Closed Closed Petr Škoda (skodak)
 
60.
 implement sql_modulo() method Sub-task Closed Closed Petr Škoda (skodak)
 
61.
 improve dml and ddl unit tests Sub-task Closed Closed Petr Škoda (skodak)
 
62.
 implement caching in get_tables() Sub-task Closed Closed Petr Škoda (skodak)
 
63.
 leading zores are chopped off from strings Sub-task Closed Closed Petr Škoda (skodak)
 
64.
 ADOdb ODBC Insert_ID() function under MSSQL doesn't work Sub-task Closed Closed Eloy Lafuente (stronk7)
 
65.
 M2: Document xmldb/database/manager APIs Sub-task Closed Closed Eloy Lafuente (stronk7)
 
66.
 M2-M3-M4: Document all changes to perform in code to use new XMLDD/DDL/DML libs properly Sub-task Closed Closed Eloy Lafuente (stronk7)
 
67.
 M5: Finish the Tests page in Docs Sub-task Closed Closed Petr Škoda (skodak)
 
68.
 M2: logging Sub-task Closed Closed Petr Škoda (skodak)
 
69.
 M2: profiling Sub-task Closed Closed Petr Škoda (skodak)
 
70.
 Implement native MS sql server drivers (freetds and sqlsrv) Sub-task Closed Closed Eloy Lafuente (stronk7)
 
71.
 do not check return value from isert_record and update_record and cleanup unused error messages replaced by new DML exceptions Sub-task Closed Closed Petr Škoda (skodak)
 
72.
 Drop enums support Sub-task Closed Closed Eloy Lafuente (stronk7)
 
73.
 improve db transactions Sub-task Closed Closed Petr Škoda (skodak)
 
74.
 remove obsoleted adodb database drivers before 2.0 branching Sub-task Closed Closed Petr Škoda (skodak)
 
75.
 Any field operation (drop, rename, change_xxx) must look for field dependencies (indexes, keys...) Sub-task Closed Closed Eloy Lafuente (stronk7)
 
76.
 Improve PostgreSQL generator code Sub-task Closed Closed Eloy Lafuente (stronk7)
 
77.
 OCI breaks badly with statement_cache enabled under certain situations Sub-task Closed Closed Eloy Lafuente (stronk7)
 
78.
 Drop find_sequence_name() function Sub-task Closed Closed Eloy Lafuente (stronk7)
 
79.
 sql_ilike() refactoring Sub-task Closed Closed Petr Škoda (skodak)
 
80.
 raise min Oracle reqs to 10R2 (10.2) Sub-task Closed Closed Eloy Lafuente (stronk7)
 
81.
 Nested DB transactions Sub-task Closed Closed Eloy Lafuente (stronk7)
 
82.
 insert/update/set_field expected behaviour is to cast empty string to 0 for numeric columns Sub-task Closed Closed Eloy Lafuente (stronk7)
 
83.
 On database dispose() check/warn/drop any remaining temp tables... Sub-task Closed Closed Eloy Lafuente (stronk7)
 
84.
 Control (count) opened recordsets Sub-task Closed Closed Petr Škoda (skodak)
 
85.
 new sql_like() should accept parameters and treat case/accent sensitiveness properly Sub-task Closed Closed Petr Škoda (skodak)
 
86.
 deprecate $DB->sql_ilike() Sub-task Closed Closed Petr Škoda (skodak)
 
87.
 add $DB->sql_not_like() or add parameter to the sql_like() Sub-task Closed Closed Petr Škoda (skodak)
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

sanding some simple implementation of new dmllib,
it is very raw - some parts are probably broken, installer does not work, etc.
Inline docs are missing too.

Show
Petr Škoda (skodak) added a comment - sanding some simple implementation of new dmllib, it is very raw - some parts are probably broken, installer does not work, etc. Inline docs are missing too.
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending more feature complete sample,
still only adodb mysql supported

Show
Petr Škoda (skodak) added a comment - sending more feature complete sample, still only adodb mysql supported
Hide
Permalink
Petr Škoda (skodak) added a comment -

Now sort of works with pg and mysql, all old dmllib functions with (.., $filed1, $value1, ..) and logging are redirected to the new library

Show
Petr Škoda (skodak) added a comment - Now sort of works with pg and mysql, all old dmllib functions with (.., $filed1, $value1, ..) and logging are redirected to the new library
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending latest patch - see wiki for details

Show
Petr Škoda (skodak) added a comment - sending latest patch - see wiki for details
Hide
Permalink
Petr Škoda (skodak) added a comment -

fresh patch before the meeting

Show
Petr Škoda (skodak) added a comment - fresh patch before the meeting
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

to keep everybody informed: we (me and Eloy) discussed today needed changes in xmldb library - the changes are not major, just refactoring. Sample patch should be ready by Tuesday...

Show
Petr Škoda (skodak) added a comment - - edited to keep everybody informed: we (me and Eloy) discussed today needed changes in xmldb library - the changes are not major, just refactoring. Sample patch should be ready by Tuesday...
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending fresh patch with new dml and ddl stuff - good luck

Show
Petr Škoda (skodak) added a comment - sending fresh patch with new dml and ddl stuff - good luck
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed problem with undefined config settings, thanks Eloy

Show
Petr Škoda (skodak) added a comment - fixed problem with undefined config settings, thanks Eloy
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

patch landed in cvs:

TODO:

  • make mssql and ora work again
  • readd caching, better debugging and perf tracking
  • unit tests + functional tests
  • better docs
  • convert all code to use new API
  • etc.
Show
Petr Škoda (skodak) added a comment - - edited patch landed in cvs: TODO:
  • make mssql and ora work again
  • readd caching, better debugging and perf tracking
  • unit tests + functional tests
  • better docs
  • convert all code to use new API
  • etc.
Hide
Permalink
Nicolas Martignoni added a comment -

I think taht the modification corresponding to this one: http://cvs.moodle.org/moodle/lang/en_utf8/help/richtext.html.diff?r1=1.10&r2=1.11 in lang packs will break pre-2.0 Moodle help files in all languages other than english, since we don't have branches for lang packs.

Show
Nicolas Martignoni added a comment - I think taht the modification corresponding to this one: http://cvs.moodle.org/moodle/lang/en_utf8/help/richtext.html.diff?r1=1.10&r2=1.11 in lang packs will break pre-2.0 Moodle help files in all languages other than english, since we don't have branches for lang packs.
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

I reviewed the code before the commit, the can_use_html_editor() I put there is available since 1.6 at least, I do not think it could break anything. Versions bellow 1.6 are not supported anymore.

Or did I miss something?

Show
Petr Škoda (skodak) added a comment - - edited I reviewed the code before the commit, the can_use_html_editor() I put there is available since 1.6 at least, I do not think it could break anything. Versions bellow 1.6 are not supported anymore. Or did I miss something?
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

Double checked it, the can_use_html_editor() was available in 1.6.0.
The only potential problem could be if somebody used <1.9.2 language pack in 2.0 which would not work anyway..

Show
Petr Škoda (skodak) added a comment - - edited Double checked it, the can_use_html_editor() was available in 1.6.0. The only potential problem could be if somebody used <1.9.2 language pack in 2.0 which would not work anyway..
Hide
Permalink
Nicolas Martignoni added a comment -

OK, thanks for the clarification. And sorry for the trouble.

Show
Nicolas Martignoni added a comment - OK, thanks for the clarification. And sorry for the trouble.
Hide
Permalink
Samuli Karevaara added a comment -

Sweet Mother of all Patches :-O

Show
Samuli Karevaara added a comment - Sweet Mother of all Patches :-O
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Just for reference, I've applied a minor modif to the mssql driver to better handling of booleans and bug in set_field(). Just a tiny commit being part of the WIP.

Show
Eloy Lafuente (stronk7) added a comment - Just for reference, I've applied a minor modif to the mssql driver to better handling of booleans and bug in set_field(). Just a tiny commit being part of the WIP.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Finally after several years all known issues should be solved now. Thanks everybody!

Petr Skoda

Show
Petr Škoda (skodak) added a comment - Finally after several years all known issues should be solved now. Thanks everybody! Petr Skoda
Hide
Permalink
Tim Hunt added a comment -

Dongsheng. I think you should change your last commit. The code

echo 200;

really looks like debug output that someone left in by mistake. I am not surprised that Petr deleted it accidentally.

I suggest you create a function called chat_print_ok(), to match chat_print_error(), so that the code is self-documenting. Or, if you can't be bothered to do that, at least add a comment.

Anyway, I was confused by this, and I thought I ought to report it.

Show
Tim Hunt added a comment - Dongsheng. I think you should change your last commit. The code echo 200; really looks like debug output that someone left in by mistake. I am not surprised that Petr deleted it accidentally. I suggest you create a function called chat_print_ok(), to match chat_print_error(), so that the code is self-documenting. Or, if you can't be bothered to do that, at least add a comment. Anyway, I was confused by this, and I thought I ought to report it.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I suppose that is old style ajax "success" message, which I deleted it by mistake. We have started using json encoded messages in the new AJAX_SCRIPT after this code was created.

Show
Petr Škoda (skodak) added a comment - I suppose that is old style ajax "success" message, which I deleted it by mistake. We have started using json encoded messages in the new AJAX_SCRIPT after this code was created.
Hide
Permalink
Dongsheng Cai added a comment -

Hi, Tim and Petr

I changed echo 200; to echo json_encode(true); and added a comment there.

Show
Dongsheng Cai added a comment - Hi, Tim and Petr I changed echo 200; to echo json_encode(true); and added a comment there.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.