Moodle

META: DB layer 2.0

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None

Description

General collection of tasks and bugs related to datalib rewrite for Moodle 2.0

Issue Links

Progress
Resolved Sub-Tasks

Sub-Tasks

Activity

Hide
Petr Škoda (skodak) added a comment -

sanding some simple implementation of new dmllib,
it is very raw - some parts are probably broken, installer does not work, etc.
Inline docs are missing too.

Show
Petr Škoda (skodak) added a comment - sanding some simple implementation of new dmllib, it is very raw - some parts are probably broken, installer does not work, etc. Inline docs are missing too.
Hide
Petr Škoda (skodak) added a comment -

sending more feature complete sample,
still only adodb mysql supported

Show
Petr Škoda (skodak) added a comment - sending more feature complete sample, still only adodb mysql supported
Hide
Petr Škoda (skodak) added a comment -

Now sort of works with pg and mysql, all old dmllib functions with (.., $filed1, $value1, ..) and logging are redirected to the new library

Show
Petr Škoda (skodak) added a comment - Now sort of works with pg and mysql, all old dmllib functions with (.., $filed1, $value1, ..) and logging are redirected to the new library
Hide
Petr Škoda (skodak) added a comment -

sending latest patch - see wiki for details

Show
Petr Škoda (skodak) added a comment - sending latest patch - see wiki for details
Hide
Petr Škoda (skodak) added a comment -

fresh patch before the meeting

Show
Petr Škoda (skodak) added a comment - fresh patch before the meeting
Hide
Petr Škoda (skodak) added a comment - - edited

to keep everybody informed: we (me and Eloy) discussed today needed changes in xmldb library - the changes are not major, just refactoring. Sample patch should be ready by Tuesday...

Show
Petr Škoda (skodak) added a comment - - edited to keep everybody informed: we (me and Eloy) discussed today needed changes in xmldb library - the changes are not major, just refactoring. Sample patch should be ready by Tuesday...
Hide
Petr Škoda (skodak) added a comment -

sending fresh patch with new dml and ddl stuff - good luck

Show
Petr Škoda (skodak) added a comment - sending fresh patch with new dml and ddl stuff - good luck
Hide
Petr Škoda (skodak) added a comment -

fixed problem with undefined config settings, thanks Eloy

Show
Petr Škoda (skodak) added a comment - fixed problem with undefined config settings, thanks Eloy
Hide
Petr Škoda (skodak) added a comment - - edited

patch landed in cvs:

TODO:

  • make mssql and ora work again
  • readd caching, better debugging and perf tracking
  • unit tests + functional tests
  • better docs
  • convert all code to use new API
  • etc.
Show
Petr Škoda (skodak) added a comment - - edited patch landed in cvs: TODO:
  • make mssql and ora work again
  • readd caching, better debugging and perf tracking
  • unit tests + functional tests
  • better docs
  • convert all code to use new API
  • etc.
Hide
Nicolas Martignoni added a comment -

I think taht the modification corresponding to this one: http://cvs.moodle.org/moodle/lang/en_utf8/help/richtext.html.diff?r1=1.10&r2=1.11 in lang packs will break pre-2.0 Moodle help files in all languages other than english, since we don't have branches for lang packs.

Show
Nicolas Martignoni added a comment - I think taht the modification corresponding to this one: http://cvs.moodle.org/moodle/lang/en_utf8/help/richtext.html.diff?r1=1.10&r2=1.11 in lang packs will break pre-2.0 Moodle help files in all languages other than english, since we don't have branches for lang packs.
Hide
Petr Škoda (skodak) added a comment - - edited

I reviewed the code before the commit, the can_use_html_editor() I put there is available since 1.6 at least, I do not think it could break anything. Versions bellow 1.6 are not supported anymore.

Or did I miss something?

Show
Petr Škoda (skodak) added a comment - - edited I reviewed the code before the commit, the can_use_html_editor() I put there is available since 1.6 at least, I do not think it could break anything. Versions bellow 1.6 are not supported anymore. Or did I miss something?
Hide
Petr Škoda (skodak) added a comment - - edited

Double checked it, the can_use_html_editor() was available in 1.6.0.
The only potential problem could be if somebody used <1.9.2 language pack in 2.0 which would not work anyway..

Show
Petr Škoda (skodak) added a comment - - edited Double checked it, the can_use_html_editor() was available in 1.6.0. The only potential problem could be if somebody used <1.9.2 language pack in 2.0 which would not work anyway..
Hide
Nicolas Martignoni added a comment -

OK, thanks for the clarification. And sorry for the trouble.

Show
Nicolas Martignoni added a comment - OK, thanks for the clarification. And sorry for the trouble.
Hide
Samuli Karevaara added a comment -

Sweet Mother of all Patches :-O

Show
Samuli Karevaara added a comment - Sweet Mother of all Patches :-O
Hide
Eloy Lafuente (stronk7) added a comment -

Just for reference, I've applied a minor modif to the mssql driver to better handling of booleans and bug in set_field(). Just a tiny commit being part of the WIP.

Show
Eloy Lafuente (stronk7) added a comment - Just for reference, I've applied a minor modif to the mssql driver to better handling of booleans and bug in set_field(). Just a tiny commit being part of the WIP.
Hide
Petr Škoda (skodak) added a comment -

Finally after several years all known issues should be solved now. Thanks everybody!

Petr Skoda

Show
Petr Škoda (skodak) added a comment - Finally after several years all known issues should be solved now. Thanks everybody! Petr Skoda
Hide
Tim Hunt added a comment -

Dongsheng. I think you should change your last commit. The code

echo 200;

really looks like debug output that someone left in by mistake. I am not surprised that Petr deleted it accidentally.

I suggest you create a function called chat_print_ok(), to match chat_print_error(), so that the code is self-documenting. Or, if you can't be bothered to do that, at least add a comment.

Anyway, I was confused by this, and I thought I ought to report it.

Show
Tim Hunt added a comment - Dongsheng. I think you should change your last commit. The code echo 200; really looks like debug output that someone left in by mistake. I am not surprised that Petr deleted it accidentally. I suggest you create a function called chat_print_ok(), to match chat_print_error(), so that the code is self-documenting. Or, if you can't be bothered to do that, at least add a comment. Anyway, I was confused by this, and I thought I ought to report it.
Hide
Petr Škoda (skodak) added a comment -

I suppose that is old style ajax "success" message, which I deleted it by mistake. We have started using json encoded messages in the new AJAX_SCRIPT after this code was created.

Show
Petr Škoda (skodak) added a comment - I suppose that is old style ajax "success" message, which I deleted it by mistake. We have started using json encoded messages in the new AJAX_SCRIPT after this code was created.
Hide
Dongsheng Cai added a comment -

Hi, Tim and Petr

I changed echo 200; to echo json_encode(true); and added a comment there.

Show
Dongsheng Cai added a comment - Hi, Tim and Petr I changed echo 200; to echo json_encode(true); and added a comment there.

Dates

  • Created:
    Updated:
    Resolved: