Issue Details (XML | Word | Printable)

Key: MDL-14679
Type: Task Task
Status: Open Open
Priority: Major Major
Assignee: Eloy Lafuente (stronk7)
Reporter: Petr Skoda
Votes: 0
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

META: DB layer 2.0

Created: 04/May/08 07:52 AM   Updated: 29/Apr/09 07:51 AM
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File new_dmllib_47.patch (1.28 MB)
Issue Links:
Blockers
 
Relates
 

URL: http://docs.moodle.org/en/Development:DB_layer_2.0
Participants: Eloy Lafuente (stronk7), Nicolas Martignoni, Petr Skoda and Samuli Karevaara
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE

Sub-Tasks:   All   Open   
 Sub-Task Progress: 
1.
 adodb does not support blob and clob updates with bound parameters Sub-task Resolved Resolved Petr Skoda  
2.
 pgsql does not support bound parameters in comments Sub-task Resolved Resolved Petr Skoda  
3.
 pgsql does not support bound queries in field default values Sub-task Resolved Resolved Petr Skoda  
4.
 some unknown problem in big query (1.5MB) test Sub-task Resolved Resolved Petr Skoda  
5.
 replace missing field non-standard workarounds in hotpot_restore_record() with new $DB->get_columns() Sub-task Resolved Resolved Petr Skoda  
6.
 Use proper placeholders for IN senteces Sub-task Resolved Resolved Petr Skoda  
7.
 rename xmldb stuff to follow lowercase guidelines Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
8.
 Installer script is broken Sub-task Resolved Resolved Petr Skoda  
9.
 prefix check shouldn't be perfomed by moodle_database classes Sub-task Resolved Resolved Petr Skoda  
10.
 preconfigure_dbconnection() stuff must be implemented in some way Sub-task Resolved Resolved Petr Skoda  
11.
 Fix one error in SetFetchMode() + minor clean Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
12.
 ADOdb Insert_ID() function under MSSQL, using placeholders doesn't work Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
13.
 M2: Implement mssql_adodb driver Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
14.
 M2: Implement oci8po_adodb driver Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
15.
 Move function emulate_bound_params() to adodb_moodle_database Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
16.
 Make generators stuff reentrant Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
17.
 M2: DDL and DML functional tests Sub-task Resolved Resolved Nicolas Connault  
18.
 moodle_database should have one disconnect method Sub-task Resolved Resolved Petr Skoda  
19.
 M2: Modify XMLDB Editor to suggest PHP code using the manager Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
20.
 M2: Modify XMLDB Editor to suggest creation conditional code Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
21.
 M2: Exception handling in DDL stuff Sub-task Resolved Resolved Petr Skoda  
22.
 M2: Normalize results returned from get_tables() get_indexes() and get_columns() Sub-task Resolved Resolved Petr Skoda  
23.
 M2: Tests get_tables() get_indexes() get_columns() Sub-task Resolved Resolved Nicolas Connault  
24.
 M2: Move moodle_recordset to separate class into lib/dml Sub-task Resolved Resolved Petr Skoda  
25.
 M2-M3-M4 Upgrade all code using DML Sub-task Resolved Resolved Petr Skoda  
26.
 reset_columns() implementation... Sub-task Closed Closed Petr Skoda  
27.
 Cleanup up deprecated functions so that we do not need to convert them Sub-task Resolved Resolved Petr Skoda  
28.
 add optional dmllib regex search support Sub-task Resolved Resolved Petr Skoda  
29.
 add magic quotes stripping option into data_submitted() Sub-task Resolved Resolved Petr Skoda  
30.
 M2: Move emulate_bound_params() from adodb drivers to adodb_moodle_database Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
31.
 undefined variable in oci raw insert $primarykey Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
32.
 M2: Enable dml/ddl functional tests for MSSQL and Oracle Sub-task Resolved Resolved Petr Skoda  
33.
 M2: adodb sessions switched to moodle sessions Sub-task Resolved Resolved Petr Skoda  
34.
 M2: implement some workaround for Oracle recordset rewind Sub-task Closed Closed Petr Skoda  
35.
 M2: delete_records should truncate table of delete of all records requested Sub-task Resolved Resolved Petr Skoda  
36.
 M2: implement full temp table support in ddl Sub-task Resolved Resolved Petr Skoda  
37.
 M4: stop using magic quotes Sub-task Resolved Resolved Petr Skoda  
38.
 M4: remove all dependencies on adodb code (except dml itself) Sub-task Resolved Resolved Petr Skoda  
39.
 M2: review missing $this-> inside dml/ddl code Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
40.
 Create one script to detect old uses of dml/ddl stuff Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
41.
 M2: basic read/write perf counter in moodle_database Sub-task Resolved Resolved Petr Skoda  
42.
 pdo patches from Andrei Sub-task Resolved Resolved Petr Skoda  
43.
 implement upgrade savepoints for mods and plugins Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
44.
 Some oddities in admin/report/courseoverview Sub-task Resolved Resolved Petr Skoda  
45.
 M5: Test all sql_xxx() helper functions Sub-task Resolved Resolved Petr Skoda  
46.
 Named parameters must accept repetitions Sub-task Resolved Resolved Petr Skoda  
47.
 M5: Add some more tests about CLOBs and BLOBs Sub-task Resolved Resolved Nicolas Connault  
48.
 cleanup the last stripslashes and friends Sub-task Resolved Resolved Petr Skoda  
49.
 Make sql_substr() to accept parameters instead of simply returning function name Sub-task Resolved Resolved Petr Skoda  
50.
 add new native mysqli dml driver Sub-task Resolved Resolved Petr Skoda  
51.
 implement exceptions instead of error() and print_error() in ddl, dml and dtl Sub-task Resolved Resolved Petr Skoda  
52.
 add new native pgsql dml driver Sub-task Resolved Resolved Petr Skoda  
53.
 move dbpersist option into dboptions Sub-task Resolved Resolved Petr Skoda  
54.
 implement dml_exceptions in drivers Sub-task Resolved Resolved Petr Skoda  
55.
 obsolete $CFG->dbfamily Sub-task Resolved Resolved Petr Skoda  
56.
 implement exceptions in all DML drivers Sub-task Resolved Resolved Petr Skoda  
57.
 make native drivers default if library not specified in config.php Sub-task Resolved Resolved Petr Skoda  
58.
 move reset_sequence into dbmanager Sub-task Resolved Resolved Petr Skoda  
59.
 Need to put back the debug code that tells you if your first column is not unique in get_records_sql Sub-task Resolved Resolved Petr Skoda  
60.
 postgres native driver, socket connection not working for me Sub-task Closed Closed Petr Skoda  
61.
 implement sql_modulo() method Sub-task Resolved Resolved Petr Skoda  
62.
 improve dml and ddl unit tests Sub-task Resolved Resolved Petr Skoda  
63.
 implement caching in get_tables() Sub-task Resolved Resolved Petr Skoda  
64.
 leading zores are chopped off from strings Sub-task Resolved Resolved Petr Skoda  
65.
 ADOdb ODBC Insert_ID() function under MSSQL doesn't work Sub-task Open Open Eloy Lafuente (stronk7)  
66.
 M2: Document xmldb/database/manager APIs Sub-task Open Open Eloy Lafuente (stronk7)  
67.
 M2-M3-M4: Document all changes to perform in code to use new XMLDD/DDL/DML libs properly Sub-task In Progress In Progress Eloy Lafuente (stronk7)  
68.
 M5: Finish the Tests page in Docs Sub-task Open Open Nicolas Connault  
69.
 M2: logging Sub-task Resolved Resolved Petr Skoda  
70.
 M2: profiling Sub-task Open Open Petr Skoda  
71.
 global search dml conversion Sub-task Open Open Valery Fremaux  
72.
 Analyse the impact and roadmap to move, under MSSQL, from ntext to nvarchar(max) Sub-task Open Open Eloy Lafuente (stronk7)  
73.
 Implement native MS sql server drivers (freetds and sqlsrv) Sub-task Open Open Petr Skoda  
74.
 Implement native Oracle DML driver Sub-task Open Open Petr Skoda  
75.
 do not check return value from isert_record and update_record and cleanup unused error messages replaced by new DML exceptions Sub-task Resolved Resolved Petr Skoda  
76.
 Drop enums support Sub-task Resolved Resolved Eloy Lafuente (stronk7)  
77.
 Complete coverage of DDL/DML tests Sub-task In Progress In Progress Eloy Lafuente (stronk7)  
78.
 improve db transactions Sub-task Resolved Resolved Petr Skoda  
79.
 remove obsoleted adodb database drivers before 2.0 branching Sub-task Open Open Eloy Lafuente (stronk7)  
80.
 Any field operation (drop, rename, change_xxx) must look for field dependencies (indexes, keys...) Sub-task Resolved Resolved Eloy Lafuente (stronk7)  

 Description  « Hide
General collection of tasks and bugs related to datalib rewrite for Moodle 2.0

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Petr Skoda added a comment - 04/May/08 07:54 AM
sanding some simple implementation of new dmllib,
it is very raw - some parts are probably broken, installer does not work, etc.
Inline docs are missing too.

[ Permalink | « Hide ]
Petr Skoda added a comment - 04/May/08 09:13 PM
sending more feature complete sample,
still only adodb mysql supported

[ Permalink | « Hide ]
Petr Skoda added a comment - 05/May/08 03:03 AM
Now sort of works with pg and mysql, all old dmllib functions with (.., $filed1, $value1, ..) and logging are redirected to the new library

[ Permalink | « Hide ]
Petr Skoda added a comment - 06/May/08 08:07 AM
sending latest patch - see wiki for details

[ Permalink | « Hide ]
Petr Skoda added a comment - 08/May/08 04:08 PM
fresh patch before the meeting

[ Permalink | « Hide ]
Petr Skoda added a comment - 10/May/08 07:09 AM - edited
to keep everybody informed: we (me and Eloy) discussed today needed changes in xmldb library - the changes are not major, just refactoring. Sample patch should be ready by Tuesday...

[ Permalink | « Hide ]
Petr Skoda added a comment - 12/May/08 01:18 AM
sending fresh patch with new dml and ddl stuff - good luck

[ Permalink | « Hide ]
Petr Skoda added a comment - 16/May/08 05:14 AM
fixed problem with undefined config settings, thanks Eloy

[ Permalink | « Hide ]
Petr Skoda added a comment - 16/May/08 05:40 AM - edited
patch landed in cvs:

TODO:

  • make mssql and ora work again
  • readd caching, better debugging and perf tracking
  • unit tests + functional tests
  • better docs
  • convert all code to use new API
  • etc.

[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 26/May/08 12:03 AM
I think taht the modification corresponding to this one: http://cvs.moodle.org/moodle/lang/en_utf8/help/richtext.html.diff?r1=1.10&r2=1.11 in lang packs will break pre-2.0 Moodle help files in all languages other than english, since we don't have branches for lang packs.

[ Permalink | « Hide ]
Petr Skoda added a comment - 26/May/08 02:31 AM - edited
I reviewed the code before the commit, the can_use_html_editor() I put there is available since 1.6 at least, I do not think it could break anything. Versions bellow 1.6 are not supported anymore.

Or did I miss something?


[ Permalink | « Hide ]
Petr Skoda added a comment - 26/May/08 02:36 AM - edited
Double checked it, the can_use_html_editor() was available in 1.6.0.
The only potential problem could be if somebody used <1.9.2 language pack in 2.0 which would not work anyway..

[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 26/May/08 03:38 PM
OK, thanks for the clarification. And sorry for the trouble.

[ Permalink | « Hide ]
Samuli Karevaara added a comment - 03/Jun/08 05:13 PM
Sweet Mother of all Patches :-O

[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 29/Apr/09 07:51 AM
Just for reference, I've applied a minor modif to the mssql driver to better handling of booleans and bug in set_field(). Just a tiny commit being part of the WIP.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.3-#344) - Bug/feature request - Atlassian news - Contact Administrators