Issue Details (XML | Word | Printable)

Key: MDL-14716
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Jerome Mouneyrac
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Install script: icon image are not displayed on the Server Checks page

Created: 07/May/08 10:52 AM   Updated: 13/May/08 04:35 PM
Return to search
Component/s: Installation
Affects Version/s: 1.9
Fix Version/s: 1.8.6, 1.9.1

File Attachments: 1. Text File install.php.patch.txt (0.6 kB)

Environment: WAMP + Vista

Database: Any
Participants: Eloy Lafuente (stronk7), Jerome Mouneyrac and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 08/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
Test:
- Take a clean Moodle or rename your config.old
- Run moodle (Installation script)
- Go through the installation to the "Server Checks" page.
- No icon image ( Firefox) or missing images (IE).

Cause:
weblib.php:
doc_link(...) {
...
if (empty($iconpath)) {
        $iconpath = $CFG->httpswwwroot . '/pix/docs.gif'; // PROBLEM: $CFG->httpswwwroot isn't define in install script
    }
...
}

Quick fix:
install.php:
case ENVIRONMENT: /// Environment checks
 + // Set CFG->httpswwwroot default value
 + // it is used to display icon image by doc_link() in weblib
 + global $CFG;
 + $CFG->httpswwwroot=$INSTALL['wwwrootform'];


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/May/08 11:04 AM
MDL-14716 Install script: icon image are now displayed on the Server Checks page
MODIFY install.php   Rev. 1.80.2.13    (+2 -1 lines)
Jerome Mouneyrac committed 1 file to 'Moodle CVS' - 08/May/08 11:08 AM
MDL-14716 Install script: icon image are now displayed on the Server Checks page, merged from19
MODIFY install.php   Rev. 1.94    (+2 -1 lines)
Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 08/May/08 11:09 AM
MDL-14716 Install script: icon image are now displayed on the Server Checks page, merged from19
MODIFY install.php   Rev. 1.65.2.12    (+2 -1 lines)