Issue Details (XML | Word | Printable)

Key: MDL-14736
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Marsden
Reporter: Dan Marsden
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

issue deleting temp dirs in backup

Created: 08/May/08 06:34 AM   Updated: 04/Mar/09 08:35 AM
Return to search
Component/s: Backup
Affects Version/s: 1.8.3, 1.9
Fix Version/s: 1.9.5, 2.0

File Attachments: 1. Text File backup_scheduled.txt (1 kB)
2. Text File restorelib.txt (2 kB)


Participants: Dan Marsden and Eloy Lafuente (stronk7)
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 03/Mar/09
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Hi Eloy,

this is related to the user post here:
http://moodle.org/mod/forum/discuss.php?d=95768#p426822

it seems to happen in backup_execute() in backuplib.php

obviously for some reason, backup_delete_old_data() is failing and not deleting the directories inside directories completely - I haven't looked closely - but is this a bug in backup_delete_old_dirs() ? - the user is using an older version of moodle so it's potentially fixed.....

I suggest we change the call in backup_execute:
            if (!defined('BACKUP_SILENTLY')) {
                error ("An error occurred deleting old backup data");
            }

... to use a debugging call instead of the error() function.. - the fact that it hasn't deleted all the old dirs in temp doesn't actually affect the backup itself, which should succeed fine, and simply displaying a warning should suffice IMO

thanks,

:-)


Dan

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) made changes - 08/May/08 07:30 AM
Field Original Value New Value
Fix Version/s 1.9.1 [ 10240 ]
Fix Version/s 1.8.6 [ 10270 ]
Affects Version/s 1.9 [ 10190 ]
Dan Marsden made changes - 08/May/08 07:34 AM
Assignee Eloy Lafuente (stronk7) [ stronk7 ] Dan Marsden [ danmarsden ]
Dan Marsden made changes - 14/May/08 08:23 AM
Attachment backup_scheduled.txt [ 13975 ]
Dan Marsden made changes - 14/May/08 08:24 AM
Attachment restorelib.txt [ 13976 ]
Martin Dougiamas made changes - 15/May/08 03:02 PM
Fix Version/s 1.9.2 [ 10280 ]
Fix Version/s 1.9.1 [ 10240 ]
Petr Skoda made changes - 05/Jul/08 07:21 PM
Fix Version/s 1.9.2 [ 10280 ]
Fix Version/s 1.9.3 [ 10290 ]
Fix Version/s 1.8.7 [ 10291 ]
Fix Version/s 1.8.6 [ 10270 ]
Martin Dougiamas made changes - 15/Oct/08 03:00 PM
Fix Version/s 1.9.3 [ 10290 ]
Fix Version/s 1.9.4 [ 10300 ]
Martin Dougiamas made changes - 15/Oct/08 04:01 PM
Fix Version/s 1.8.8 [ 10314 ]
Fix Version/s 1.8.7 [ 10291 ]
Petr Skoda made changes - 22/Jan/09 03:47 AM
Fix Version/s 1.9.4 [ 10300 ]
Fix Version/s 1.9.5 [ 10320 ]
Fix Version/s 1.8.9 [ 10322 ]
Fix Version/s 1.8.8 [ 10314 ]
Dan Marsden made changes - 03/Mar/09 10:19 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) made changes - 04/Mar/09 08:35 AM
Fix Version/s 1.8.9 [ 10322 ]
Status Resolved [ 5 ] Closed [ 6 ]
Fix Version/s 2.0 [ 10122 ]
QA Assignee stronk7