Issue Details (XML | Word | Printable)

Key: MDL-14736
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Marsden
Reporter: Dan Marsden
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

issue deleting temp dirs in backup

Created: 08/May/08 06:34 AM   Updated: 04/Mar/09 08:35 AM
Return to search
Component/s: Backup
Affects Version/s: 1.8.3, 1.9
Fix Version/s: 1.9.5, 2.0

File Attachments: 1. Text File backup_scheduled.txt (1 kB)
2. Text File restorelib.txt (2 kB)


Participants: Dan Marsden and Eloy Lafuente (stronk7)
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 03/Mar/09
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Hi Eloy,

this is related to the user post here:
http://moodle.org/mod/forum/discuss.php?d=95768#p426822

it seems to happen in backup_execute() in backuplib.php

obviously for some reason, backup_delete_old_data() is failing and not deleting the directories inside directories completely - I haven't looked closely - but is this a bug in backup_delete_old_dirs() ? - the user is using an older version of moodle so it's potentially fixed.....

I suggest we change the call in backup_execute:
            if (!defined('BACKUP_SILENTLY')) {
                error ("An error occurred deleting old backup data");
            }

... to use a debugging call instead of the error() function.. - the fact that it hasn't deleted all the old dirs in temp doesn't actually affect the backup itself, which should succeed fine, and simply displaying a warning should suffice IMO

thanks,

:-)


Dan

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Marsden committed 1 file to 'Moodle CVS' - 09/May/08 06:28 AM
MDL-14736 this doesn't need to be an error call, as the backup should still succeed - changing to use notify() instead.
MODIFY backup/backuplib.php   Rev. 1.208    (+2 -2 lines)
Dan Marsden committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/May/08 06:57 AM
MDL-14736 this doesn't need to be an error call, as the backup should still succeed - changing to use notify() instead.
MODIFY backup/backuplib.php   Rev. 1.179.2.28    (+2 -2 lines)
Dan Marsden committed 2 files to 'Moodle CVS' - 03/Mar/09 10:18 AM
MDL-14736 Backup/Restore don't halt backup if can't delete temp files - just display notification and save error to log table
MODIFY backup/restorelib.php   Rev. 1.370    (+8 -2 lines)
MODIFY backup/backup_scheduled.php   Rev. 1.50    (+6 -2 lines)