|
|
Hi Eloy,
this is related to the user post here:
http://moodle.org/mod/forum/discuss.php?d=95768#p426822
it seems to happen in backup_execute() in backuplib.php
obviously for some reason, backup_delete_old_data() is failing and not deleting the directories inside directories completely - I haven't looked closely - but is this a bug in backup_delete_old_dirs() ? - the user is using an older version of moodle so it's potentially fixed.....
I suggest we change the call in backup_execute:
if (!defined('BACKUP_SILENTLY')) {
error ("An error occurred deleting old backup data");
}
... to use a debugging call instead of the error() function.. - the fact that it hasn't deleted all the old dirs in temp doesn't actually affect the backup itself, which should succeed fine, and simply displaying a warning should suffice IMO
thanks,
:-)
Dan
|
|
Description
|
Hi Eloy,
this is related to the user post here:
http://moodle.org/mod/forum/discuss.php?d=95768#p426822
it seems to happen in backup_execute() in backuplib.php
obviously for some reason, backup_delete_old_data() is failing and not deleting the directories inside directories completely - I haven't looked closely - but is this a bug in backup_delete_old_dirs() ? - the user is using an older version of moodle so it's potentially fixed.....
I suggest we change the call in backup_execute:
if (!defined('BACKUP_SILENTLY')) {
error ("An error occurred deleting old backup data");
}
... to use a debugging call instead of the error() function.. - the fact that it hasn't deleted all the old dirs in temp doesn't actually affect the backup itself, which should succeed fine, and simply displaying a warning should suffice IMO
thanks,
:-)
Dan |
Show » |
committed 1 file to 'Moodle CVS' - 09/May/08 06:28 AM
MDL-14736 this doesn't need to be an error call, as the backup should still succeed - changing to use notify() instead.
|
|
|
committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/May/08 06:57 AM
MDL-14736 this doesn't need to be an error call, as the backup should still succeed - changing to use notify() instead.
|
|
|
committed 2 files to 'Moodle CVS' - 03/Mar/09 10:18 AM
MDL-14736 Backup/Restore don't halt backup if can't delete temp files - just display notification and save error to log table
|
|
|
|