Issue Details (XML | Word | Printable)

Key: MDL-14740
Type: Sub-task Sub-task
Status: Open Open
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Martin Dougiamas
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-11113

Create directory in HEAD for Moodle editor plugin code lib/editormod

Created: 08/May/08 11:48 AM   Updated: 16/Jun/09 05:08 PM
Component/s: HTML Editor
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Relates
 

Participants: Marc Grober, Martin Dougiamas, Mathieu Petit-Clair and Petr Skoda
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Some plugins will have to be written for each editor to make integration with Moodle possible. These should be as abstracted as possible, to make as much code as possible common between each. Since editors will be located under /lib/editor, let's store this common code under /lib/editormod.

    * File browser: the file browser (especially with the File API) will be Moodle specific
    * Emoticons (smileys): Moodle defines its own list of emoticons, we need to make sure the editors use these consistently
    * Language files: Moodle has a lot more languages than any editors, and some strings will be Moodle-specific. We need a way to make for each editor to use Moodle strings, reusing as many existing strings as possible, and using lang/xx/editor.php for the rest.
    * Equation editor: there is ongoing work to get Dragmath working in Moodle, making a common plugin could be a nice improvement
    * Multilang: all editors need to support multilang properly.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Marc Grober added a comment - 12/Aug/08 06:30 AM
Forum discussion I think may favor a "common" directory which would might logically be found at /lib/editor/common.

I am not sure what is meant by "ongoing work to get dragmath working in moodle" as dragmath has been working in moodle for quite some time. At this point I think it more a question of seeing an adopted infrastructure so it is clear what the course is.

On the other hand, there could be some argument that Moodle should offer another editor that is targeted at math/science (something along the lines of the work that was done with equation editor in xinha could be extended to make equations editable after insertion and alleviate the need for an external java app, but I think that is going a bit in the wrong direction.

There has also been some discussion in the forums about striving for a common API for editors and plugins. While Mauno has noted some issues, I think generally this is something that really has to be pursued.

And I am not sure whether things are going piecemeal or what but was surprised to see that under http://tracker.moodle.org/browse/MDL-15254 dragmath had been moved to common.... as noted above I think this is a good idea, but I am not sure how this squares with any other development for the html editor for moodle 2


Marc Grober added a comment - 12/Aug/08 06:32 AM
Is this a duplicate or am I missing something here?
WIll tinyMCE be the only editor packaged with Moodle 2?
If not what will the architecture look like so that we can be sure that dragmath or other plugins work with everything?

Marc Grober made changes - 12/Aug/08 06:32 AM
Field Original Value New Value
Link This issue has been marked as being related by MDL-15254 [ MDL-15254 ]
Mathieu Petit-Clair added a comment - 18/Aug/08 03:54 PM
Long time without updating this issue, so here's an update that should explain where we are now...

TinyMCE will be the only editor distributed in the official package. It will be possible to setup other editors (which would be FCKeditor or Xinha I guess - and both will require work to be active), but it would be significant work to integrate them with the translation system (which I've done for TinyMCE). Same goes for the new file picker (and related features, see fileapi information on the wiki), which can be integrated with FCKeditor, but it would need some work (the editor deals with file in a different way than Tiny does). TinyMCE can activate itself for all textareas (having - or not - certain CSS classes), other editors might need to be activated per-field. Other editors do that differently... We'll see what we have time to work on before 2.0 is released.

Common plugin layer would be nice, but TinyMCE is the only editor that allows to provide a path to plugins - all other editors need the files in their own directory. This makes a common folder a hard goal to achieve at this time... at least if we want to minimize the modifications done to each editor.

Dragmath was included as a plugin to TinyMCE in 1.9 .. which was not active by default. It is now... This should explain the "ongoing". Now, the Dragmath plugin for tinymce is in the TinyMCE folder .. but the Dragmath files are in the /lib/editor/common folder. If some other editor provides a plugin to Dragmath, then it can link to these files. This is not a change in functionality, but it makes file location a bit more logical.


Marc Grober added a comment - 19/Aug/08 01:46 AM
see my comment on the related link vis-a-vis there is more than the dragmath "plugin" in the tinyMCE directory

The problem with directories could easily be resolved with symbolic links as far as real operating systems..... I guess the question I might pose is why avoid such a solution to accommodate closed and/or proprietary architectures..... on the other hand, who knows, maybe some of those "other" OS have started to come of age and provide such options......


Petr Skoda made changes - 16/Jun/09 05:06 PM
Assignee Mathieu Petit-Clair [ scyrma ] Petr Skoda [ skodak ]
Petr Skoda added a comment - 16/Jun/09 05:08 PM
A lot has changed:
1/ editors are now fully pluggable
2/ file browser is implemented separately
3/ tinymce language handling was rewritten
4/ dragmath is in core

TODO:
decide how to solve multilang, probably by going back to <lang> tag
ascii math