Moodle

pgsql does not support bound parameters in comments

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

throws some silly "$1 syntax error" in query

workaround:

  • remove all [?$:] and quote
  • report upstream and wait for fix (not likely)
  • write bound query emulation function - yuck

Activity

Hide
Petr Škoda (skodak) added a comment -

I might have better solution, going to hack $DB->execute() so that it detects comments and emulates bound queries..

Show
Petr Škoda (skodak) added a comment - I might have better solution, going to hack $DB->execute() so that it detects comments and emulates bound queries..
Hide
Petr Škoda (skodak) added a comment -

solved in patch

Show
Petr Škoda (skodak) added a comment - solved in patch
Hide
Eloy Lafuente (stronk7) added a comment -

I guess this was fixed by avoiding bounds in DDL stuff correct? As we discussed in chat (long execute.... named function). Or not?

Show
Eloy Lafuente (stronk7) added a comment - I guess this was fixed by avoiding bounds in DDL stuff correct? As we discussed in chat (long execute.... named function). Or not?
Hide
Petr Škoda (skodak) added a comment -

bound parameters avoided in ddllib

Show
Petr Škoda (skodak) added a comment - bound parameters avoided in ddllib

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: