[#MDL-14785] pgsql does not support bound parameters in comments

Issue Details (XML | Word | Printable)

Key:	MDL-14785
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14679

pgsql does not support bound parameters in comments

Created: 12/May/08 01:12 AM Updated: 16/May/08 02:42 PM

Return to search

Component/s:

Database SQL/XMLDB

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Eloy Lafuente (stronk7) and Petr Skoda
Security Level:	None
Resolved date:	16/May/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

throws some silly "$1 syntax error" in query

workaround:
* remove all [?$:] and quote
* report upstream and wait for fix (not likely)
* write bound query emulation function - yuck

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 12/May/08 04:51 AM

Field	Original Value	New Value
Assignee	Eloy Lafuente (stronk7) [ stronk7 ]	Petr Skoda [ skodak ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 12/May/08 04:53 AM

I might have better solution, going to hack $DB->execute() so that it detects comments and emulates bound queries..

[ Permalink | « Hide ]

Petr Skoda added a comment - 13/May/08 07:09 AM

solved in patch

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 16/May/08 07:07 AM

I guess this was fixed by avoiding bounds in DDL stuff correct? As we discussed in chat (long execute.... named function). Or not?

[ Permalink | « Hide ]

Petr Skoda added a comment - 16/May/08 02:42 PM

bound parameters avoided in ddllib

Petr Skoda made changes - 16/May/08 02:42 PM

Fix Version/s		2.0 [ 10122 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.