Issue Details (XML | Word | Printable)

Key: MDL-14789
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

replace missing field non-standard workarounds in hotpot_restore_record() with new $DB->get_columns()

Created: 12/May/08 03:13 AM   Updated: 17/Jun/08 05:09 AM
Return to search
Component/s: Hotpot
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Gordon Bateson and Petr Skoda
Security Level: None
Resolved date: 17/Jun/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Hello,
I have noticed some unusual code in hotpot_restore_record(), please fix them after the new dml and ddl stuff gets committed into HEAD,
the reason is we are no longer relying on adodb, fortunately there will be some new functions you could use (see $DB->get_columns())

Petr

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 12/May/08 04:23 AM
Field Original Value New Value
Summary replace missing field non-stabdard workarounds in hotpot_restore_record() with new $DB->get_columns() replace missing field non-standard workarounds in hotpot_restore_record() with new $DB->get_columns()
Gordon Bateson added a comment - 14/May/08 08:00 AM
Hi Petr,
am I right in thinking that at the moment this is not an issue and there is nothing to be fixed?

Please give me a shout when the new dml and ddl stuff gets committed into HEAD.

thanks
Gordon


Petr Skoda added a comment - 14/May/08 03:29 PM
thanks,
we are planning the datalib changes commit for later this week.

Petr Skoda added a comment - 16/May/08 03:02 PM
the patch landed in cvs

Petr Skoda committed 1 file to 'Moodle CVS' - 17/Jun/08 05:08 AM
MDL-14789 meta_type now used instead of type
MODIFY mod/hotpot/restorelib.php   Rev. 1.30    (+2 -2 lines)
Petr Skoda made changes - 17/Jun/08 05:08 AM
Assignee Gordon Bateson [ xxxxxxx ] Petr Skoda [ skodak ]
Petr Skoda added a comment - 17/Jun/08 05:09 AM
should be now fixed in cvs

Petr Skoda made changes - 17/Jun/08 05:09 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]