Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.9
• Fix Version/s: None
• Component/s: Backup
• Labels:

  None

thanks to Sam Marshall for details regarding this bug.

backup_module in backuplib.php these lines:

foreach ($preferences->mods[$module]->instances as
$instance => $object) {
if (!empty($object->backup)) { $status = $onemodbackup($bf,$preferences,$instance); }
}

overwrite the $status flag and doesn't notify about anything failing - should change to something like this (untested!)
foreach ($preferences->mods[$module]->instances as $instance => $object) {
if (!empty($object->backup)) {
$statusm = $onemodbackup($bf,$preferences,$instance);
if (!$statusm) { notify('backup of:'.$module.'-'.$instance.' failed.'); $status = false; }
}
}

--should also check to see if backup is silent and only notify when not silent, and should log an entry to backup_log

Dan

• Assignee:

  Dan Marsden

  Reporter:

  Dan Marsden

  Tester:

  Nobody

  Participants:

  Dan Marsden

• Created:

  13/May/08 7:30 AM

  Updated:

  17/Dec/10 1:36 PM

  Resolved:

  13/May/08 7:34 AM