Moodle

Grade item calculation formula not restored properly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Calculation formulas are not properly restored, since they are not "normalized" (generating an Error in the gradebook).

In backup/backuplib.php the following code:

// use [idnumber] in calculation instead of giXXX#
fwrite ($bf,full_tag("CALCULATION",5,false,$grade_item->get_calculation()));

does not have a correspondance in backup/restorelib.php

I suppose that the set_calculation(...) function must be called somewhere.

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

Could you please test the latest weekly? It should be already fixed.

Show
Petr Škoda (skodak) added a comment - Could you please test the latest weekly? It should be already fixed.
Hide
Vitor Rocio added a comment -

Yes, I confirm it's fixed.

Show
Vitor Rocio added a comment - Yes, I confirm it's fixed.
Hide
Eloy Lafuente (stronk7) added a comment -

Closing as fixed for 1.9.1... thanks for feedback.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Closing as fixed for 1.9.1... thanks for feedback. Ciao

People

Dates

  • Created:
    Updated:
    Resolved: