[#MDL-14854] XMLDB editor should check for inconsistent default values

Moodle

XMLDB editor should check for inconsistent default values

Created: 15/May/08 10:42 PM Updated: 29/May/08 06:56 PM

Component/s:

Administration

Affects Version/s:

1.9.1, 2.0

Fix Version/s:

2.0

Database:	Any
Participants:	Eloy Lafuente (stronk7), Howard Miller and Petr Škoda
Security Level:	None

Description

« Hide

The XMLDB editor should have a check for inconsistent default values for fields. I've found several instances where they have been wrong, and it can cause some really subtle errors.

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Howard Miller - 15/May/08 10:55 PM

Can now check for inconsistent/missing defaults.

[ Permlink | « Hide ]

Petr Škoda - 15/May/08 11:51 PM

Pretty please next time file the bug in advance before committing stuff into cvs, ideally before you start working on something :-(
1/ it gives anybody chance to review it - both the code and the general idea
2/ it helps with commit synchronisation of commits

[ Permlink | « Hide ]

Eloy Lafuente (stronk7) - 16/May/08 12:11 AM

Hi Howard,

while the idea is good... I think current implementation is slightly imperfect (in fact I've checked it doesn't work under PostgreSQL at all, and I guess it won't work under MSSQL and Oracle either).

So I'm going to revert your changes in MOODLE_19_STABLE while leaving them under HEAD. Just today we are going to introduce major changes under HEAD (related to handling databases) and the idea will be usable there...

I second Petr's comments, specially in the 19_STABLE release (it's not the best target to introduce new functionalities so quickly).

Ciao :-)

P.S: Reopening this bug and addressing it for 2.0

[ Permlink | « Hide ]

Howard Miller - 16/May/08 01:27 AM

oops....

Sorry, for recklessness :-)

Having thought about it some more, I wonder if it makes sense to do a single check that makes sure the database schema is correct in as many respects as possible. We've had a quite a few mysterious bugs that come back to database problems (been upgrading since 1.3.something).

Ok - the day has come to install a Postgres version and (at least) make this work with that. Can't help you with the other regrettably, but I guess there aren't so many people about with ancient databases other than MySQL or Postgres.

Cheers!

[ Permlink | « Hide ]

Petr Škoda - 16/May/08 01:36 AM

I already made it work in my patch which should be committed today ;-)

[ Permlink | « Hide ]

Petr Škoda - 27/May/08 11:06 PM

the 'butis' lang string is, ehm, not nice at all - we must not construct sentences from strings this way

[ Permlink | « Hide ]

Howard Miller - 28/May/08 04:23 AM

I take it you would prefer something like "Current Value:' and "Expected Value"?

[ Permlink | « Hide ]

Petr Škoda - 28/May/08 05:12 AM

Anything that can be translated into other languages ;-)

[ Permlink | « Hide ]

Howard Miller - 29/May/08 06:56 PM

Have changed the strings to 'expected' and 'actual'.