Issue Details (XML | Word | Printable)

Key: MDL-14858
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Nobody
Reporter: Séverin Terrier
Votes: 1
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Description of advanced upload assignment is shown in calendar despite "Hide description before available date"

Created: 16/May/08 12:13 AM   Updated: 26/Oct/09 12:16 PM
Return to search
Component/s: Assignment, Calendar
Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5
Fix Version/s: 1.8.11

Participants: Nobody, Petr Skoda, Susan Mangan, Séverin Terrier and Valery Fremaux
Security Level: None
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
When an "advanced upload" is configured with "Hide description before available date", students can't see the complete information in the "assignment" :-)

But they can see all the description (and the optionnal attached files) by the calendar, looking at the day of opening :-(

Steps to reproduce :
1 : As a teacher, create an advanced upload file assignment
2 : choose the option "Hide description before available date", and put a "reserved" description
3 : login as student
4 : open the calendar, and go to the day "Available from" of the assignment
5 : you CAN see the "reserved" description, but you shouldn't :-(

This is a big functionnal bug, because teacher think they can put instructions students won't see, but students can see it...

This bugs isn't in 1.9.1 :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Séverin Terrier added a comment - 16/May/08 12:51 AM - edited
Don't know if it can help, but in 1.9, the lines taking care about that are in moodle/calendar/lib.php near
// TODO: rewrite this hack somehow
and
if ($assignmentinstance->description_is_hidden()){//force not to show description before availability
$event->description = get_string('notavailableyet', 'assignment');

Valery Fremaux added a comment - 17/May/08 10:33 PM
Severin, I didn't find that lines in 1.9.

What is certain, is that calendar SHOULD NEVER REFER to assignement or any explicit module semantics. This a breakover on modularity and uncoupling.

I suggest the best solution should be :

When generating events in assessment, to twick the description there, and store a shadowed description in event table.

The cron function for assessments shoud then scan for opening assessments, point again the calendar related events and restablish correct description.

This is a first solution not using the event framework.

There should be some using it, but I'm not sure there is a great movement for developping event approach. I would have liked to have MartinD actual position on the question...

I think I can work about 15 minutes on the patch (without events).


Séverin Terrier added a comment - 18/May/08 05:18 PM
These lines are in 1.9.1...

Séverin Terrier made changes - 17/Jun/08 09:52 PM
Field Original Value New Value
Affects Version/s 1.8.3 [ 10230 ]
Affects Version/s 1.8 [ 10130 ]
Affects Version/s 1.8.4 [ 10242 ]
Affects Version/s 1.8.2 [ 10220 ]
Affects Version/s 1.8.1 [ 10213 ]
Petr Skoda added a comment - 06/Jul/08 07:58 AM
I agree this is definitely not a nice hack, unfortunately it relies on other code from 1.9.x, backport is not trivial.

Anybody wants to work on this?


Petr Skoda made changes - 06/Jul/08 07:58 AM
Priority Critical [ 2 ] Major [ 3 ]
Assignee Petr Skoda [ skodak ] Nobody [ nobody ]
Petr Skoda made changes - 09/Jul/08 10:12 PM
Fix Version/s 1.8.7 [ 10291 ]
Fix Version/s 1.8.6 [ 10270 ]
Susan Mangan added a comment - 11/Sep/08 07:00 AM
Is there some code I can manually plug into a php file for this bug? We are still using 1.8 and have instructors posting exams (don't ask....) in the Description field of the Advanced Upload of Files Assignment Activity. I thought we would upgrade to 1.9 this Fall so I wouldn't have to worry about this particular issue, but we have not upgraded.. sadly. (don' ask....)

Thanks in advance!!!


Martin Dougiamas made changes - 15/Oct/08 04:01 PM
Fix Version/s 1.8.7 [ 10291 ]
Fix Version/s 1.8.8 [ 10314 ]
Petr Skoda made changes - 22/Jan/09 08:08 AM
Fix Version/s 1.8.9 [ 10322 ]
Fix Version/s 1.8.8 [ 10314 ]
Martin Dougiamas made changes - 15/May/09 05:54 PM
Fix Version/s 1.8.10 [ 10350 ]
Fix Version/s 1.8.9 [ 10322 ]
Martin Dougiamas made changes - 26/Oct/09 12:16 PM
Fix Version/s 1.8.11 [ 10383 ]
Fix Version/s 1.8.10 [ 10350 ]