Moodle

Unsubscribe link displayed on Site News forcing subscriptions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.5
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Site News forum forces everyone to be subscribed forever however 'Unsubscribe me from this forum' link is displayed.
When unsubscribe link clicked (by any user including Admin & student) the message "Everyone is now subscribed to this forum" message appears...
See attached screen shots - I'm sorry I can't provide the URL of our site as we have forced authentication.

Refer Forum: http://moodle.org/mod/forum/discuss.php?d=97146

Activity

Hide
Tim Hunt added a comment -

Steps to reproduce:

1. As admin, go to front page settings, and ensure that news items are selected to be displayed on the front page when users are logged in.
2. Go and post a front page news story.
3. In the main menu block, click on the Site news forum.
4. Click on the Force everyone to be subscribed link - observe that the subscribe/unsubscribe link on this page goes away.
5. Go back to the front page.

What acutally happens: There is an unsubscribe link just under the Site news heading.

What should happen: The link should not be there if users are not allowed to unsubscribe from this forum.

Show
Tim Hunt added a comment - Steps to reproduce: 1. As admin, go to front page settings, and ensure that news items are selected to be displayed on the front page when users are logged in. 2. Go and post a front page news story. 3. In the main menu block, click on the Site news forum. 4. Click on the Force everyone to be subscribed link - observe that the subscribe/unsubscribe link on this page goes away. 5. Go back to the front page. What acutally happens: There is an unsubscribe link just under the Site news heading. What should happen: The link should not be there if users are not allowed to unsubscribe from this forum.
Hide
Helen Foster added a comment -

Adding a VIP watcher and a fix version in the hope that this issue can be resolved soon.

Show
Helen Foster added a comment - Adding a VIP watcher and a fix version in the hope that this issue can be resolved soon.
Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Dong. Can you plz, confirm if the problem is still happening (see steps to reproduce above) and, if so, fix it? TIA!

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dong. Can you plz, confirm if the problem is still happening (see steps to reproduce above) and, if so, fix it? TIA!
Hide
Dongsheng Cai added a comment -

Fixed, thanks your steps, tim, please review.

Show
Dongsheng Cai added a comment - Fixed, thanks your steps, tim, please review.
Hide
Eloy Lafuente (stronk7) added a comment -

Getting QA of this.

Dong, the "unsubscribe" is not showed now, perfect! Anyway, with debug enabled to developer level... I'm getting:

Notice: Undefined variable: subtext in moodle_19_stable/index.php on line 210

I guess you need to init that variable to '' or similar because now it isn't always defined.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Getting QA of this. Dong, the "unsubscribe" is not showed now, perfect! Anyway, with debug enabled to developer level... I'm getting: Notice: Undefined variable: subtext in moodle_19_stable/index.php on line 210 I guess you need to init that variable to '' or similar because now it isn't always defined. Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

reopening until fix arrives (not critical but better to leave this open).

Show
Eloy Lafuente (stronk7) added a comment - reopening until fix arrives (not critical but better to leave this open).
Hide
Dongsheng Cai added a comment -

Fixed, thanks for your testing

Show
Dongsheng Cai added a comment - Fixed, thanks for your testing
Hide
Dongsheng Cai added a comment -

sorry for the "undefined err"

Show
Dongsheng Cai added a comment - sorry for the "undefined err"
Hide
Eloy Lafuente (stronk7) added a comment -

Closing. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing. Thanks!

Dates

  • Created:
    Updated:
    Resolved: