Issue Details (XML | Word | Printable)

Key: MDL-14863
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 5
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

rename xmldb stuff to follow lowercase guidelines

Created: 16/May/08 11:04 AM   Updated: 22/May/08 08:19 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7) and Martin Dougiamas
Security Level: None
Resolved date: 22/May/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
classes, functions and methods must be all lowercase. Modify all the XMLDB stuff to fulfil that.

Also, discuss:

1) drop the XMLDB part of the name of objects
2) constants...
3)...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) committed 24 files to 'Moodle CVS' - 21/May/08 01:06 AM
MDL-14863 - 1st iteration: lowercase XMLDB constants, object, file and structure (no changes in public API yet)
MODIFY admin/xmldb/actions/view_structure_php/view_structure_php.class.php   Rev. 1.12    (+5 -5 lines)
DEL lib/xmldb/Attic/XMLDBStructure.class.php   Rev. 1.2    (+0 -0 lines)
ADD lib/xmldb/xmldb_structure.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/xmldb/actions/load_xml_file/load_xml_file.class.php   Rev. 1.9    (+3 -3 lines)
MODIFY admin/xmldb/actions/view_table_php/view_table_php.class.php   Rev. 1.17    (+17 -17 lines)
MODIFY lib/ddl/database_manager.php   Rev. 1.3    (+3 -3 lines)
MODIFY admin/xmldb/actions/check_defaults/check_defaults.class.php   Rev. 1.4    (+3 -3 lines)
MODIFY lib/ddl/sql_generator.php   Rev. 1.3    (+2 -2 lines)
ADD lib/xmldb/xmldb_object.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/xmldb/Attic/XMLDBKey.class.php   Rev. 1.2    (+3 -3 lines)
ADD lib/xmldb/xmldb_constants.php   Rev. 1.1    (+0 -0 lines)
DEL lib/xmldb/Attic/XMLDBObject.class.php   Rev. 1.2    (+0 -0 lines)
MODIFY lib/xmldb/Attic/XMLDBIndex.class.php   Rev. 1.2    (+3 -3 lines)
MODIFY lib/xmldb/Attic/XMLDBTable.class.php   Rev. 1.2    (+3 -3 lines)
MODIFY admin/xmldb/index.php   Rev. 1.13    (+6 -6 lines)
DEL lib/xmldb/Attic/XMLDBConstants.php   Rev. 1.2    (+0 -0 lines)
DEL lib/xmldb/Attic/XMLDBFile.class.php   Rev. 1.2    (+0 -0 lines)
MODIFY lib/xmldb/Attic/XMLDBStatement.class.php   Rev. 1.2    (+3 -3 lines)
ADD lib/xmldb/xmldb_file.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/xmldb/actions/load_xml_files/load_xml_files.class.php   Rev. 1.4    (+3 -3 lines)
MODIFY admin/xmldb/actions/check_bigints/check_bigints.class.php   Rev. 1.5    (+3 -3 lines)
MODIFY admin/xmldb/actions/check_indexes/check_indexes.class.php   Rev. 1.8    (+3 -3 lines)
MODIFY lib/ddllib.php   Rev. 1.65    (+7 -7 lines)
MODIFY lib/xmldb/Attic/XMLDBField.class.php   Rev. 1.2    (+3 -3 lines)
Eloy Lafuente (stronk7) committed 46 files to 'Moodle CVS' - 21/May/08 07:24 AM
MDL-14863 - 1st iteration: lowercase XMLDB table, field, index, key and statement +
wrapper class to support old syntax (no changes in public API yet)
MODIFY lib/xmldb/xmldb_structure.php   Rev. 1.2    (+8 -8 lines)
MODIFY mod/data/db/upgrade.php   Rev. 1.15    (+5 -5 lines)
MODIFY admin/xmldb/actions/new_table_from_mysql/new_table_from_mysql.class.php   Rev. 1.10    (+10 -10 lines)
MODIFY admin/xmldb/actions/edit_key/edit_key.class.php   Rev. 1.9    (+6 -6 lines)
DEL lib/xmldb/Attic/XMLDBIndex.class.php   Rev. 1.3    (+0 -0 lines)
MODIFY admin/xmldb/actions/new_table/new_table.class.php   Rev. 1.7    (+5 -5 lines)
MODIFY admin/xmldb/actions/new_field/new_field.class.php   Rev. 1.6    (+3 -3 lines)
MODIFY admin/xmldb/actions/new_index/new_index.class.php   Rev. 1.6    (+3 -3 lines)
DEL lib/xmldb/Attic/XMLDBKey.class.php   Rev. 1.3    (+0 -0 lines)
DEL lib/xmldb/Attic/XMLDBField.class.php   Rev. 1.3    (+0 -0 lines)
MODIFY admin/xmldb/actions/edit_key_save/edit_key_save.class.php   Rev. 1.8    (+3 -3 lines)
MODIFY blocks/db/Attic/upgrade.php   Rev. 1.3    (+3 -3 lines)
MODIFY mod/feedback/db/upgrade.php   Rev. 1.10    (+34 -34 lines)
DEL lib/xmldb/Attic/XMLDBStatement.class.php   Rev. 1.3    (+0 -0 lines)
MODIFY admin/xmldb/actions/edit_field_save/edit_field_save.class.php   Rev. 1.8    (+3 -3 lines)
MODIFY lib/ddl/simpletest/Attic/testddllib.php   Rev. 1.3    (+45 -45 lines)
ADD lib/xmldb/xmldb_table.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/db/upgrade.php   Rev. 1.200    (+11 -11 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_database.php   Rev. 1.6    (+2 -2 lines)
MODIFY lib/ddl/postgres_sql_generator.php   Rev. 1.3    (+11 -11 lines)
MODIFY admin/xmldb/actions/edit_index_save/edit_index_save.class.php   Rev. 1.8    (+3 -3 lines)
MODIFY admin/xmldb/actions/view_table_php/view_table_php.class.php   Rev. 1.18    (+31 -31 lines)
MODIFY lib/ddllib.php   Rev. 1.66    (+7 -7 lines)
MODIFY admin/xmldb/actions/edit_table_save/edit_table_save.class.php   Rev. 1.10    (+3 -3 lines)
MODIFY lib/ddl/mysql_sql_generator.php   Rev. 1.3    (+8 -8 lines)
MODIFY lib/simpletest/fixtures/gradetest.php   Rev. 1.35    (+14 -14 lines)
ADD lib/xmldb/xmldb_key.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/ddl/sql_generator.php   Rev. 1.4    (+34 -34 lines)
ADD lib/xmldb/xmldb_index.php   Rev. 1.1    (+0 -0 lines)
ADD lib/xmldb/xmldb_field.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/xmldb/index.php   Rev. 1.14    (+6 -6 lines)
MODIFY lib/ddl/mssql_sql_generator.php   Rev. 1.4    (+14 -14 lines)
MODIFY mod/lesson/db/upgrade.php   Rev. 1.13    (+4 -4 lines)
MODIFY admin/xmldb/actions/edit_field/edit_field.class.php   Rev. 1.8    (+10 -10 lines)
MODIFY lib/xmldb/xmldb_file.php   Rev. 1.2    (+2 -2 lines)
MODIFY admin/xmldb/actions/new_key/new_key.class.php   Rev. 1.6    (+3 -3 lines)
MODIFY admin/xmldb/actions/test/test.class.php   Rev. 1.42    (+46 -46 lines)
MODIFY lib/ddl/oracle_sql_generator.php   Rev. 1.3    (+14 -14 lines)
MODIFY admin/xmldb/actions/check_indexes/check_indexes.class.php   Rev. 1.9    (+2 -2 lines)
MODIFY admin/xmldb/actions/new_statement/new_statement.class.php   Rev. 1.7    (+9 -9 lines)
MODIFY admin/xmldb/actions/view_structure_php/view_structure_php.class.php   Rev. 1.13    (+4 -4 lines)
MODIFY lib/ddl/database_manager.php   Rev. 1.4    (+89 -89 lines)
MODIFY admin/xmldb/actions/edit_statement/edit_statement.class.php   Rev. 1.8    (+3 -3 lines)
DEL lib/xmldb/Attic/XMLDBTable.class.php   Rev. 1.3    (+0 -0 lines)
MODIFY admin/xmldb/actions/edit_index/edit_index.class.php   Rev. 1.9    (+4 -4 lines)
ADD lib/xmldb/xmldb_statement.php   Rev. 1.1    (+0 -0 lines)
Eloy Lafuente (stronk7) committed 3 files to 'Moodle CVS' - 22/May/08 01:55 AM
3rd iteration committed: xmldb_table "public" methods changed + debugging of deprecated ones until Moodle 2.1 . MDL-14863
MODIFY admin/xmldb/actions/test/test.class.php   Rev. 1.43    (+34 -34 lines)
MODIFY admin/xmldb/actions/view_structure_php/view_structure_php.class.php   Rev. 1.14    (+4 -4 lines)
MODIFY lib/xmldb/xmldb_table.php   Rev. 1.2    (+38 -4 lines)
Eloy Lafuente (stronk7) committed 12 files to 'Moodle CVS' - 22/May/08 08:09 AM
4th iteration committed: xmldb_field, xmldb_index and xmldb_key "public" methods changed + debugging of deprecated ones until Moodle 2.1 . MDL-14863
MODIFY admin/xmldb/actions/view_table_php/view_table_php.class.php   Rev. 1.19    (+15 -29 lines)
MODIFY admin/xmldb/actions/test/test.class.php   Rev. 1.44    (+40 -49 lines)
MODIFY mod/feedback/db/upgrade.php   Rev. 1.11    (+23 -30 lines)
MODIFY lib/xmldb/xmldb_table.php   Rev. 1.3    (+4 -7 lines)
MODIFY lib/xmldb/xmldb_index.php   Rev. 1.2    (+15 -4 lines)
MODIFY lib/ddl/sql_generator.php   Rev. 1.5    (+3 -5 lines)
MODIFY blocks/db/Attic/upgrade.php   Rev. 1.4    (+2 -2 lines)
MODIFY lib/xmldb/xmldb_key.php   Rev. 1.2    (+17 -5 lines)
MODIFY mod/lesson/db/upgrade.php   Rev. 1.14    (+2 -2 lines)
MODIFY lib/xmldb/xmldb_field.php   Rev. 1.2    (+16 -4 lines)
MODIFY lib/db/upgrade.php   Rev. 1.201    (+6 -11 lines)
MODIFY mod/data/db/upgrade.php   Rev. 1.16    (+3 -5 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators