Issue Details (XML | Word | Printable)

Key: MDL-14864
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Dongsheng Cai
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

Installer script is broken

Created: 16/May/08 01:12 PM   Updated: 20/May/08 02:07 AM
Return to search
Component/s: Installation
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File installer_and_other_5.patch (64 kB)
2. Text File installer_and_other_6.patch (64 kB)
Environment: Ubuntu, PHP5, Mysql 5, Apache2

Database: MySQL
Participants: Dongsheng Cai, Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
QA Assignee: Dongsheng Cai
Resolved date: 20/May/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
When I installing a new moodle (HEAD), the installation stopped in environment checking page, it said:

Checking your environment ...

We are checking if the various components of your system meet the system requirements

Fatal error: Call to a member function setup_is_unicodedb() on a non-object in /var/www/m20/lib/environmentlib.php on line 707

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 16/May/08 02:39 PM
Field Original Value New Value
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Parent MDL-14679 [ 26259 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 16/May/08 02:40 PM
yes, the installer does not work yet, it is still heavily depending on adodb and odl dmllib
workaround is to create config.php manually

Petr Skoda made changes - 16/May/08 02:40 PM
Summary Installation process is broken Installer scropt is broken
Petr Skoda made changes - 16/May/08 02:40 PM
Assignee Eloy Lafuente (stronk7) [ stronk7 ] Petr Skoda [ skodak ]
Petr Skoda made changes - 16/May/08 02:40 PM
Summary Installer scropt is broken Installer script is broken
[ Permalink | « Hide ]
Petr Skoda added a comment - 19/May/08 05:55 AM
sending a patch that solves several issues:
  • installer works again (db creation still missing though)
  • the prefix checks moved to database classes again
  • detection of missing php extensions added
  • new support for $external (non-moodle) databases
  • added driver specific options
  • connect info moved from constructor to connect() method
  • fixed print_error() before db connected and themes setup
  • other minor changes and API improvements

Petr Skoda made changes - 19/May/08 05:55 AM
Attachment installer_and_other_5.patch [ 14029 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 19/May/08 05:55 AM
passing to Eloy

Petr Skoda made changes - 19/May/08 05:55 AM
Assignee Petr Skoda [ skodak ] Eloy Lafuente (stronk7) [ stronk7 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 19/May/08 04:18 PM
fresh patch

Petr Skoda made changes - 19/May/08 04:18 PM
Attachment installer_and_other_6.patch [ 14031 ]
Eloy Lafuente (stronk7) committed 20 files to 'Moodle CVS' - 20/May/08 02:02 AM
Installer fixed, prefixes improved, moved conn settings to connect() and some more improvements. MDL-14864
MODIFY lib/dml/Attic/postgres7_adodb_moodle_database.php   Rev. 1.4    (+67 -14 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_database.php   Rev. 1.4    (+55 -10 lines)
MODIFY lib/dml/Attic/mysql_adodb_moodle_database.php   Rev. 1.3    (+21 -3 lines)
MODIFY lang/en_utf8/debug.php   Rev. 1.10    (+2 -2 lines)
MODIFY lib/setup.php   Rev. 1.234    (+2 -9 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.82    (+10 -1 lines)
MODIFY lib/dml/Attic/mssql_adodb_moodle_database.php   Rev. 1.6    (+39 -4 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_recordset.php   Rev. 1.2    (+1 -1 lines)
MODIFY lib/moodlelib.php   Rev. 1.1046    (+6 -3 lines)
MODIFY admin/index.php   Rev. 1.315    (+1 -10 lines)
MODIFY lib/dml/pdo_moodle_database.php   Rev. 1.2    (+5 -3 lines)
MODIFY lib/dml/Attic/odbc_mssql_adodb_moodle_database.php   Rev. 1.3    (+27 -3 lines)
MODIFY lib/dml/Attic/mysqli_adodb_moodle_database.php   Rev. 1.3    (+25 -4 lines)
MODIFY lib/dml/moodle_database.php   Rev. 1.2    (+71 -37 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.195    (+1 -1 lines)
MODIFY lib/dmllib.php   Rev. 1.148    (+35 -26 lines)
MODIFY lib/dml/Attic/mssql_n_adodb_moodle_database.php   Rev. 1.3    (+16 -4 lines)
MODIFY lib/weblib.php   Rev. 1.1074    (+49 -4 lines)
MODIFY install.php   Rev. 1.95    (+126 -212 lines)
MODIFY lib/dml/Attic/adodb_moodle_database.php   Rev. 1.3    (+56 -5 lines)
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 20/May/08 02:07 AM
Reviewed, tested under MySQL, PostgreSQL and MSSQL.

I only have:

  • moved some PHP docs from __construct() to connect()
  • added some TODO comments (plz, check them in commit message)

Resolving this as fixed. Thanks!


Eloy Lafuente (stronk7) made changes - 20/May/08 02:07 AM
Assignee Eloy Lafuente (stronk7) [ stronk7 ] Petr Skoda [ skodak ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
martignoni committed 3 files to 'Lang CVS' - 20/May/08 05:04 AM
MDL-14864 new strings translated
MODIFY fr_utf8/debug.php   Rev. 1.7    (+3 -3 lines)
MODIFY fr_utf8/admin.php   Rev. 1.252    (+2 -2 lines)
MODIFY fr_utf8/error.php   Rev. 1.88    (+5 -1 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 21/May/08 01:49 PM
Updated a translated string for admin based on lang/en_utf8 change MDL-14864.
Brushed up translated strings for debug.
Translated new strings for feedback.
MODIFY ja_utf8/feedback.php   Rev. 1.24    (+7 -1 lines)
MODIFY ja_utf8/debug.php   Rev. 1.8    (+4 -4 lines)
MODIFY ja_utf8/admin.php   Rev. 1.266    (+2 -2 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 13/Jun/08 10:45 PM
MDL-14864 Removed old $db variable, replaced by global $DB. This was breaking install on pgsql database.
MODIFY install.php   Rev. 1.98    (+3 -3 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators