[#MDL-14866] Fix deleted lang strings

Moodle

Fix deleted lang strings

Created: 16/May/08 03:39 PM Updated: 15/Oct/08 03:00 PM

Component/s:

Languages

Affects Version/s:

1.9.1

Fix Version/s:

1.9.4

Issue Links:

Relates

This issue has been marked as being related by:

MDLSITE-425 Check for any deleted lang strings

Participants:	Helen Foster, Koen Roggemans and Nicolas Martignoni
Security Level:	None

Description

« Hide

Eloy's comments from MDLSITE-425

Well, I've executed the comparison script with today's HEAD against 3 months ago HEAD and I've got these strings deleted since then:

< blog.php:addotags
< blog.php:addptags
< blog.php:otags
< blog.php:ptags
< countries.php:CS
< countries.php:FX
< countries.php:KO
< countries.php:TP
< countries.php:WA
< countries.php:ZR
< grades.php:aggregationcoefextrahelp
< grades.php:aggregationcoefweighthelp
< grades.php:configbulkcheckboxes
< grades.php:configquickfeedback
< grades.php:errornocategorizedid
< grades.php:overallavg
< moodle.php:nostatstodisplay
< userkey.php:keyiprestrictionhelp
< userkey.php:keyvaliduntilhelp

About these strings... we should test each one to see if they are used in old stable branches:

1) If they are used in stable branches... (say 3 latest branches 1.7, 1.8 and 1.9?) then we must reintroduce them ASAP.
2) If they aren't used, they they only have been in HEAD so, it's safe to keep them deleted, IMO.

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Helen Foster - 16/May/08 03:47 PM

VIP watchers added :-)

Latest deleted strings:

install.php:phpversionerror
error.php:errortoomanylogins

[ Permlink | « Hide ]

Nicolas Martignoni - 16/May/08 04:49 PM

The 'error.php:errortoomanylogins' string was added by Dongsheng, then deleted, since it is already present in moodle.php.

[ Permlink | « Hide ]

Nicolas Martignoni - 16/May/08 04:51 PM

Same thing for string "error.php:errorwhenconfirming".

(sorry for the new comment, it seems that I can't edit my comments).

[ Permlink | « Hide ]

Helen Foster - 16/May/08 04:58 PM

Thanks for the information Nicolas, I'm glad I added you as a VIP watcher! :-)

[ Permlink | « Hide ]

Helen Foster - 04/Jun/08 02:13 PM

Latest deleted string:

question.php:novirtualquestion

[ Permlink | « Hide ]

Koen Roggemans - 04/Jun/08 02:22 PM

That's ok, replaced by another one and not used in older Moodle versions. See ~~MDL-15068~~

[ Permlink | « Hide ]

Helen Foster - 04/Jun/08 02:49 PM

Thanks Koen, I'm glad I added you as a VIP watcher! :-)

[ Permlink | « Hide ]

Helen Foster - 17/Jun/08 10:55 PM

Latest deleted strings:

quiz_statistics.php:statsforallattempts
quiz_statistics.php:statsforfirstattempts

[ Permlink | « Hide ]

Helen Foster - 19/Jun/08 03:45 PM

error.php:cannotmovezip

[ Permlink | « Hide ]

Koen Roggemans - 19/Jun/08 04:41 PM

the quiz-things are back in

[ Permlink | « Hide ]

Helen Foster - 23/Jun/08 03:21 PM

Thanks Koen.

Latest deleted string:

feedback.php:publish_stats_on_students

[ Permlink | « Hide ]

Helen Foster - 26/Jun/08 05:11 PM

block_glossary_random.php:typehelp
data.php:invaliddata

[ Permlink | « Hide ]

Helen Foster - 01/Jul/08 04:30 PM

tag.php:thingstaggedwith

[ Permlink | « Hide ]

Helen Foster - 12/Jul/08 09:32 PM

quiz.php:blackboard_6
quiz.php:qti2

[ Permlink | « Hide ]

Helen Foster - 16/Jul/08 01:22 PM

quiz.php:reviewnotallowed

[ Permlink | « Hide ]

Nicolas Martignoni - 16/Jul/08 07:06 PM

tag.php:thingstaggedwith and quiz.php:qti2 must not be deleted from non english lang packs (in HEAD), as they are needed on 1.9.x.

[ Permlink | « Hide ]

Helen Foster - 23/Jul/08 09:23 PM

Nicolas, thanks for your comment.

Latest deleted strings:

admin.php:enableallowedip
admin.php:enableallowedipdesc
admin.php:ipinblockedlist
admin.php:ipoutallowedlist

[ Permlink | « Hide ]

Helen Foster - 25/Jul/08 02:31 PM

quiz_statistics.php:noofallattempts
quiz_statistics.php:nooffirstattempts

[ Permlink | « Hide ]

Helen Foster - 07/Aug/08 03:29 PM

admin.php:repsettings
admin.php:repsettingsgeneral
moodle.php:repositories
moodle.php:repositoriesmanage

[ Permlink | « Hide ]

Helen Foster - 09/Aug/08 05:21 PM

error.php:localfilecannotcreatefiledirs
error.php:localfilecannotread
error.php:localfilenotcreated
error.php:localfileproblem

[ Permlink | « Hide ]

Helen Foster - 14/Oct/08 10:29 PM

Not sure whether the following strings were only deleted from head, but noting them here just in case:

17/08/08

data.php:cannotinsertrate
data.php:cannotupdaterate
debug.php:prefixcannotbeempty
debug.php:prefixlimit
debug.php:withoutversion
error.php:cannotinitpage
forum.php:cannotinsertrate
forum.php:cannotupdaterate

30/08/08

message.php:general_config