Moodle

Fix deleted lang strings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.1
  • Fix Version/s: None
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Eloy's comments from MDLSITE-425

Well, I've executed the comparison script with today's HEAD against 3 months ago HEAD and I've got these strings deleted since then:

< blog.php:addotags
< blog.php:addptags
< blog.php:otags
< blog.php:ptags
< countries.php:CS
< countries.php:FX
< countries.php:KO
< countries.php:TP
< countries.php:WA
< countries.php:ZR
< grades.php:aggregationcoefextrahelp
< grades.php:aggregationcoefweighthelp
< grades.php:configbulkcheckboxes
< grades.php:configquickfeedback
< grades.php:errornocategorizedid
< grades.php:overallavg
< moodle.php:nostatstodisplay
< userkey.php:keyiprestrictionhelp
< userkey.php:keyvaliduntilhelp

About these strings... we should test each one to see if they are used in old stable branches:

1) If they are used in stable branches... (say 3 latest branches 1.7, 1.8 and 1.9?) then we must reintroduce them ASAP.
2) If they aren't used, they they only have been in HEAD so, it's safe to keep them deleted, IMO.

Issue Links

This issue has been marked as being related by:
MDLSITE-425 Check for any deleted lang strings Minor Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Helen Foster added a comment -

VIP watchers added

Latest deleted strings:

install.php:phpversionerror
error.php:errortoomanylogins

Show
Helen Foster added a comment - VIP watchers added Latest deleted strings: install.php:phpversionerror error.php:errortoomanylogins
Hide
Permalink
Nicolas Martignoni added a comment -

The 'error.php:errortoomanylogins' string was added by Dongsheng, then deleted, since it is already present in moodle.php.

Show
Nicolas Martignoni added a comment - The 'error.php:errortoomanylogins' string was added by Dongsheng, then deleted, since it is already present in moodle.php.
Hide
Permalink
Nicolas Martignoni added a comment -

Same thing for string "error.php:errorwhenconfirming".

(sorry for the new comment, it seems that I can't edit my comments).

Show
Nicolas Martignoni added a comment - Same thing for string "error.php:errorwhenconfirming". (sorry for the new comment, it seems that I can't edit my comments).
Hide
Permalink
Helen Foster added a comment -

Thanks for the information Nicolas, I'm glad I added you as a VIP watcher!

Show
Helen Foster added a comment - Thanks for the information Nicolas, I'm glad I added you as a VIP watcher!
Hide
Permalink
Helen Foster added a comment -

Latest deleted string:

question.php:novirtualquestion

Show
Helen Foster added a comment - Latest deleted string: question.php:novirtualquestion
Hide
Permalink
Koen Roggemans added a comment -

That's ok, replaced by another one and not used in older Moodle versions. See MDL-15068

Show
Koen Roggemans added a comment - That's ok, replaced by another one and not used in older Moodle versions. See MDL-15068
Hide
Permalink
Helen Foster added a comment -

Thanks Koen, I'm glad I added you as a VIP watcher!

Show
Helen Foster added a comment - Thanks Koen, I'm glad I added you as a VIP watcher!
Hide
Permalink
Helen Foster added a comment -

Latest deleted strings:

quiz_statistics.php:statsforallattempts
quiz_statistics.php:statsforfirstattempts

Show
Helen Foster added a comment - Latest deleted strings: quiz_statistics.php:statsforallattempts quiz_statistics.php:statsforfirstattempts
Hide
Permalink
Helen Foster added a comment -

error.php:cannotmovezip

Show
Helen Foster added a comment - error.php:cannotmovezip
Hide
Permalink
Koen Roggemans added a comment -

the quiz-things are back in

Show
Koen Roggemans added a comment - the quiz-things are back in
Hide
Permalink
Helen Foster added a comment -

Thanks Koen.

Latest deleted string:

feedback.php:publish_stats_on_students

Show
Helen Foster added a comment - Thanks Koen. Latest deleted string: feedback.php:publish_stats_on_students
Hide
Permalink
Helen Foster added a comment -

block_glossary_random.php:typehelp
data.php:invaliddata

Show
Helen Foster added a comment - block_glossary_random.php:typehelp data.php:invaliddata
Hide
Permalink
Helen Foster added a comment -

tag.php:thingstaggedwith

Show
Helen Foster added a comment - tag.php:thingstaggedwith
Hide
Permalink
Helen Foster added a comment -

quiz.php:blackboard_6
quiz.php:qti2

Show
Helen Foster added a comment - quiz.php:blackboard_6 quiz.php:qti2
Hide
Permalink
Helen Foster added a comment -

quiz.php:reviewnotallowed

Show
Helen Foster added a comment - quiz.php:reviewnotallowed
Hide
Permalink
Nicolas Martignoni added a comment -

tag.php:thingstaggedwith and quiz.php:qti2 must not be deleted from non english lang packs (in HEAD), as they are needed on 1.9.x.

Show
Nicolas Martignoni added a comment - tag.php:thingstaggedwith and quiz.php:qti2 must not be deleted from non english lang packs (in HEAD), as they are needed on 1.9.x.
Hide
Permalink
Helen Foster added a comment -

Nicolas, thanks for your comment.

Latest deleted strings:

admin.php:enableallowedip
admin.php:enableallowedipdesc
admin.php:ipinblockedlist
admin.php:ipoutallowedlist

Show
Helen Foster added a comment - Nicolas, thanks for your comment. Latest deleted strings: admin.php:enableallowedip admin.php:enableallowedipdesc admin.php:ipinblockedlist admin.php:ipoutallowedlist
Hide
Permalink
Helen Foster added a comment -

quiz_statistics.php:noofallattempts
quiz_statistics.php:nooffirstattempts

Show
Helen Foster added a comment - quiz_statistics.php:noofallattempts quiz_statistics.php:nooffirstattempts
Hide
Permalink
Helen Foster added a comment -

admin.php:repsettings
admin.php:repsettingsgeneral
moodle.php:repositories
moodle.php:repositoriesmanage

Show
Helen Foster added a comment - admin.php:repsettings admin.php:repsettingsgeneral moodle.php:repositories moodle.php:repositoriesmanage
Hide
Permalink
Helen Foster added a comment -

error.php:localfilecannotcreatefiledirs
error.php:localfilecannotread
error.php:localfilenotcreated
error.php:localfileproblem

Show
Helen Foster added a comment - error.php:localfilecannotcreatefiledirs error.php:localfilecannotread error.php:localfilenotcreated error.php:localfileproblem
Hide
Permalink
Helen Foster added a comment -

Not sure whether the following strings were only deleted from head, but noting them here just in case:

17/08/08

data.php:cannotinsertrate
data.php:cannotupdaterate
debug.php:prefixcannotbeempty
debug.php:prefixlimit
debug.php:withoutversion
error.php:cannotinitpage
forum.php:cannotinsertrate
forum.php:cannotupdaterate

30/08/08

message.php:general_config

Show
Helen Foster added a comment - Not sure whether the following strings were only deleted from head, but noting them here just in case: 17/08/08 data.php:cannotinsertrate data.php:cannotupdaterate debug.php:prefixcannotbeempty debug.php:prefixlimit debug.php:withoutversion error.php:cannotinitpage forum.php:cannotinsertrate forum.php:cannotupdaterate 30/08/08 message.php:general_config
Hide
Permalink
Nicolas Martignoni added a comment -

Latest deleted strings:

glossary.php:cantinsertent
glossary.php:cantupdateglossary

Show
Nicolas Martignoni added a comment - Latest deleted strings: glossary.php:cantinsertent glossary.php:cantupdateglossary
Hide
Permalink
Helen Foster added a comment -

Apologies for keeping postponing this issue. I receive regular email notification of any deleted strings which ensure I never forget this issue

Show
Helen Foster added a comment - Apologies for keeping postponing this issue. I receive regular email notification of any deleted strings which ensure I never forget this issue
Hide
Permalink
Helen Foster added a comment -

Finally got around to closing this issue! Thanks for everyone's help.

Show
Helen Foster added a comment - Finally got around to closing this issue! Thanks for everyone's help.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.