Issue Details (XML | Word | Printable)

Key: MDL-14877
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

prefix check shouldn't be perfomed by moodle_database classes

Created: 17/May/08 06:55 AM   Updated: 22/May/08 08:27 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
Resolved date: 22/May/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Right now prefix rules are executed by the xxx_yyy_moodle_database constructor.

That causes 2 problems:

1) force ALL db to fulfil the rules (not only Moodle DB, but auth/enrol....)
2) print_error() output is 100% broken, because a lot of stuff hasn't been defined (lang, themes....)

IMO those checks should continue where they are now (admin/index.php), simply preventing any Moodle installation, but not making the dml/ddl stuff dependent of that.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 18/May/08 04:46 AM
Revert the prefix check to admin/index.php. MDL-14877
MODIFY admin/index.php   Rev. 1.314    (+10 -1 lines)
Eloy Lafuente (stronk7) committed 3 files to 'Moodle CVS' - 18/May/08 04:51 AM
non empty prefixes aren't a driver limitation, but a Moodle one. MDL-14877
MODIFY lib/dml/Attic/postgres7_adodb_moodle_database.php   Rev. 1.3    (+1 -4 lines)
MODIFY lib/dml/Attic/mssql_adodb_moodle_database.php   Rev. 1.3    (+1 -5 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_database.php   Rev. 1.3    (+1 -8 lines)