|
|
| Participants: |
Eloy Lafuente (stronk7)
|
| Security Level: |
None
|
| Resolved date: |
18/May/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
Was implementing the MSSQL when I discovered that:
- inserting records using placeholders AND
- retrieving the last id with Insert_ID()
are completely broken!!
Explanation from: http://docs.moodle.org/en/Development:dmllib_2.0_problems
Problem: Queries using placeholders under MSSQL are executed by one sp_executesql() procedure call. In MSSQL procedures, triggers are executed into new scopes (like "shells"), so the Insert_ID() function (internally usind SCOPE_IDENTITY()) doesn't work at all, because the insert has been executed in another scope.
Solution: Patch ADOdb driver so, each time one INSERT is going to be executed by sp_executesql(), we'll add one SCOPE_IDENTITY() in the same procedure execution (that way, both the insert and the identity will be in the same scope). Once executed, return the value of the identity by the standard Insert_ID() function. BC compatible 100% with current code if implemented that way.
|
|
Description
|
Was implementing the MSSQL when I discovered that:
- inserting records using placeholders AND
- retrieving the last id with Insert_ID()
are completely broken!!
Explanation from: http://docs.moodle.org/en/Development:dmllib_2.0_problems
Problem: Queries using placeholders under MSSQL are executed by one sp_executesql() procedure call. In MSSQL procedures, triggers are executed into new scopes (like "shells"), so the Insert_ID() function (internally usind SCOPE_IDENTITY()) doesn't work at all, because the insert has been executed in another scope.
Solution: Patch ADOdb driver so, each time one INSERT is going to be executed by sp_executesql(), we'll add one SCOPE_IDENTITY() in the same procedure execution (that way, both the insert and the identity will be in the same scope). Once executed, return the value of the identity by the standard Insert_ID() function. BC compatible 100% with current code if implemented that way. |
Show » |
committed 1 file to 'Moodle CVS' - 18/May/08 09:06 AM
Fix MSSQL Insert_ID() to work when inserting using placeholders. MDL-14886
|
|
|
committed 1 file to 'Moodle CVS' - 18/May/08 09:11 AM
Document local change in drivers/adodb-mssql.inc.php. MDL-14886
|
|
|
made changes - 18/May/08 09:22 AM
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Sub-task
Resolved
Blocker
searching the web... I've found one guy that, some time ago proposed one patch to fix this for one old release of ADOdb... going to apply and test.
Reference: http://phplens.com/lens/lensforum/msgs.php?id=17068&x=1
Ciao