History | Log In     View a printable version of the current page.  
We are currently focused especially on Moodle 2.0, Moodle 1.9.x bugs and Moodle 1.9.x testing.    Confused? Lost? Please read this introduction to the Tracker.
Issue Details (XML | Word | Printable)

Key: MDL-14897
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Moodle
MDL-14679

Make generators stuff reentrant

Created: 19/May/08 09:13 AM   Updated: 25/May/08 10:43 AM
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7)
Security Level: None


 Description  « Hide
Before Moodle 2.0 generator classes are instantiated per DDL statement. But under 2.0 they only are instantiated once per request (no matter if they perform N DDL statements).

Currently, there are some code dependent of the old behaviour that fails under the new one (by changing some generator properties at execution time, my fault).

generator classes must guarantee same results independently of the number of DDL statements processed by one instance of them. Going to change those dynamically (wrongly) modified attributes by proper parameters in function calls and so.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) - 19/May/08 11:07 AM
Done. Now they run without problems any number of statements. Modifications on properties have been changed to new function parameters.

Resolving as fixed. Ciao :-)

MySQL, PG and MSSQ installing and passing XMLDB DDL tests. In 2 days, Oracle. B-)

Eloy Lafuente (stronk7) - 25/May/08 10:43 AM
Required changes applied to Oracle too. Runs multiple DDL statements without problem. Ciao :-)