Moodle

Make generators stuff reentrant

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Before Moodle 2.0 generator classes are instantiated per DDL statement. But under 2.0 they only are instantiated once per request (no matter if they perform N DDL statements).

Currently, there are some code dependent of the old behaviour that fails under the new one (by changing some generator properties at execution time, my fault).

generator classes must guarantee same results independently of the number of DDL statements processed by one instance of them. Going to change those dynamically (wrongly) modified attributes by proper parameters in function calls and so.

Ciao

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Done. Now they run without problems any number of statements. Modifications on properties have been changed to new function parameters.

Resolving as fixed. Ciao

MySQL, PG and MSSQ installing and passing XMLDB DDL tests. In 2 days, Oracle. B-)

Show
Eloy Lafuente (stronk7) added a comment - Done. Now they run without problems any number of statements. Modifications on properties have been changed to new function parameters. Resolving as fixed. Ciao MySQL, PG and MSSQ installing and passing XMLDB DDL tests. In 2 days, Oracle. B-)
Hide
Eloy Lafuente (stronk7) added a comment -

Required changes applied to Oracle too. Runs multiple DDL statements without problem. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Required changes applied to Oracle too. Runs multiple DDL statements without problem. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: