Issue Details (XML | Word | Printable)

Key: MDL-14897
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

Make generators stuff reentrant

Created: 19/May/08 09:13 AM   Updated: 25/May/08 10:43 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7)
Security Level: None
Resolved date: 19/May/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Before Moodle 2.0 generator classes are instantiated per DDL statement. But under 2.0 they only are instantiated once per request (no matter if they perform N DDL statements).

Currently, there are some code dependent of the old behaviour that fails under the new one (by changing some generator properties at execution time, my fault).

generator classes must guarantee same results independently of the number of DDL statements processed by one instance of them. Going to change those dynamically (wrongly) modified attributes by proper parameters in function calls and so.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) made changes - 19/May/08 11:07 AM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Eloy Lafuente (stronk7) made changes - 19/May/08 11:29 AM
Description Before Moodle 2.0 generator classes are instantiated per DML statement. But under 2.0 they only are instantiated once per request (no matter if they perform N DML statements).

Currently, there are some code dependent of the old behaviour that fails under the new one (by changing some generator properties at execution time, my fault).

generator classes must guarantee same results independently of the number of DML statements processed by one instance of them. Going to change those dynamically (wrongly) modified attributes by proper parameters in function calls and so.

Ciao :-)
Before Moodle 2.0 generator classes are instantiated per DDL statement. But under 2.0 they only are instantiated once per request (no matter if they perform N DDL statements).

Currently, there are some code dependent of the old behaviour that fails under the new one (by changing some generator properties at execution time, my fault).

generator classes must guarantee same results independently of the number of DDL statements processed by one instance of them. Going to change those dynamically (wrongly) modified attributes by proper parameters in function calls and so.

Ciao :-)