Moodle

New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Could we add an extra capability that allows read-only access. Basically so that some one could view the results of quizzes they've taken on a course but not take any new ones or modify anything

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

That is, we should split the existing mod/quiz:attempt capability. mod/quiz:attempt should only control a user's ability to start new attempts, and we should add a mod/quiz:viewmypastattempts capability.

Show
Tim Hunt added a comment - That is, we should split the existing mod/quiz:attempt capability. mod/quiz:attempt should only control a user's ability to start new attempts, and we should add a mod/quiz:viewmypastattempts capability.
Hide
Permalink
Tim Hunt added a comment -

Colin, does the OU need this for 1.9.x?

Show
Tim Hunt added a comment - Colin, does the OU need this for 1.9.x?
Hide
Permalink
Colin Chambers added a comment -

yes

Show
Colin Chambers added a comment - yes
Hide
Permalink
Tim Hunt added a comment -

See http://moodle.org/mod/forum/discuss.php?d=112423.

Show
Tim Hunt added a comment - See http://moodle.org/mod/forum/discuss.php?d=112423.
Hide
Permalink
Tim Hunt added a comment -

I think this patch (separatereviewcap.patch.txt) does the business in Moodle 1.9, but I have only tested it a bit, am about to go on holiday for 4 days, so I will not commit it until later.

In the mean time, testing and code review welcome.

Note that merging the 2.0 is not straightforwards, because I have refactored lots of stuff in HEAD. however, it should be easier to implement there.

Show
Tim Hunt added a comment - I think this patch (separatereviewcap.patch.txt) does the business in Moodle 1.9, but I have only tested it a bit, am about to go on holiday for 4 days, so I will not commit it until later. In the mean time, testing and code review welcome. Note that merging the 2.0 is not straightforwards, because I have refactored lots of stuff in HEAD. however, it should be easier to implement there.
Hide
Permalink
Tim Hunt added a comment -

Done. Please test.

Show
Tim Hunt added a comment - Done. Please test.
Hide
Permalink
Helen Foster added a comment -

Hi Tim,

I've tried testing your new capability by editing the role of student and not setting mod/quiz:attempt, then logging in as a student and attempting to view old quiz attempts. I found that I could view the summary of previous attempts but not my responses. Is this how the capability is supposed to work?

Show
Helen Foster added a comment - Hi Tim, I've tried testing your new capability by editing the role of student and not setting mod/quiz:attempt, then logging in as a student and attempting to view old quiz attempts. I found that I could view the summary of previous attempts but not my responses. Is this how the capability is supposed to work?
Hide
Permalink
Tim Hunt added a comment -

No, it sounds like a bug. I guess I just tested all the standard roles, to make sure that I had not broken anything, and obviously I tried to think logically about what I was doing when I implemented this, but I never acutally tested the unusual combinations of capabilities.

Since this is a feature request, to implement the new feature, and that is basically done, can we leave this one closed, and can you file a new bug about the fact it does not work. Thanks.

Show
Tim Hunt added a comment - No, it sounds like a bug. I guess I just tested all the standard roles, to make sure that I had not broken anything, and obviously I tried to think logically about what I was doing when I implemented this, but I never acutally tested the unusual combinations of capabilities. Since this is a feature request, to implement the new feature, and that is basically done, can we leave this one closed, and can you file a new bug about the fact it does not work. Thanks.
Hide
Permalink
Tim Hunt added a comment -

Helen, it seems to be working for me.

The UI in Moodle 1.9 is not great, the way you review an attempt is to click on the grade. In Moodle 2.0 it is better, you get an explicit review link by each attempt.

If you had an open attempt that you never finished, there is no way to review that. I can live with that for now.

So, having just re-tested, everything seems to be working for me. If you are still having problems, please create a new bug with detailed steps to reproduce, actual behaviour and expected behaviour, etc.

Show
Tim Hunt added a comment - Helen, it seems to be working for me. The UI in Moodle 1.9 is not great, the way you review an attempt is to click on the grade. In Moodle 2.0 it is better, you get an explicit review link by each attempt. If you had an open attempt that you never finished, there is no way to review that. I can live with that for now. So, having just re-tested, everything seems to be working for me. If you are still having problems, please create a new bug with detailed steps to reproduce, actual behaviour and expected behaviour, etc.
Hide
Permalink
Helen Foster added a comment -

Sorry Tim, my mistake. When I tested previously I forgot to set appropriate review options.

Thanks for adding this new capability.

http://docs.moodle.org/en/Capabilities/mod/quiz:reviewmyattempts

Show
Helen Foster added a comment - Sorry Tim, my mistake. When I tested previously I forgot to set appropriate review options. Thanks for adding this new capability. http://docs.moodle.org/en/Capabilities/mod/quiz:reviewmyattempts

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.