Issue Details (XML | Word | Printable)

Key: MDL-14949
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Dongsheng Cai
Reporter: Howard Miller
Votes: 0
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

mod/chat:readlog doesn't work on it's own

Created: 22/May/08 06:51 PM   Updated: 11/Mar/09 11:35 AM
Return to search
Component/s: Chat
Affects Version/s: 1.9.1
Fix Version/s: 1.9.5, 2.0

Participants: Dongsheng Cai, Helen Foster, Howard Miller, Jonathan Moore and Petr Skoda
Security Level: None
QA Assignee: Helen Foster
Resolved date: 11/Mar/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
You don't appear to only be able to read chat logs. The mod/chat:chat capability is a dependency because the readlog option is on the chat page. This isn't clear if it's a 'feature'.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dongsheng Cai made changes - 17/Jun/08 04:31 PM
Field Original Value New Value
Assignee Nobody [ nobody ] Dongsheng Cai [ dongsheng ]
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 18/Jun/08 10:00 AM
You are able to assign mod/chat or mod/chatlogs capabilities to users, if you are going to stop user's chatting and allow them view the past chat session, you should override permissions in course setting. Am I misunderstanding you?

[ Permalink | « Hide ]
Howard Miller added a comment - 18/Jun/08 04:13 PM
Sure you can set the capability, but you can't have just chatlogs. The button is on the chat page, which you only see if 'chat' capability is enabled.

A very minor point, but we wanted to set up a 'view only' user and it turns out that this is not possible for chat.


Dongsheng Cai committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 16/Dec/08 01:54 PM
"MDL-14949, add a new capability chat:talk"
MODIFY lang/en_utf8/chat.php   Rev. 1.5.8.6    (+3 -2 lines)
MODIFY mod/chat/version.php   Rev. 1.26.2.2    (+2 -2 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.19.4.5    (+20 -1 lines)
MODIFY mod/chat/db/access.php   Rev. 1.7.2.1    (+14 -0 lines)
MODIFY mod/chat/gui_header_js/index.php   Rev. 1.27.2.1    (+2 -2 lines)
Dongsheng Cai committed 5 files to 'Moodle CVS' - 16/Dec/08 01:58 PM
"MDL-14949, add a new capablity chat:talk to enable readonly chat user, merged from 1.9"
MODIFY mod/chat/db/access.php   Rev. 1.9    (+14 -0 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.28    (+19 -0 lines)
MODIFY lang/en_utf8/chat.php   Rev. 1.15    (+3 -2 lines)
MODIFY mod/chat/gui_header_js/index.php   Rev. 1.33    (+2 -2 lines)
MODIFY mod/chat/version.php   Rev. 1.31    (+2 -2 lines)
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 16/Dec/08 02:03 PM
introduce a new capability "chat:talk" if override this capability to false, the input box will be hide, the user cannot talk in the chat room

Dongsheng Cai made changes - 16/Dec/08 02:03 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 17/Dec/08 12:45 AM
MDL-14949 Translated new strings for chat.
MDL-17667 Translated new strings for xmldb.
MODIFY ja_utf8/chat.php   Rev. 1.30    (+3 -2 lines)
MODIFY ja_utf8/xmldb.php   Rev. 1.23    (+4 -2 lines)
MODIFY ja_utf8/README   Rev. 1.895    (+1 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 23/Dec/08 05:21 AM
MDL-14949, new string for capability
MODIFY fr_utf8/chat.php   Rev. 1.19    (+4 -3 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 31/Dec/08 01:10 AM
I can not find any use of mod/chat:talk, why was it added? Why does it not have clonepermissionfrom (required when adding caps into STABLE)?

Petr Skoda made changes - 31/Dec/08 01:10 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Dongsheng Cai made changes - 12/Jan/09 04:39 PM
Status Reopened [ 4 ] In Progress [ 3 ]
Dongsheng Cai made changes - 12/Jan/09 04:39 PM
Priority Minor [ 4 ] Major [ 3 ]
Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 14/Jan/09 01:35 PM
"MDL-14949, reverse changes to permission which can cause problems"
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.19.4.6    (+1 -5 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 14/Jan/09 01:36 PM
"MDL-14949, reverse changes to permission which can cause problems, merged from 1.9"
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.30    (+1 -5 lines)
Petr Skoda made changes - 22/Jan/09 12:40 AM
Fix Version/s 1.9.5 [ 10320 ]
[ Permalink | « Hide ]
Jonathan Moore added a comment - 27/Jan/09 05:47 AM
It seems like bad policy to enable capabilities in stable before they do anything. I just spent about 30 minutes trying to figure out why this doesn't do anything in my latest stable download. In my version which I just synced against stable, removing the mod/chat:talk doesn't prevent the user from entering text into the chat.

[ Permalink | « Hide ]
Helen Foster added a comment - 10/Mar/09 07:12 PM
Forum discussion about the new capability mod/chat:talk:
http://moodle.org/mod/forum/discuss.php?d=118376

Any progress on this issue?


[ Permalink | « Hide ]
Dongsheng Cai added a comment - 11/Mar/09 11:18 AM
It is actaully wrong to introduce this capability, sorry, I will remove it and comit a new fix.

Dongsheng Cai committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 11/Mar/09 11:21 AM
"CHAT/MDL-14949, remove mod/chat:talk capability and check chat and readlog capabilities respectively"
MODIFY mod/chat/db/access.php   Rev. 1.7.2.2    (+0 -14 lines)
MODIFY mod/chat/view.php   Rev. 1.61.2.6    (+30 -26 lines)
MODIFY lang/en_utf8/chat.php   Rev. 1.5.8.7    (+2 -1 lines)
MODIFY mod/chat/version.php   Rev. 1.26.2.3    (+2 -2 lines)
Dongsheng Cai committed 4 files to 'Moodle CVS' - 11/Mar/09 11:34 AM
"CHAT/MDL-14949, remove mod/chat:talk capability and check chat and readlog capabilities respectively, merged and modified from 1.9"
MODIFY mod/chat/view.php   Rev. 1.77    (+33 -30 lines)
MODIFY mod/chat/db/access.php   Rev. 1.10    (+0 -14 lines)
MODIFY lang/en_utf8/chat.php   Rev. 1.16    (+1 -0 lines)
MODIFY mod/chat/version.php   Rev. 1.33    (+2 -2 lines)
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 11/Mar/09 11:35 AM
Fixed, please review.

Dongsheng Cai made changes - 11/Mar/09 11:35 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s 2.0 [ 10122 ]
QA Assignee tsala
Resolution Fixed [ 1 ]
martignoni committed 1 file to 'Lang CVS' - 14/Mar/09 10:11 PM
MDL-14949, new string
MODIFY fr_utf8/chat.php   Rev. 1.21    (+2 -1 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 15/Mar/09 05:34 PM
MDL-14949 Translated a new string for chat.
MDL-18518 Translated a new string for user firstaccess.
MDL-18535 Translated new strings for database.
MDL-18500 Translated a new string for formslib element.
MDL-18468 Translated a new string for restore preprocessing (split).
MDL-18468 Adding translated strings for admin experimental option to enable split on restore.
MODIFY ja_utf8/README   Rev. 1.958    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.345    (+3 -1 lines)
MODIFY ja_utf8/data.php   Rev. 1.102    (+3 -1 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.351    (+4 -1 lines)
MODIFY ja_utf8/chat.php   Rev. 1.31    (+2 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators