[#MDL-14955] M2: Modify XMLDB Editor to suggest creation conditional code

Moodle

MDL-14679

M2: Modify XMLDB Editor to suggest creation conditional code

Created: 22/May/08 11:44 PM Updated: 26/May/08 08:49 AM

Component/s:

Database SQL/XMLDB

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Eloy Lafuente (stronk7)
Security Level:	None

Description

« Hide

Modify the suggested code by XMLDB editor to make all the creation functions (create_table, create_index...) to be executed within one:

if (!table_exists...)

block.

Right now, create_table() itself checks this, returning true and we are going to change this to return false. So conditions will be necessary (or exception handling).

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Eloy Lafuente (stronk7) - 24/May/08 06:28 AM

Hi,

I've added conditions to create/drop table/field/index in the PHP generated by the Editor.

Uhm... I'm not 100% sure this is the best behaviour... should all the rest of manager functions be executed within those conditions too? Makes things ugly...

Anyway, plz, take a look to current code, and feel free to comment... ciao :-)

[ Permlink | « Hide ]

Eloy Lafuente (stronk7) - 26/May/08 08:49 AM

I'm closing this as resolved, as commented. All create and drop operations are "protected" with exists check in PHP suggested code.

Feel free to reopen if necessary.

Ciao :-)