|
|
| Participants: |
Eloy Lafuente (stronk7)
|
| Security Level: |
None
|
| Resolved date: |
26/May/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
|
Modify the suggested code by XMLDB editor to make all the creation functions (create_table, create_index...) to be executed within one:
if (!table_exists...)
block.
Right now, create_table() itself checks this, returning true and we are going to change this to return false. So conditions will be necessary (or exception handling).
|
|
Description
|
Modify the suggested code by XMLDB editor to make all the creation functions (create_table, create_index...) to be executed within one:
if (!table_exists...)
block.
Right now, create_table() itself checks this, returning true and we are going to change this to return false. So conditions will be necessary (or exception handling). |
Show » |
made changes - 24/May/08 06:02 AM
| Field |
Original Value |
New Value |
|
Status
|
Open
[ 1
]
|
In Progress
[ 3
]
|
committed 1 file to 'Moodle CVS' - 24/May/08 06:24 AM
Conditionally execute create/drop table dbmanager functions. MDL-14955
|
|
|
committed 1 file to 'Moodle CVS' - 24/May/08 06:26 AM
And also conditionally create/drop indexes and fields. MDL-14955
|
|
|
made changes - 26/May/08 08:49 AM
|
Status
|
In Progress
[ 3
]
|
Resolved
[ 5
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Sub-task
Resolved
Major
I've added conditions to create/drop table/field/index in the PHP generated by the Editor.
Uhm... I'm not 100% sure this is the best behaviour... should all the rest of manager functions be executed within those conditions too? Makes things ugly...
Anyway, plz, take a look to current code, and feel free to comment... ciao