[#MDL-14965] Moodle fresh install fails with error on admin/index.php 532, in PHP 5

Issue Details (XML | Word | Printable)

Key:	MDL-14965
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Sam Marshall
Reporter:	Sam Marshall
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Moodle fresh install fails with error on admin/index.php 532, in PHP 5

Created: 23/May/08 06:27 PM Updated: 27/May/08 11:19 PM

Return to search

Component/s:

General

Affects Version/s:

1.9.2

Fix Version/s:

1.9.2

Database:	Any
Participants:	Petr Skoda and Sam Marshall
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	23/May/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Error is because blocks_execute_action second parameter is a reference one, but this line of code tries to call it with the result of a function - can't do that, it has to be a variable.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Sam Marshall added a comment - 23/May/08 06:37 PM

I checked in a fix to MOODLE_19+MOODLE_19_MERGED,HEAD. The fix is the obvious one (assign the function call return to a variable, pass that to the function that complained).

In addition to the line mentioned there was another bug (same bug different function) in accesslib. I fixed it the same way.

I have now been able to install my MOODLE_19! (php 5.2, mysql).

[ Permalink | « Hide ]

Sam Marshall added a comment - 23/May/08 07:03 PM

Within this same area (pass-by-reference with something that isn't a reference causing php5 failures) I found another bug in lib/form/format.php, which prevented you from making a forum post., possibly among other things. (The error occurred when you click 'Add new post', before actually making it.) I checked the same fix in there.

[ Permalink | « Hide ]

Petr Skoda added a comment - 27/May/08 11:19 PM

thanks

All content on this web site is made available under the GNU General Public License, unless otherwise stated.