Moodle

Moodle fresh install fails with error on admin/index.php 532, in PHP 5

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.2
  • Component/s: General
  • Labels:
    None
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Error is because blocks_execute_action second parameter is a reference one, but this line of code tries to call it with the result of a function - can't do that, it has to be a variable.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Marshall added a comment -

I checked in a fix to MOODLE_19+MOODLE_19_MERGED,HEAD. The fix is the obvious one (assign the function call return to a variable, pass that to the function that complained).

In addition to the line mentioned there was another bug (same bug different function) in accesslib. I fixed it the same way.

I have now been able to install my MOODLE_19! (php 5.2, mysql).

Show
Sam Marshall added a comment - I checked in a fix to MOODLE_19+MOODLE_19_MERGED,HEAD. The fix is the obvious one (assign the function call return to a variable, pass that to the function that complained). In addition to the line mentioned there was another bug (same bug different function) in accesslib. I fixed it the same way. I have now been able to install my MOODLE_19! (php 5.2, mysql).
Hide
Permalink
Sam Marshall added a comment -

Within this same area (pass-by-reference with something that isn't a reference causing php5 failures) I found another bug in lib/form/format.php, which prevented you from making a forum post., possibly among other things. (The error occurred when you click 'Add new post', before actually making it.) I checked the same fix in there.

Show
Sam Marshall added a comment - Within this same area (pass-by-reference with something that isn't a reference causing php5 failures) I found another bug in lib/form/format.php, which prevented you from making a forum post., possibly among other things. (The error occurred when you click 'Add new post', before actually making it.) I checked the same fix in there.
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks

Show
Petr Škoda (skodak) added a comment - thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.