Issue Details (XML | Word | Printable)

Key: MDL-14967
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Skoda
Reporter: Nicolas Connault
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

M2-M3-M4 Upgrade all code using DML

Created: 23/May/08 10:51 PM   Updated: 15/Jun/08 06:13 PM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Cloners
 

Participants: Nicolas Connault and Petr Skoda
Security Level: None
Resolved date: 15/Jun/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Since the new DML 2.0 API is now in place, all code using the old dmllib needs to be upgraded. In essence, this means the following changes:

1. Wherever old functions are used (get_record*, get_field*, set_field, insert_record, update_record), the global $DB must be used as the object on which these functions are called (e.g. get_record_select becomes $DB->get_record_select).
2. All the functions that used to accept a list of string params in the form "param1, value1, param2, value2" now need to be given an array of key=>value pairs as a replacement for these params. Other params remain as before. Check the new API for any exceptions.
3. rs_fetch_next_record($rs) is deprecated, in favour of the simple foreach($rs as $var). Calls to rs_close() must be replaced by $rs->close();

As an example to #3, if you have the original code:

     while($result = rs_fetch_next_record($rs)) {
         ...
     }
     rs_close();

you would replace it with

     foreach ($rs as $result) {
          ....
     }
     $rs->close();

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault committed 12 files to 'Moodle CVS' - 23/May/08 10:52 PM
Petr Skoda added a comment - 23/May/08 11:10 PM
todo:
1/ remove addslashes
2/ use placeholders in SQL
3/ fix function parameters, each $sql part needs $params array

Nicolas Connault made changes - 24/May/08 04:17 AM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Nicolas Connault committed 7 files to 'Moodle CVS' - 26/May/08 01:06 PM
Nicolas Connault committed 1 file to 'Moodle CVS' - 02/Jun/08 10:18 PM
MDL-14967 Bug in DB upgrade for get_coursemodule_from_instance: named params were using :$modulename instead of :modulename
MODIFY lib/datalib.php   Rev. 1.476    (+4 -4 lines)
Nicolas Connault committed 32 files to 'Moodle CVS' - 03/Jun/08 12:06 AM
MDL-14967 DB upgrades. Not finished yet.
MODIFY grade/edit/outcome/edit_form.php   Rev. 1.8    (+2 -2 lines)
MODIFY grade/edit/outcome/export.php   Rev. 1.5    (+7 -7 lines)
MODIFY grade/export/lib.php   Rev. 1.52    (+10 -10 lines)
MODIFY lib/dml/moodle_recordset.php   Rev. 1.2    (+4 -4 lines)
MODIFY grade/edit/scale/index.php   Rev. 1.9    (+2 -2 lines)
MODIFY grade/querylib.php   Rev. 1.5    (+17 -15 lines)
MODIFY grade/report/lib.php   Rev. 1.40    (+44 -38 lines)
MODIFY lib/grade/grade_object.php   Rev. 1.43    (+2 -5 lines)
MODIFY grade/report/grader/ajax_callbacks.php   Rev. 1.3    (+8 -8 lines)
MODIFY grade/report/grader/lib.php   Rev. 1.146    (+93 -75 lines)
MODIFY grade/import/csv/index.php   Rev. 1.37    (+3 -3 lines)
MODIFY grade/report/grader/index.php   Rev. 1.75    (+9 -9 lines)
MODIFY grade/edit/settings/index.php   Rev. 1.5    (+2 -2 lines)
MODIFY grade/edit/outcome/import.php   Rev. 1.5    (+30 -23 lines)
MODIFY grade/edit/outcome/course.php   Rev. 1.8    (+12 -11 lines)
MODIFY grade/edit/outcome/edit.php   Rev. 1.7    (+5 -5 lines)
MODIFY grade/import/lib.php   Rev. 1.16    (+11 -11 lines)
MODIFY grade/report/user/lib.php   Rev. 1.33    (+4 -4 lines)
MODIFY grade/edit/scale/edit.php   Rev. 1.9    (+5 -5 lines)
MODIFY grade/edit/tree/action.php   Rev. 1.8    (+2 -2 lines)
MODIFY grade/edit/letter/index.php   Rev. 1.7    (+2 -2 lines)
MODIFY grade/edit/outcome/index.php   Rev. 1.19    (+8 -8 lines)
MODIFY grade/edit/settings/form.php   Rev. 1.6    (+3 -3 lines)
MODIFY grade/report/overview/lib.php   Rev. 1.9    (+3 -3 lines)
MODIFY lib/dml/moodle_database.php   Rev. 1.17    (+2 -2 lines)
MODIFY grade/edit/letter/edit.php   Rev. 1.7    (+7 -7 lines)
MODIFY grade/edit/tree/calculation_form.php   Rev. 1.10    (+3 -3 lines)
MODIFY grade/lib.php   Rev. 1.143    (+110 -92 lines)
MODIFY grade/edit/outcome/import_outcomes_form.php   Rev. 1.3    (+3 -3 lines)
MODIFY grade/edit/letter/edit_form.php   Rev. 1.7    (+5 -5 lines)
MODIFY grade/report/outcomes/index.php   Rev. 1.15    (+2 -2 lines)
MODIFY grade/edit/tree/outcomeitem.php   Rev. 1.20    (+2 -2 lines)
Petr Skoda made changes - 03/Jun/08 06:37 AM
Link This issue is a clone of MDL-15094 [ MDL-15094 ]
mjollnir_ committed 1 file to 'Moodle CVS' - 03/Jun/08 05:47 PM
MDL-14967

fixing a dml change that had the params added to the wrong function call.
MODIFY admin/mnet/peers.php   Rev. 1.23    (+4 -3 lines)
Nicolas Connault committed 45 files to 'Moodle CVS' - 04/Jun/08 12:10 AM
MDL-14967 DB upgrades. All done. Just bug fixing now ;)
MODIFY grade/report/grader/preferences.php   Rev. 1.28    (+3 -3 lines)
MODIFY grade/edit/tree/category_form.php   Rev. 1.24    (+6 -6 lines)
MODIFY grade/edit/letter/edit.php   Rev. 1.8    (+2 -2 lines)
MODIFY grade/edit/tree/item.php   Rev. 1.19    (+2 -2 lines)
MODIFY grade/edit/tree/outcomeitem.php   Rev. 1.21    (+5 -4 lines)
MODIFY grade/import/xml/index.php   Rev. 1.23    (+2 -2 lines)
MODIFY grade/export/ods/grade_export_ods.php   Rev. 1.15    (+1 -1 lines)
MODIFY grade/export/keymanager.php   Rev. 1.4    (+3 -2 lines)
MODIFY grade/edit/tree/calculation.php   Rev. 1.18    (+3 -3 lines)
MODIFY grade/edit/tree/grade_form.php   Rev. 1.14    (+5 -5 lines)
MODIFY grade/import/key.php   Rev. 1.5    (+7 -7 lines)
MODIFY grade/export/ods/index.php   Rev. 1.30    (+2 -2 lines)
MODIFY grade/import/xml/lib.php   Rev. 1.9    (+4 -4 lines)
MODIFY grade/report/grader/ajax_callbacks.php   Rev. 1.4    (+3 -3 lines)
MODIFY grade/import/xml/grade_import_form.php   Rev. 1.8    (+6 -3 lines)
MODIFY grade/export/lib.php   Rev. 1.53    (+38 -35 lines)
MODIFY grade/import/csv/index.php   Rev. 1.38    (+14 -14 lines)
MODIFY grade/report/lib.php   Rev. 1.41    (+3 -3 lines)
MODIFY grade/report/user/index.php   Rev. 1.35    (+10 -10 lines)
MODIFY grade/report/user/lib.php   Rev. 1.34    (+18 -16 lines)
MODIFY grade/edit/outcome/course.php   Rev. 1.9    (+2 -2 lines)
MODIFY grade/edit/tree/grade.php   Rev. 1.24    (+4 -4 lines)
MODIFY grade/export/key.php   Rev. 1.7    (+7 -7 lines)
MODIFY grade/export/xml/index.php   Rev. 1.39    (+2 -2 lines)
MODIFY grade/edit/settings/index.php   Rev. 1.6    (+2 -2 lines)
MODIFY grade/report/grader/lib.php   Rev. 1.147    (+3 -2 lines)
MODIFY grade/edit/tree/item_form.php   Rev. 1.41    (+4 -4 lines)
MODIFY grade/report/overview/lib.php   Rev. 1.10    (+19 -15 lines)
MODIFY grade/export/txt/index.php   Rev. 1.34    (+2 -2 lines)
MODIFY grade/edit/tree/index.php   Rev. 1.20    (+3 -3 lines)
MODIFY grade/import/lib.php   Rev. 1.17    (+24 -20 lines)
MODIFY grade/export/xls/grade_export_xls.php   Rev. 1.15    (+3 -3 lines)
MODIFY grade/edit/outcome/index.php   Rev. 1.20    (+2 -2 lines)
MODIFY grade/lib.php   Rev. 1.144    (+14 -5 lines)
MODIFY grade/report/user/styles.php   Rev. 1.4    (+6 -6 lines)
MODIFY grade/edit/tree/category.php   Rev. 1.13    (+2 -2 lines)
MODIFY grade/report/overview/index.php   Rev. 1.8    (+2 -2 lines)
MODIFY grade/export/xml/grade_export_xml.php   Rev. 1.26    (+7 -7 lines)
MODIFY grade/export/grade_export_form.php   Rev. 1.35    (+12 -10 lines)
MODIFY grade/report/outcomes/index.php   Rev. 1.16    (+5 -5 lines)
MODIFY grade/export/txt/grade_export_txt.php   Rev. 1.17    (+7 -7 lines)
MODIFY grade/report/grader/index.php   Rev. 1.76    (+2 -2 lines)
MODIFY grade/report/index.php   Rev. 1.7    (+2 -2 lines)
MODIFY grade/import/keymanager.php   Rev. 1.3    (+3 -2 lines)
MODIFY grade/export/xls/index.php   Rev. 1.29    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 04/Jun/08 05:58 AM
MDL-14967 fixed syntax error
MODIFY grade/import/keymanager.php   Rev. 1.4    (+2 -2 lines)
Petr Skoda added a comment - 09/Jun/08 08:31 PM
done, yay!

Petr Skoda made changes - 09/Jun/08 08:31 PM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Assignee Nicolas Connault [ nicolasconnault ] Petr Skoda [ skodak ]
Petr Skoda made changes - 15/Jun/08 05:51 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Petr Skoda added a comment - 15/Jun/08 06:13 PM
done

Petr Skoda made changes - 15/Jun/08 06:13 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Piers Harding committed 2 files to 'Moodle CVS' - 29/Jul/08 09:01 AM
MDL-14967 Upgrade all code using DML - a few missing bits in mod/scorm.
MODIFY mod/scorm/aicc.php   Rev. 1.27    (+5 -5 lines)
MODIFY mod/scorm/datamodels/aicclib.php   Rev. 1.12    (+2 -2 lines)
bobopinna committed 1 file to 'Moodle CVS' - 21/Aug/08 03:32 PM
MDL-14967 Upgrade all code using DML - fixed missing changes in scorm_get_scoes
MODIFY mod/scorm/locallib.php   Rev. 1.65    (+8 -5 lines)