|
[
Permalink
| « Hide
]
Michael Woods added a comment - 30/May/08 09:42 AM
Update - we tested on our 1.9 test instance and the bug is there also.
Forgot to mention an earlier change we made which should probably come under the same bug report.
Around line 285 of enrol/ldap/enrol.php (v1.8.2), current enrolments are inserted, but this fails for anyone with an apostrophe. We replaced: ." WHERE idnumber='$ldapmember'"; with ." WHERE idnumber='".str_replace("'", "\'",$ldapmember)."'"; I think this is still outstanding in 1.9. Hi Michael,
this should be fixed in the latest CVS versions of 1.8, 1.9 and HEAD. Could you confirm it, please? Saludos. Iñaki. should not have been resolved.
Hi,
what is the status? should we resolve this? All my tests show that this should be fixed in 1.8, 1.9 and 2.0 (with your patch from MDL-14679, in revision 1.25), but I was waiting for comfirmation from Michael Woods.
Saludos. Iñaki. thanks, my +1 to Resolve it now and wait with Closing a bit
Hi all,
Inaki - thank you for the fix. Unfortunately, I still haven't had a chance to test it. If your tests show that this is resolved, feel free to close it. When I eventually get around to testing it, I can let you know if there any problems (which I doubt). Thanks again, Resolving now. Michael, please reopen if it doesn't fix your case
Saludos. Iñaki. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||