[#MDL-15039] Apostrophes preventing any users in course being unenrolled via LDAP

Issue Details (XML | Word | Printable)

Key:	MDL-15039
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Iñaki Arenaza
Reporter:	Michael Woods
Votes:	1
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Apostrophes preventing any users in course being unenrolled via LDAP

Created: 29/May/08 02:09 PM Updated: 14/Jun/08 08:37 PM

Return to search

Component/s:

Enrolments

Affects Version/s:

1.8.2, 1.9

Fix Version/s:

1.8.6, 1.9.2

Environment:

MS Active Directory

Database:	MySQL
Participants:	Iñaki Arenaza, Michael Blake, Michael Woods and Petr Skoda
Security Level:	None
Resolved date:	14/Jun/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

If any member of a course has an ID number containing an apostrophe (eg. CN=Paddy O'Brien,OU=Students,DC=etc...), no other members will ever be unenrolled via LDAP.

In enrol/ldap/enrol.php, this is due to the array $ldapmembers not accounting for apostrophes and therefore get_records_sql($sql) fails to return any members due to the resultant syntax error.

It doesn't just affect the name with an apostrophe - it affects any members of the same course.

We fixed by replacing the following code around line 264 (v1.8.2)

$sql .= 'AND usr.idnumber NOT IN (\''. join('\',\'', $ldapmembers).'\')';

with...

$sql .= 'AND usr.idnumber NOT IN (\''. join('\',\'', str_replace("'", "\'",$ldapmembers)).'\')';

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Michael Woods added a comment - 30/May/08 09:42 AM

Update - we tested on our 1.9 test instance and the bug is there also.

Michael Woods made changes - 30/May/08 09:42 AM

Field	Original Value	New Value
Affects Version/s		1.9 [ 10190 ]

Iñaki Arenaza made changes - 01/Jun/08 08:54 PM

Assignee

Nobody [ nobody ]

Iñaki Arenaza [ iarenaza ]

[ Permalink | « Hide ]

Michael Woods added a comment - 02/Jun/08 07:27 AM

Forgot to mention an earlier change we made which should probably come under the same bug report.

Around line 285 of enrol/ldap/enrol.php (v1.8.2), current enrolments are inserted, but this fails for anyone with an apostrophe.

We replaced:

." WHERE idnumber='$ldapmember'";

with

." WHERE idnumber='".str_replace("'", "\'",$ldapmember)."'";

I think this is still outstanding in 1.9.

Iñaki Arenaza committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 03/Jun/08 06:33 AM

~~MDL-15039~~ Apostrophes in idnumber prevent users from being unenrolled via LDAP

If any member of a course has an ID number containing an apostrophe (eg.
CN=Paddy O'Brien,OU=Students,DC=etc...), no other members will ever be
unenrolled via LDAP.

Thanks to Michael Woods for the bug report and proposed solution.

MODIFY

enrol/ldap/enrol.php

Rev. 1.17.6.6

(+6 -5 lines)

Iñaki Arenaza committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jun/08 06:35 AM

MODIFY

enrol/ldap/enrol.php

Rev. 1.21.2.3

(+6 -5 lines)

Iñaki Arenaza committed 1 file to 'Moodle CVS' - 03/Jun/08 06:39 AM

MODIFY

enrol/ldap/enrol.php

Rev. 1.25

(+6 -5 lines)

[ Permalink | « Hide ]

Iñaki Arenaza added a comment - 03/Jun/08 06:40 AM

Hi Michael,

this should be fixed in the latest CVS versions of 1.8, 1.9 and HEAD.

Could you confirm it, please?

Saludos. Iñaki.

Iñaki Arenaza made changes - 03/Jun/08 06:41 AM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permalink | « Hide ]

Michael Blake added a comment - 10/Jun/08 04:45 PM

test

Michael Blake made changes - 10/Jun/08 04:45 PM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Michael Blake added a comment - 10/Jun/08 04:46 PM

should not have been resolved.

Michael Blake made changes - 10/Jun/08 04:46 PM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Petr Skoda made changes - 10/Jun/08 11:15 PM

Fix Version/s		1.8.6 [ 10270 ]
Fix Version/s		1.9.2 [ 10280 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Jun/08 11:15 PM

Hi,
what is the status? should we resolve this?

[ Permalink | « Hide ]

Iñaki Arenaza added a comment - 10/Jun/08 11:34 PM

All my tests show that this should be fixed in 1.8, 1.9 and 2.0 (with your patch from MDL-14679, in revision 1.25), but I was waiting for comfirmation from Michael Woods.

Saludos. Iñaki.

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Jun/08 11:37 PM

thanks, my +1 to Resolve it now and wait with Closing a bit

[ Permalink | « Hide ]

Michael Woods added a comment - 11/Jun/08 06:54 AM

Hi all,

Inaki - thank you for the fix. Unfortunately, I still haven't had a chance to test it. If your tests show that this is resolved, feel free to close it. When I eventually get around to testing it, I can let you know if there any problems (which I doubt).

Thanks again,
Michael

[ Permalink | « Hide ]

Iñaki Arenaza added a comment - 14/Jun/08 08:37 PM

Resolving now. Michael, please reopen if it doesn't fix your case

Saludos. Iñaki.

Iñaki Arenaza made changes - 14/Jun/08 08:37 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.