Moodle

RTL CSS problems: forum indenting and navigation menu formatting

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.1
  • Fix Version/s: 1.9.2
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

standard/rtl.css file has a line in the wrong place

Issue Links

This issue has been marked as being related by:
MDL-15123 RTL problem: Navigation menu options are indented from left to right Minor Closed
MDL-15124 RTL problem: Rounded corners in the forum posts are in the wrong places Minor Closed
MDL-15126 RTL problem: The navigation bar has the site name and the course short name in left-to-right order Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Working perfect now on my Hebrew test site.

Show
Martin Dougiamas added a comment - Working perfect now on my Hebrew test site.
Hide
Permalink
Samuli Karevaara added a comment -

I'm reopening this. The bug description (line in wrong place) has been fixed. But the bug itself (RTL CSS problems: forum indenting and navigation menu formatting) still seems to be there. I verified that the new CSS and the fixed line position are in there, but some problems remain, see the attached picture (for Arabic test):

  • The Navigation menu has LTR instead of RTL as far as I can tell?
  • The rounded corners in the forum posts are in the wrong places.
  • The navigation bar has the site name (Keski-Suomen Koulu) and the course short name (FYS-101) in left-to-right order, should they also be in right-to-left?

I don't know much about how the RTL is supposed to work, so apologies if my conclusions are wrong.

Martin, if you get different results, can you attach a screenshot? I'm testing 1.9 stable only, with Firefox 2.0.0.14.

Show
Samuli Karevaara added a comment - I'm reopening this. The bug description (line in wrong place) has been fixed. But the bug itself (RTL CSS problems: forum indenting and navigation menu formatting) still seems to be there. I verified that the new CSS and the fixed line position are in there, but some problems remain, see the attached picture (for Arabic test):
  • The Navigation menu has LTR instead of RTL as far as I can tell?
  • The rounded corners in the forum posts are in the wrong places.
  • The navigation bar has the site name (Keski-Suomen Koulu) and the course short name (FYS-101) in left-to-right order, should they also be in right-to-left?
I don't know much about how the RTL is supposed to work, so apologies if my conclusions are wrong. Martin, if you get different results, can you attach a screenshot? I'm testing 1.9 stable only, with Firefox 2.0.0.14.
Hide
Permalink
Martin Dougiamas added a comment -

Yes, RTL is a wierd thing. I think the browser tries to do something intelligent with mixed RTL and LTR text, because some of the mixing up seems reduced on a fully RTL site.

Could you please file new bugs for all these and I'll try to find a RTL expert to examine them. I'll close this because the main problems I was seeing are fixed.

The rounded corners: quick fix is to disable the "styles_moz" file from the current theme ... those rounded corners just don't work properly in RTL. I suppose we could add heaps of overrides into rtl.css to disable them.

Show
Martin Dougiamas added a comment - Yes, RTL is a wierd thing. I think the browser tries to do something intelligent with mixed RTL and LTR text, because some of the mixing up seems reduced on a fully RTL site. Could you please file new bugs for all these and I'll try to find a RTL expert to examine them. I'll close this because the main problems I was seeing are fixed. The rounded corners: quick fix is to disable the "styles_moz" file from the current theme ... those rounded corners just don't work properly in RTL. I suppose we could add heaps of overrides into rtl.css to disable them.
Hide
Permalink
Samuli Karevaara added a comment -

Closed as suggested. Three new issues were filed for the remaining oddities, see the linked issues.

Show
Samuli Karevaara added a comment - Closed as suggested. Three new issues were filed for the remaining oddities, see the linked issues.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.