[#MDL-15053] RTL CSS problems: forum indenting and navigation menu formatting

Issue Details (XML | Word | Printable)

Key:	MDL-15053
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Martin Dougiamas
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

RTL CSS problems: forum indenting and navigation menu formatting

Created: 30/May/08 11:20 AM Updated: 03/Jun/08 05:08 PM

Return to search

Component/s:

Themes

Affects Version/s:

1.9.1

Fix Version/s:

1.9.2

File Attachments:

None

Image Attachments:

1. rtl-test-1.png
(40 kB)

Issue Links:

Relates

This issue has been marked as being related by:

MDL-15124 RTL problem: Rounded corners in the forum posts are in the wrong places

MDL-15123 RTL problem: Navigation menu options are indented from left to right

MDL-15126 RTL problem: The navigation bar has the site name and the course short name in left-to-right order

Participants:	Martin Dougiamas and Samuli Karevaara
Security Level:	None
QA Assignee:	Samuli Karevaara
Resolved date:	03/Jun/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

standard/rtl.css file has a line in the wrong place

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 30/May/08 11:43 AM

Working perfect now on my Hebrew test site.

[ Permalink | « Hide ]

Samuli Karevaara added a comment - 03/Jun/08 01:39 PM

I'm reopening this. The bug description (line in wrong place) has been fixed. But the bug itself (RTL CSS problems: forum indenting and navigation menu formatting) still seems to be there. I verified that the new CSS and the fixed line position are in there, but some problems remain, see the attached picture (for Arabic test):

The Navigation menu has LTR instead of RTL as far as I can tell?
The rounded corners in the forum posts are in the wrong places.
The navigation bar has the site name (Keski-Suomen Koulu) and the course short name (FYS-101) in left-to-right order, should they also be in right-to-left?

I don't know much about how the RTL is supposed to work, so apologies if my conclusions are wrong.

Martin, if you get different results, can you attach a screenshot? I'm testing 1.9 stable only, with Firefox 2.0.0.14.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 03/Jun/08 02:54 PM

Yes, RTL is a wierd thing. I think the browser tries to do something intelligent with mixed RTL and LTR text, because some of the mixing up seems reduced on a fully RTL site.

Could you please file new bugs for all these and I'll try to find a RTL expert to examine them. I'll close this because the main problems I was seeing are fixed.

The rounded corners: quick fix is to disable the "styles_moz" file from the current theme ... those rounded corners just don't work properly in RTL. I suppose we could add heaps of overrides into rtl.css to disable them.

[ Permalink | « Hide ]

Samuli Karevaara added a comment - 03/Jun/08 05:08 PM

Closed as suggested. Three new issues were filed for the remaining oddities, see the linked issues.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.