|
[
Permalink
| « Hide
]
Petr Skoda added a comment - 20/Jun/08 03:12 PM
please do not use tab characters
SQLite language strings and install options
patches in cvs:
thanks for the patches! Now I am going to: my changes are in cvs, please cvs update
Have seen one commit related to this bug:
+ } else { I'd suggest using EXISTS instead of IN. Not sure if sqllite supports it, though. FYC, ciao, Eloy @Eloy SQLite supports IN, but is there a particular reason for using EXISTS instead of IN?
In this case, the subquery would reference the record in the {context} table like this (SELECT id FROM {context_temp} WHERE id = {context}.id). For many RDBMS this means to rerun the subquery for each record. Using IN involves running the subquery only once and then check the result for each record. Fixes a regular expression in xmldb_object which breaks sentences with empty strings.
thanks!! going to start merging this at the end of this week, we have to release 1.9.2 and friends now.
rewrite of getAllReservedWords and added support for SQLite's reserved words
sending db move patch updated to apply to current HEAD (not tested)
oops, forgot to include some parts, moment please
going to commit parts that are not related to db migration today and post smaller patch dre - see MDL-15635 for more info
1/ It seems that we do not need the changes in settings export - not committed
2/ the static methods proposed for moodle_database do not have optimal names imho - get_supported_drivers() returns all core drivers, event those experiment (== not supported), get_all_drivers() does not return "all" drivers, only the core drivers; =& is not needed in PHP5; php docs should be enclosed by /** */ - not committed for now 3/ the database mover changes not committed - see MDL-15635 thanks for the patches! 1/ It would be usefull for the db mover if I could get information from a driver (through export) about it's current settings.
2/ I'll fix these comments and =&. Is get_driver_names better? Or another suggestion, please. I took the list of drivers from install.php and these are all existing drivers at the moment. What do you mean by "all"? Full ALTER TABLE support + bug fixes
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||