|
Can you give us the time scale (in the northern hemisphere summer holidays are coming) to do the job.
This will also put a major "chinese wall" between 2.0 and older versions so that merging down to even 1.9 will be a very "cautious if not impossible " procedure. But I suppose that have been discussed elsewhere. Sorry, I probably misreaded
." All the functions that used to accept a list of string params in the form "param1, value1, param2, value2" now need to be given an array of key=>value pairs as a replacement for these params. Other params remain as before. Check the new API for any exceptions. " So list of string params in the form "question_id1, question_id2,question_id3 "remains as they are? And the only changes are adding $DB-> before functions as $DB->get_record_select ()? If this is so, the height of the "chinese wall" decreased... Please read http://docs.moodle.org/en/Development:dmllib_2.0_migration_docs
Nicolas,
Thanks for the reference. I am willing to do the work on the part of the question code that I know well, so to be able to test everything correctly. However I cannot do this before mid-august, is it to late ? Thanks Pierre, but it will be too late I think, maybe Petr can correct me on this...
Just attached a script which recursively searches the folder in which it is run, looking for patterns of code that needs upgrading to the new DML syntax. It uses grep to output all the matching lines to standard output, and produces a summary text file (dml_search_summary) listing the files with matches, and showing the count of matches within each file.
oh, this conversion must be finished next week
I am planning to finish the dml conversion on Monday (9th) and on Tuesday start the magic quotes elimination
Please hurry with the commits, minor breakages are not a problem all except global search finished - yay!
seems to be working fine for some time, reclosing
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1/ form->get_data(false) returns form data without magic quotes
2/ data_submitted(false) return form data without magic quotes
3/ add stripslashes() after optional|required_param() - separate line preferable
4/ keep addslashes_js()!! - javascript quoting, XSS prevention; some existing addslashes() are incorrect