Moodle

Thanks Petr.

I've merged my side. We will keep an eye when I may commit back a few fixes. I'll tell you when I'm ready so we can check my local merges are OK with you.

Cheers.

Hello Valery,
are you planning to work on this next week?

I'm not sure. I am actually with Jonathan Newman (Catalyst) in UK and we have a huge workplan to prepare. I will not have time for global search next week, neverthless can I avoid to work on it and do something else.

no problem, this is the only part that may wait - it will just break when we do the final removal of magic quotes and old dml function, the rest of moodle will work just fine

thanks for the info!

Hi Petr,

was you who discarded the search_escape_string() function in search/lib ? So I can ask you my question :

Would'nt we have to remove that local escaping from search/indexlib.php there :

§230 -> §239

// object to insert into db
$doc->doctype = $document->doctype;
$doc->docid = $document->docid;
$doc->itemtype = $document->itemtype;
$doc->title = search_escape_string($document->title); <<<<<<<<
$doc->url = search_escape_string($document->url); <<<<<<<<
$doc->updated = time();
$doc->docdate = $document->date;
$doc->courseid = $document->course_id;
$doc->groupid = $document->group_id;

as there should be no more need for pre escaping string data witgh the new DB implementation. Am i right ?

Cheers.

Hi Valery,

yes, you're right. We don't need to escape data anymore. And yes, those escaping aren't needed any more (and they are out from HEAD if I'm not wrong).

Ciao

Closing because global search was removed from Moodle 2.2, thanks anyway.