I've merged my side. We will keep an eye when I may commit back a few fixes. I'll tell you when I'm ready so we can check my local merges are OK with you.

Cheers.

thanks for the info!

was you who discarded the search_escape_string() function in search/lib ? So I can ask you my question :

Would'nt we have to remove that local escaping from search/indexlib.php there :

§230 -> §239

// object to insert into db
$doc->doctype = $document->doctype;
$doc->docid = $document->docid;
$doc->itemtype = $document->itemtype;
$doc->title = search_escape_string($document->title); <<<<<<<<
$doc->url = search_escape_string($document->url); <<<<<<<<
$doc->updated = time();
$doc->docdate = $document->date;
$doc->courseid = $document->course_id;
$doc->groupid = $document->group_id;

as there should be no more need for pre escaping string data witgh the new DB implementation. Am i right ?

Cheers.

yes, you're right. We don't need to escape data anymore. And yes, those escaping aren't needed any more (and they are out from HEAD if I'm not wrong).

Ciao