Moodle

Continue link shows at the final screen of import BEFORE import is finished.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9, 1.9.1
  • Fix Version/s: 1.9.4
  • Component/s: Usability
  • Labels:
    None
  • Environment:
    ALL
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Continue link shows at the final screen of import BEFORE import is finished allowing instructors to click it getting empty resources in their course. A simple fix would be to remove this bit of html

<div id="continue">( <a href="%CONTINUE LINK%">Continue</a> )</div>

Issue Links

This issue will help resolve:
MDL-10993 Restore creates duplicate activity/resource icons with no text Major Closed
This issue is duplicated by:
MDL-16155 Import failures? Leaves course with empty and undeletable resources and activities. Critical Closed
MDL-15444 Import from other courses creates many links on course page without resources attached Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tony Butler added a comment -

I've just encountered this in 1.9.2.

In some cases clicking the 'continue' link results in the course contents being imported twice!

Show
Tony Butler added a comment - I've just encountered this in 1.9.2. In some cases clicking the 'continue' link results in the course contents being imported twice!
Hide
Permalink
Aaron E. Klemm added a comment -

The issue exists on my 1.9.2 install and did on the 1.8.x versions I ran previously. Instructors accidently click this continue button very often and I can't say I blame them. It definitely looks like that button should be clicked.

Of course, when they do click it, their course resources get severely messed up.

Show
Aaron E. Klemm added a comment - The issue exists on my 1.9.2 install and did on the 1.8.x versions I ran previously. Instructors accidently click this continue button very often and I can't say I blame them. It definitely looks like that button should be clicked. Of course, when they do click it, their course resources get severely messed up.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I have added a workaround that removes the continue timeout and adds a warning message that the continue link should not be clicked - unfortunately I did not find a better solution because it would require major refactoring to get it done properly

thanks for the report

Show
Petr Škoda (skodak) added a comment - I have added a workaround that removes the continue timeout and adds a warning message that the continue link should not be clicked - unfortunately I did not find a better solution because it would require major refactoring to get it done properly thanks for the report
Hide
Permalink
Tim Hunt added a comment -

Yuck!

I have one suggestion to make things better. Instead of displaying the silly string, why not print the continue link inside a div styled with display: none, so it cannot be seen or clicked. That is still a nasty hack, but I think it is a bit nicer.

Show
Tim Hunt added a comment - Yuck! I have one suggestion to make things better. Instead of displaying the silly string, why not print the continue link inside a div styled with display: none, so it cannot be seen or clicked. That is still a nasty hack, but I think it is a bit nicer.
Hide
Permalink
Petr Škoda (skodak) added a comment -

You will have to ask penny and all other devs, I am not 100 % sure it would not break some 3rd party automated course import scripts

Show
Petr Škoda (skodak) added a comment - You will have to ask penny and all other devs, I am not 100 % sure it would not break some 3rd party automated course import scripts
Hide
Permalink
Aaron E. Klemm added a comment -

Thanks for working on a stop-gap fix! I've applied the patch and it's certainly better than giving the user no warning at all. I do agree that it would be better to remove the continue link one way or another...can anyone give a tip on how to do that?

Show
Aaron E. Klemm added a comment - Thanks for working on a stop-gap fix! I've applied the patch and it's certainly better than giving the user no warning at all. I do agree that it would be better to remove the continue link one way or another...can anyone give a tip on how to do that?
Hide
Permalink
Tim Hunt added a comment -

As I say. Try CSS in your theme. The Firebug extension to Firefox will help you write the appropriate rule.

Show
Tim Hunt added a comment - As I say. Try CSS in your theme. The Firebug extension to Firefox will help you write the appropriate rule.
Hide
Permalink
Tim Hunt added a comment -

Closing now. I am satisfied by Petr's last comment.

Show
Tim Hunt added a comment - Closing now. I am satisfied by Petr's last comment.

People

Vote (3)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.