[#MDL-15172] Continue link shows at the final screen of import BEFORE import is finished.

Issue Details (XML | Word | Printable)

Key:	MDL-15172
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Robert Russo
Votes:	3
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Continue link shows at the final screen of import BEFORE import is finished.

Created: 06/Jun/08 09:24 PM Updated: 17/Jan/09 03:43 AM

Return to search

Component/s:

Usability

Affects Version/s:

1.9, 1.9.1

Fix Version/s:

1.9.4

Environment:

ALL

Issue Links:

Dependency

This issue will help resolve:

MDL-10993 Restore creates duplicate activity/resource icons with no text

Duplicate

This issue is duplicated by:

~~MDL-16155~~ Import failures? Leaves course with empty and undeletable resources and activities.

~~MDL-15444~~ Import from other courses creates many links on course page without resources attached

Database:	Any
Participants:	Aaron E. Klemm, Petr Skoda, Robert Russo, Tim Hunt and Tony Butler
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	02/Jan/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Continue link shows at the final screen of import BEFORE import is finished allowing instructors to click it getting empty resources in their course. A simple fix would be to remove this bit of html

<div id="continue">( <a href="%CONTINUE LINK%">Continue</a> )</div>

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Tony Butler added a comment - 25/Sep/08 11:48 PM

I've just encountered this in 1.9.2.

In some cases clicking the 'continue' link results in the course contents being imported twice!

[ Permalink | « Hide ]

Aaron E. Klemm added a comment - 11/Dec/08 10:16 AM

The issue exists on my 1.9.2 install and did on the 1.8.x versions I ran previously. Instructors accidently click this continue button very often and I can't say I blame them. It definitely looks like that button should be clicked.

Of course, when they do click it, their course resources get severely messed up.

Petr Skoda made changes - 02/Jan/09 01:03 AM

Field	Original Value	New Value
Assignee	Martin Dougiamas [ dougiamas ]	Petr ?koda [ skodak ]

Petr Skoda committed 2 files to 'Moodle CVS' - 02/Jan/09 01:05 AM

~~MDL-15172~~ lowered timeoout and adding warning that users must not click continue in middle of course import - this is a silly workaround, unfortunately I did not find better solution

MODIFY	backup/restorelib.php		Rev. 1.360		(+6 -2 lines)
MODIFY	lang/en_utf8/moodle.php		Rev. 1.223		(+2 -1 lines)

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Jan/09 01:06 AM

~~MDL-15172~~ lowered timeoout and adding warning that users must not click continue in middle of course import - this is a silly workaround, unfortunately I did not find better solution; backported from HEAD

MODIFY	backup/restorelib.php		Rev. 1.283.2.57		(+6 -2 lines)
MODIFY	lang/en_utf8/moodle.php		Rev. 1.141.2.53		(+2 -1 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/09 01:08 AM

I have added a workaround that removes the continue timeout and adds a warning message that the continue link should not be clicked - unfortunately I did not find a better solution because it would require major refactoring to get it done properly

thanks for the report

Petr Skoda made changes - 02/Jan/09 01:08 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.9.4 [ 10300 ]

Petr Skoda made changes - 02/Jan/09 01:09 AM

Link

This issue is duplicated by ~~MDL-16155~~ [ ~~MDL-16155~~ ]

Petr Skoda made changes - 02/Jan/09 01:11 AM

Link

This issue is duplicated by ~~MDL-15444~~ [ ~~MDL-15444~~ ]

martignoni committed 1 file to 'Lang CVS' - 02/Jan/09 01:45 AM

~~MDL-15172~~ String translated

MODIFY

fr_utf8/moodle.php

Rev. 1.271

(+2 -1 lines)

Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 02/Jan/09 10:14 AM

~~MDL-15172~~ Translated a new string for course import.

MODIFY	ja_utf8/README		Rev. 1.907		(+1 -1 lines)
MODIFY	ja_utf8/moodle.php		Rev. 1.343		(+2 -1 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 06/Jan/09 11:32 AM

Yuck!

I have one suggestion to make things better. Instead of displaying the silly string, why not print the continue link inside a div styled with display: none, so it cannot be seen or clicked. That is still a nasty hack, but I think it is a bit nicer.

Tim Hunt made changes - 06/Jan/09 11:32 AM

QA Assignee

timhunt

[ Permalink | « Hide ]

Petr Skoda added a comment - 06/Jan/09 05:25 PM

You will have to ask penny and all other devs, I am not 100 % sure it would not break some 3rd party automated course import scripts

[ Permalink | « Hide ]

Aaron E. Klemm added a comment - 09/Jan/09 03:22 AM

Thanks for working on a stop-gap fix! I've applied the patch and it's certainly better than giving the user no warning at all. I do agree that it would be better to remove the continue link one way or another...can anyone give a tip on how to do that?

[ Permalink | « Hide ]

Tim Hunt added a comment - 13/Jan/09 03:43 PM

As I say. Try CSS in your theme. The Firebug extension to Firefox will help you write the appropriate rule.

[ Permalink | « Hide ]

Tim Hunt added a comment - 13/Jan/09 03:44 PM

Closing now. I am satisfied by Petr's last comment.

Tim Hunt made changes - 13/Jan/09 03:44 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Ann Adamcik made changes - 17/Jan/09 03:42 AM

Link

This issue is blocked by MDL-10993 [ MDL-10993 ]

Ann Adamcik made changes - 17/Jan/09 03:43 AM

Link

This issue is blocked by MDL-10993 [ MDL-10993 ]

Ann Adamcik made changes - 17/Jan/09 03:43 AM

Link

This issue will help resolve MDL-10993 [ MDL-10993 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.