|
[
Permalink
| « Hide
]
Petr Skoda added a comment - 08/Jun/08 06:55 PM
please fix before review Tuesday, thanks
Well this is what you get for trying to do something quickly that looked simple I guess. A big SORRY for me, this 1 line change has been a pain all the way.
I've just reverted the code in graphlib, so all core graphs should go back to working now. What I was trying to do was resolve an issue for some-one else at the OU who had used $graph->parameter['y_tick_labels'] rather than the way Jamie has defaulted the values above. She's on maternity leave so sadly I can't ask why! I've altered her code to match Jamie's instead so the contrib module should work now with the core code - which is better. What I wonder though - and why I'm not closing this yet, is whether we should add to the class init to default offset_relation and y_tick_labels to null, rather than expect every new graph() to do it? Hi Jenny,
Thanks for fixing this. My +1 to set default properties of class graph : var $y_tick_labels = null; Jamie Jenny's patch looks good to me. Tested in overview report and it looks OK. No need for :
//following two lines seem to silence notice warnings from graphlib.php Anymore. Defaults added as Jamie suggested.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||