Issue Details (XML | Word | Printable)

Key: MDL-15249
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17458

convert, fix and improve CLI installler

Created: 15/Jun/08 07:42 PM   Updated: 04/Jun/09 12:29 AM
Component/s: Administration
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Penny Leach and Petr Skoda
Security Level: None
Resolved date: 04/Jun/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 15/Jun/08 08:05 PM
hmm - the CLI installer/upgrade code is not nice at all and needs to be rewritten

Penny Leach added a comment - 19/Jun/08 11:05 PM
Petr can you elaborate?

Petr Skoda added a comment - 20/Jun/08 03:30 AM
There is was too much duplication of code, the installib.php was incorrectly used for cli stuff instead of install stuff.
Also there are too many ifs, we should imo add general cli support and share much more code between /install.php, /admin/index.php. cli installer and cron

This can wait a bit, I hope this summer we will be working on weblib/pagelib rewrite.
In any case I did not test my changes in cli code yet, I am also planning several more ddl related (exceptions - yay!) and general session changes (I hope I will commit everything this weekend).

Any help will be appreciated later


Petr Skoda added a comment - 27/May/09 05:53 PM

Petr Skoda added a comment - 04/Jun/09 12:29 AM
all the duplication should be removed now, seems to work fine without nay warnings or notices now, please note it runs in full debug and error display mode now
thanks