Moodle

convert, fix and improve CLI installler

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Activity

Hide
Petr Škoda (skodak) added a comment -

hmm - the CLI installer/upgrade code is not nice at all and needs to be rewritten

Show
Petr Škoda (skodak) added a comment - hmm - the CLI installer/upgrade code is not nice at all and needs to be rewritten
Hide
Penny Leach added a comment -

Petr can you elaborate?

Show
Penny Leach added a comment - Petr can you elaborate?
Hide
Petr Škoda (skodak) added a comment -

There is was too much duplication of code, the installib.php was incorrectly used for cli stuff instead of install stuff.
Also there are too many ifs, we should imo add general cli support and share much more code between /install.php, /admin/index.php. cli installer and cron

This can wait a bit, I hope this summer we will be working on weblib/pagelib rewrite.
In any case I did not test my changes in cli code yet, I am also planning several more ddl related (exceptions - yay!) and general session changes (I hope I will commit everything this weekend).

Any help will be appreciated later

Show
Petr Škoda (skodak) added a comment - There is was too much duplication of code, the installib.php was incorrectly used for cli stuff instead of install stuff. Also there are too many ifs, we should imo add general cli support and share much more code between /install.php, /admin/index.php. cli installer and cron This can wait a bit, I hope this summer we will be working on weblib/pagelib rewrite. In any case I did not test my changes in cli code yet, I am also planning several more ddl related (exceptions - yay!) and general session changes (I hope I will commit everything this weekend). Any help will be appreciated later
Show
Petr Škoda (skodak) added a comment - see http://docs.moodle.org/en/CLI_scripts
Hide
Petr Škoda (skodak) added a comment -

all the duplication should be removed now, seems to work fine without nay warnings or notices now, please note it runs in full debug and error display mode now
thanks

Show
Petr Škoda (skodak) added a comment - all the duplication should be removed now, seems to work fine without nay warnings or notices now, please note it runs in full debug and error display mode now thanks

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: