|
|
| Participants: |
Daniel Servos and Nicolas Connault
|
| Security Level: |
None
|
| Resolved date: |
16/Jun/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
|
Method setup_groups() in class grade_report has been changed to private in Moodle 2.0 development head when it should be public (or the grader plug-in needs fixing).
report/grader and some other grade book plug-ins extend the class grade_report and call setup_groups() witch used to be public. This means that grader and other plug-ins will throw a Fatal error: "Fatal error: Call to private method grade_report::setup_groups() from context 'grade_report_grader' in /var/www/localhost/htdocs/moodle/grade/report/grader/lib.php on line 147" when trying to show or deal with groups.
This can be fixed by making setup_groups public or protected. I am rather sure it should be one of those as no method in grade_report calls setup_groups so making it private means nothing is or can use it.
|
|
Description
|
Method setup_groups() in class grade_report has been changed to private in Moodle 2.0 development head when it should be public (or the grader plug-in needs fixing).
report/grader and some other grade book plug-ins extend the class grade_report and call setup_groups() witch used to be public. This means that grader and other plug-ins will throw a Fatal error: "Fatal error: Call to private method grade_report::setup_groups() from context 'grade_report_grader' in /var/www/localhost/htdocs/moodle/grade/report/grader/lib.php on line 147" when trying to show or deal with groups.
This can be fixed by making setup_groups public or protected. I am rather sure it should be one of those as no method in grade_report calls setup_groups so making it private means nothing is or can use it. |
Show » |
made changes - 16/Jun/08 02:14 PM
| Field |
Original Value |
New Value |
|
Attachment
|
|
grade_report_fix.txt
[ 14238
]
|
made changes - 16/Jun/08 03:21 PM
|
Assignee
|
Petr Skoda
[ skodak
]
|
Nicolas Connault
[ nicolasconnault
]
|
committed 1 file to 'Moodle CVS' - 16/Jun/08 05:30 PM
MDL-15253 Changed setup_group access from private to protected.
|
|
|
made changes - 16/Jun/08 05:31 PM
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Fix Version/s
|
|
2.0
[ 10122
]
|
|
Bug
Resolved
Major
private method grade_report::setup_groups() should be public?
