Issue Details (XML | Word | Printable)

Key: MDL-15254
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Won't Fix
Priority: Major Major
Assignee: Petr Skoda
Reporter: Mathieu Petit-Clair
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-11113

Move common htmleditor plugins files to a common folder

Created: 16/Jun/08 02:26 PM   Updated: 16/Jun/09 05:05 PM
Return to search
Component/s: HTML Editor
Affects Version/s: 2.0
Fix Version/s: None

Issue Links:
Relates
 

Participants: Marc Grober, Mathieu Petit-Clair and Petr Skoda
Security Level: None
Resolved date: 16/Jun/09
Affected Branches: MOODLE_20_STABLE


 Description  « Hide
Plugins that require files that can be shared among different html editors should be stored in a common folder.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mathieu Petit-Clair committed 36 files to 'Moodle CVS' - 16/Jun/08 02:27 PM
MDL-15254: move dragmath plugin to a common folder, out of tinymce hierarchy
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/integrations.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/README.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/LICENSE-gpl.txt   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/img/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/index.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/support.html   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/editing.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/img/Attic/sin on box.jpg   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/parameters.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/browser.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/img/Attic/plus.jpg   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/index.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/demo.html   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/integrations.html   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/acknowledgments.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/img/Attic/sin on plus.jpg   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/integrations.html   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/Release Notes.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/README.html   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/language.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/cvs.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/navframe.html   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/COPYRIGHT.html   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/support.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/options.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/newformat.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/index.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/COPYRIGHT.html   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/Attic/demo.html   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/img/Attic/sin.jpg   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/newobject.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/about.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/simple.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/doc/Attic/complex.html   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/Attic/dragmath.php   Rev. 1.3    (+2 -2 lines)
Mathieu Petit-Clair committed 16 files to 'Moodle CVS' - 16/Jun/08 02:37 PM
Mathieu Petit-Clair committed 29 files to 'Moodle CVS' - 16/Jun/08 02:48 PM
MDL-15254: move dragmath plugin to a common folder, out of tinymce hierarchy
ADD lib/editor/common/dragmath/applet/classes/Attic/jdom.jar   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/Attic/swing-layout-1.0.jar   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/fr.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/Attic/Maxima.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/en.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/Attic/Latex.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/MathML.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/ASCIIMathML.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/Latex.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/MoodleTex.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/Attic/Config.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/ru.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/nl.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/Attic/AbsoluteLayout.jar   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/de.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/Maxima.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/ca.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/Attic/MaximaPopup.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/formats/Attic/Maple.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/Attic/Project.jar   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/es.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/no.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/sv.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/pt-br.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/Attic/MathML.html   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/pl.xml   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/Attic/jep.jar   Rev. 1.1    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/classes/lang/Attic/cz.xml   Rev. 1.1    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/applet/classes/Display/Attic/MainApplet.class   Rev. 1.1    (+0 -0 lines)
Mathieu Petit-Clair committed 42 files to 'Moodle CVS' - 16/Jun/08 02:53 PM
MDL-15254: move dragmath plugin to a common folder, out of tinymce hierarchy
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/fr.xml   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/doc/img/Attic/sin.jpg   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/es.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/Maple.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/HotEqn/Attic/HotEqn.jar   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/MathML.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/jdom.jar   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/Latex.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/ASCIIMathML.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/Attic/MathML.html   Rev. 1.2    (+0 -0 lines)
ADD lib/editor/common/dragmath/applet/HotEqn/Attic/HotEqn.jar   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/nl.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/Project.jar   Rev. 1.3    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/sv.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/HotEqn/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/ca.xml   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/applet/HotEqn/Attic/HotEqn.class   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/AbsoluteLayout.jar   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/jep.jar   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/en.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/ru.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/MoodleTex.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/cz.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Display/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/doc/img/Attic/sin on box.jpg   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/Attic/MaximaPopup.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/formats/Attic/Maxima.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/Attic/Maxima.html   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/pl.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/Config.xml   Rev. 1.3    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Display/Attic/MainApplet.class   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/Attic/Latex.html   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/doc/img/Attic/plus.jpg   Rev. 1.1    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/Attic/swing-layout-1.0.jar   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/pt-br.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/WS_FTP.LOG   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/HotEqn/Attic/HotEqn.class   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/de.xml   Rev. 1.2    (+0 -0 lines)
DEL lib/editor/tinymce/jscripts/tiny_mce/plugins/dragmath/applet/classes/lang/Attic/no.xml   Rev. 1.2    (+0 -0 lines)
MODIFY lib/editor/common/dragmath/doc/img/Attic/sin on plus.jpg   Rev. 1.1    (+0 -0 lines)
Mathieu Petit-Clair committed 2 files to 'Moodle CVS' - 16/Jun/08 02:58 PM
Mathieu Petit-Clair added a comment - 16/Jun/08 03:18 PM
The Dragmath applet, and related documentation, has been moved out of tinymce plugins folder and into /lib/editor/common/dragmath.

Leaving this issue open - the emoticons might benefit from a similar move.


Marc Grober made changes - 12/Aug/08 06:32 AM
Field Original Value New Value
Link This issue has a non-specific relationship to MDL-14740 [ MDL-14740 ]
Marc Grober added a comment - 12/Aug/08 06:42 AM - edited
As was mentioned in the forums, the code that was moved was not current (see CVS for dragmath) and if dragmath is already in common, why not retrofit htmlarea under 1.9?

I did look at what is in the cvs and the tinyMCE integration is a bit out of date and does not reflect the changes made to dragmath so as to eliminate the need to provide tokens in the integration..


Mathieu Petit-Clair added a comment - 18/Aug/08 03:07 PM
Marc, I'm not sure what you mean by "eliminate the need to provide tokens in the integration" ...?

Marc Grober added a comment - 19/Aug/08 01:35 AM
This was addressed in the forum some time ago, but that thread is so convoluted I might just as well recap here.

At the same time we converted dragmath to a moodle CSV product per Anthony's initiative we implemented some changes that I had asked Chris and Alex to make in dragmath. Specifically, dragmath employs xml files as symbol tables as their format specifically allows for the placement of tokens before and after a text expression for the purposes of identifying the text expression to a display application (such as a tex filter or asciimathML). Dragmath never inserted dollar tokens because it was just producing Tex, and the integration file then had to add the tokens, which resulted in the text = '$' + text + '$' entry in all the integration files. We created a new export format called MoodleTex which added dollar signs before and after the latex and then also added an asciimathml export option, which included backtick tokens (though arguably we should have created an asciimathml and a MoodleAsciimathML export format)

The files you imported to the Moodle CSV did not come from the current at that time dragmath CSV.... one reason I was concerned at the time.....

WHile I am talking about this, there seem to be two of dragmath's direcftories left in the tinyMCE directory.... I understand why the integration files are there, but not the HotEqn and classes (not sure if these are the actual directories but I think they are) .....


Mathieu Petit-Clair added a comment - 19/Aug/08 05:54 PM
Thanks for the explanations Marc.

As I moved the files (it was not a new import), they're the same as in 1.9. I tested this and what is "pasted" in Moodle works fine as-is (doesn't need to add or remove dollar signs). I have a feeling you had a look at the files on cvs.moodle.org: the folders you mention are not in the latest version (when checked-out), but CVS will display them anyway, as "dead files" are in there (CVS is dumb: it doesn't keep revisions for folders, only for files).

I'll update to the new version (for both Dragmath and TinyMCE) later in this development cycle.


Petr Skoda made changes - 16/Jun/09 05:04 PM
Assignee Mathieu Petit-Clair [ scyrma ] Petr Skoda [ skodak ]
Petr Skoda added a comment - 16/Jun/09 05:05 PM
sorry, we always used lib/ for library imports and we also need to keep the lib/editor/* clear for normal editor plugins

Petr Skoda made changes - 16/Jun/09 05:05 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Won't Fix [ 2 ]