|
I made the backport of MDL-15265 into a 192 version (Build: 20080711) of moodle.
I hope this helps Thanks Dani - that helps a great deal. Hopefully Nicolas will get a moment to look at it. It is much quicker to check a proposed patch than to produce one. Peace - Anthony
I made a small change in the course/index.php file.
I created the version 1.9.5 of the patch, that I needed.
I hope you be of help Dani - A definite help. I know the 1.9.5 /lib/accesslib.php file was giving me trouble with an older 1.9 patch so having something more recent is great. Thanks again! Peace - Anthony
I have applied the Dani's patch for 1.9.5 to our 1.9.5+ (Build: 20090909) installation (testing system). While it has correctly "compressed" the values in "sortorder" I still can't move courses by clicking on those arrows.
I have enabled debugging and get the following errors: Duplicate entry '201-7573007' for key 2 UPDATE mdl_course SET sortorder = '7573007' WHERE id = '1176' added:
set_field('course', 'sortorder', $max, 'id', $swapcourse->id); this fixes a problem where courses can't be moved up or down, due to an unique index violation. doh!
my above comment relates to the edited patch file that i've attached to this bug. it fixes an issue that we had with Dani's patch. Tobias - Is this issue resolved for your site? I would like to chat with you about this so that I can better understand what is happening. Peace - Anthony
hey guys, I have a site that has this exact problem. The site is running 1.9.6+ (Build: 20091028)
Has this been put into CVS yet? I'm going to have to update this site to 1.9.7 very soon, and I suspect that the patches above won't work with 1.9.7. cheers Sean K Hi Sean,
I wouldn't advice using those patches. We ran into a lot of problems with them. Though you could try to use them to get rid of your problems for the time beeing. When you apply the patches a function will "compress" the sortorder values the first time you try to move a course around. This seems to work just fine. But after that a lot of errors occured (index violations when moving courses (only with some), etc.), so I've reinstalled the standard Moodle files (just copied them over the patched ones). This left me with a Moodle installation which will run "out of numbers" sometime in the future, but for the time beeing everything works fine. I know this is not really a fix, but at least we have a working Moodle installation. I will cope with sortorder fix when it emerges again. Btw.: Please don't use "sortorders-moodle195_2.txt", I might have "fixed it to be broken"... I tried the 195 set of patches, and it failed on the category.php bit. Could this be because the 1.9.6 version of this file is too different for the patch program to recognise it?
Can we get a fix ported to 1.9x for this please?
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Open
Major
Backport course sortorder rewrite to 1.9.x
 |
|
MDL-14580; however, it has been marked as being resolved by MDL-14718. A quick glance makes me think that rather than being resolved by MDL-14718 that perhaps this might be a duplicate of MDL-14718. I figured I would assign this to you since it was assigned to nobody simply to determine if it is in fact a duplicate. The issues (or at least something very similar) has been discussed at http://moodle.org/mod/forum/discuss.php?d=93618