[#MDL-15310] transfer capability checks from tagging library to calling scripts - Moodle Tracker

Details

Type: Sub-task
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: 2.0
Fix Version/s: 2.0.8
Component/s: Blog, Tags
Labels:
None

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

/tag and /blog are in need of a cleanup : there are still capability checks done in tag/lib.php (which should be done in the calling scripts), some code hasn't been adjusted following the (pre-1.9) tag library changes (capabilities not taken into account, not using the api, etc.) and there are quite a few unused variables.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Petr Škoda (skodak) added a comment - 20/Jun/08 3:53 AM

hmm, I thought there the tag:create is meant for adding of new tags, and that somehow the "suing" of tags is separate - the change in user profile effectively disables just using of existing tags, because add is always required, right?

Show

Petr Škoda (skodak) added a comment - 20/Jun/08 3:53 AM hmm, I thought there the tag:create is meant for adding of new tags, and that somehow the "suing" of tags is separate - the change in user profile effectively disables just using of existing tags, because add is always required, right?

Hide

Permalink

Mathieu Petit-Clair added a comment - 20/Jun/08 9:47 AM

This is a good point, but unless we improve this interface to make obvious (à la del.icio.us?) the tags that already exists, it's not really a good idea to only set the existing ones while we disregard the new ones. The "official" tags box is as close as we get to this with the current implementation. Anything else will need some ajax-ification to be easy to use.

Show

Mathieu Petit-Clair added a comment - 20/Jun/08 9:47 AM This is a good point, but unless we improve this interface to make obvious (à la del.icio.us?) the tags that already exists, it's not really a good idea to only set the existing ones while we disregard the new ones. The "official" tags box is as close as we get to this with the current implementation. Anything else will need some ajax-ification to be easy to use.

People

Assignee:

moodle.com

Reporter:

Mathieu Petit-Clair

Participants:

Mathieu Petit-Clair, moodle.com, Petr Škoda (skodak)

Vote (0)

Watch (0)

Dates

Created:

19/Jun/08 9:27 AM

Updated:

08/Jan/12 9:26 AM