[#MDL-15310] transfer capability checks from tagging library to calling scripts

Issue Details (XML | Word | Printable)

Key:	MDL-15310
Type:	Sub-task
Status:	Open
Priority:	Major
Assignee:	Mathieu Petit-Clair
Reporter:	Mathieu Petit-Clair
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13404

transfer capability checks from tagging library to calling scripts

Created: 19/Jun/08 09:27 AM Updated: 20/Jun/08 09:47 AM

Return to search

Component/s:

Blog, Tags

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Mathieu Petit-Clair and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

/tag and /blog are in need of a cleanup : there are still capability checks done in tag/lib.php (which should be done in the calling scripts), some code hasn't been adjusted following the (pre-1.9) tag library changes (capabilities not taken into account, not using the api, etc.) and there are quite a few unused variables.

All

Comments

Change History

Version Control

Sort Order:

Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 19/Jun/08 02:07 PM

MDL-15310: making the tag:create permission effective in user profile

MODIFY

user/editlib.php

Rev. 1.21

(+2 -2 lines)

Mathieu Petit-Clair made changes - 19/Jun/08 05:19 PM

Field	Original Value	New Value
Component/s		Blog [ 10095 ]
Description	There are still capability checks done in tag/lib.php, which should be done in the calling scripts.	/tag and /blog are in need of a cleanup : there are still capability checks done in tag/lib.php (which should be done in the calling scripts), some code hasn't been adjusted following the (pre-1.9) tag library changes (capabilities not taken into account, not using the api, etc.) and there are quite a few unused variables.

Mathieu Petit-Clair committed 2 files to 'Moodle CVS' - 19/Jun/08 05:21 PM

MDL-15310: removing unused variable, old commented code and adding a small adjustment to the tag code.

MODIFY	blog/edit_form.php		Rev. 1.15		(+4 -12 lines)
MODIFY	blog/edit.php		Rev. 1.66		(+1 -2 lines)

Mathieu Petit-Clair committed 5 files to 'Moodle CVS' - 19/Jun/08 06:02 PM

MDL-15310: moving capability checks out of the library + code formatting adjustments

MODIFY	tag/search.php	Rev. 1.14	(+5 -4 lines)
MODIFY	tag/lib.php	Rev. 1.83	(+0 -9 lines)
MODIFY	tag/index.php	Rev. 1.28	(+1 -0 lines)
MODIFY	tag/locallib.php	Rev. 1.17	(+4 -2 lines)
MODIFY	tag/manage.php	Rev. 1.16	(+2 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Jun/08 03:53 AM

hmm, I thought there the tag:create is meant for adding of new tags, and that somehow the "suing" of tags is separate - the change in user profile effectively disables just using of existing tags, because add is always required, right?

[ Permalink | « Hide ]

Mathieu Petit-Clair added a comment - 20/Jun/08 09:47 AM

This is a good point, but unless we improve this interface to make obvious (à la del.icio.us?) the tags that already exists, it's not really a good idea to only set the existing ones while we disregard the new ones. The "official" tags box is as close as we get to this with the current implementation. Anything else will need some ajax-ification to be easy to use.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.