Details
-
Type:
Sub-task
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.0
-
Component/s: Repositories
-
Labels:None
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_20_STABLE
Description
All the places around Moodle that accept files needs to be converted to use the new filepicker/filemanager component from MDL-15348
mod/forum/post.php
mod/assignment/upload.php
user/edit.php
user/editadvanced.php
etc (please add more)
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Uhm... just saw some commits related to this.... two questions:
1) What happens in non-javascript environments? I've disabled js here and it seems that there isn't alternative to add one file in that mode.
2) I've seen lot of lines initializing things like js strings and so on. Instead of having all them harcoded on each file manager usage... shouldn't we be using one central place to perform all that init tasks and reuse it elsewhere (One quick grep have shown that MoodleQuickForm_filemanager already has that init available).
Ciao 
oh, we are trying to move all the print_xxx stuff from weblib.php into renders or formslib, please do not add more there 
noticed the new move_file_to_final_destination() in filelib,
I think it would be better to have
function move_file_to_final_destination($draftfileid, $context, $filearea, $itemid, $filename, $filepath)
file_browser should not be used at all, the file must always come from draft area of current $USER and it might be better to verify it (we do not want to let users steal files from elsewhere)