[#MDL-15405] Convert forms around Moodle to use "filepicker" component

Moodle

MDL-13766

Convert forms around Moodle to use "filepicker" component

Created: 25/Jun/08 03:09 PM Updated: 02/Sep/08 04:00 PM

Component/s:

Repository API

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Martin Dougiamas, Mathieu Petit-Clair and Petr Škoda
Security Level:	None

Description

« Hide

All the places around Moodle that accept files needs to be converted to use the new "filepicker" component from ~~MDL-15348~~

mod/forum/post.php
mod/assignment/upload.php
user/edit.php
user/editadvanced.php

etc (please add more)

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Petr Škoda - 01/Sep/08 09:21 PM - edited

noticed the new move_file_to_final_destination() in filelib,
I think it would be better to have
function move_file_to_final_destination($draftfileid, $context, $filearea, $itemid, $filename, $filepath)
file_browser should not be used at all, the file must always come from draft area of current $USER and it might be better to verify it (we do not want to let users steal files from elsewhere)

[ Permlink | « Hide ]

Petr Škoda - 01/Sep/08 09:22 PM

hmm, maybe it might be also better to implement it as a file_storage method

[ Permlink | « Hide ]

Petr Škoda - 02/Sep/08 03:37 PM

why are the $itemid and $filepath optional? the uploaded file does not have any reasonable values there, right?

[ Permlink | « Hide ]

Mathieu Petit-Clair - 02/Sep/08 04:00 PM

Well, there are, but no they're not right. Changing this...