Issue Details (XML | Word | Printable)

Key: MDL-15405
Type: Sub-task Sub-task
Status: Open Open
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Martin Dougiamas
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13766

Convert forms around Moodle to use "filepicker" component

Created: 25/Jun/08 03:09 PM   Updated: 30/Mar/09 04:44 PM
Return to search
Component/s: Repository API
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Dongsheng Cai, Martin Dougiamas, Mathieu Petit-Clair and Petr Skoda
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
All the places around Moodle that accept files needs to be converted to use the new "filepicker" component from MDL-15348

mod/forum/post.php
mod/assignment/upload.php
user/edit.php
user/editadvanced.php

etc (please add more)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 01/Sep/08 09:21 PM - edited
noticed the new move_file_to_final_destination() in filelib,
I think it would be better to have
function move_file_to_final_destination($draftfileid, $context, $filearea, $itemid, $filename, $filepath)
file_browser should not be used at all, the file must always come from draft area of current $USER and it might be better to verify it (we do not want to let users steal files from elsewhere)

Petr Skoda added a comment - 01/Sep/08 09:22 PM
hmm, maybe it might be also better to implement it as a file_storage method

Petr Skoda added a comment - 02/Sep/08 03:37 PM
why are the $itemid and $filepath optional? the uploaded file does not have any reasonable values there, right?

Mathieu Petit-Clair added a comment - 02/Sep/08 04:00 PM
Well, there are, but no they're not right. Changing this...