[#MDL-15405] Convert forms around Moodle to use "filepicker" component

Issue Details (XML | Word | Printable)

Key:	MDL-15405
Type:	Sub-task
Status:	Open
Priority:	Minor
Assignee:	Dongsheng Cai
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13766

Convert forms around Moodle to use "filepicker" component

Created: 25/Jun/08 03:09 PM Updated: 30/Mar/09 04:44 PM

Return to search

Component/s:

Repository API

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Dongsheng Cai, Martin Dougiamas, Mathieu Petit-Clair and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

All the places around Moodle that accept files needs to be converted to use the new "filepicker" component from ~~MDL-15348~~

mod/forum/post.php
mod/assignment/upload.php
user/edit.php
user/editadvanced.php

etc (please add more)

All

Comments

Change History

Version Control

Sort Order:

Dongsheng Cai committed 3 files to 'Moodle CVS' - 17/Jul/08 05:34 PM

MDL-15405
1. Produce repository list dynamicly.
2. Remove logout button, add a logout link after repository name

MODIFY	repository/Attic/ajax.php	Rev. 1.7	(+34 -25 lines)
MODIFY	repository/lib.php	Rev. 1.13	(+21 -1 lines)
MODIFY	repository/Attic/curl.class.php	Rev. 1.12	(+7 -3 lines)

Mathieu Petit-Clair made changes - 08/Aug/08 10:22 AM

Field	Original Value	New Value
Description	All the places around Moodle that accept files needs to be converted to use the new "fileopen" component from ~~MDL-15348~~ mod/forum/post.php mod/assignment/upload.php user/edit.php user/editadvanced.php etc (please add more)	All the places around Moodle that accept files needs to be converted to use the new "filepicker" component from ~~MDL-15348~~ mod/forum/post.php mod/assignment/upload.php user/edit.php user/editadvanced.php etc (please add more)
Summary	Convert forms around Moodle to use "fileopen" component	Convert forms around Moodle to use "filepicker" component

Mathieu Petit-Clair committed 2 files to 'Moodle CVS' - 27/Aug/08 03:57 PM

MDL-15405: A first form (partly) converted to the new filepicker element.

MODIFY	lib/form/filepicker.php		Rev. 1.11		(+10 -2 lines)
MODIFY	mod/forum/post_form.php		Rev. 1.29		(+2 -4 lines)

Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 27/Aug/08 04:36 PM

MDL-15405: Add missing quote in javascript code

MODIFY

lib/form/filepicker.php

Rev. 1.12

(+2 -2 lines)

Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 29/Aug/08 03:51 PM

MDL-15405: make it possible to specify a destination filearea for htmleditor forms element

MODIFY

lib/form/htmleditor.php

Rev. 1.13

(+4 -3 lines)

Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 01/Sep/08 02:15 PM

MDL-15405: first version of post-upload content rewriting function

MODIFY

lib/filelib.php

Rev. 1.88

(+31 -1 lines)

Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 01/Sep/08 06:33 PM

MDL-15405: first draft - function to move a file from user_draft to the good filearea, post form-submission.

MODIFY

lib/filelib.php

Rev. 1.89

(+42 -0 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Sep/08 09:21 PM - edited

noticed the new move_file_to_final_destination() in filelib,
I think it would be better to have
function move_file_to_final_destination($draftfileid, $context, $filearea, $itemid, $filename, $filepath)
file_browser should not be used at all, the file must always come from draft area of current $USER and it might be better to verify it (we do not want to let users steal files from elsewhere)