[#MDL-15424] XML Parsing Error in calendar/event_delete.html

Issue Details (XML | Word | Printable)

Key:	MDL-15424
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Trivial
Assignee:	Dongsheng Cai
Reporter:	Dongsheng Cai
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

XML Parsing Error in calendar/event_delete.html

Created: 26/Jun/08 04:41 PM Updated: 09/Jul/08 06:40 PM

Return to search

Component/s:

Usability

Affects Version/s:

1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.9, 1.9.1, 1.9.2, 2.0

Fix Version/s:

1.8.6, 1.9.2

Participants:	Dongsheng Cai, Nicolas Connault and Petr Skoda
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	02/Jul/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

When I access calendar/event.php?action=delete&id=2, it shows:
XML Parsing Error: mismatched tag. Expected: </input>.
Location: http://dongsheng.moodle.com/18/calendar/event.php?action=delete&id=2
Line Number 156, Column 9: </p>
--------^

All

Comments

Change History

Version Control

Sort Order:

Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 26/Jun/08 04:56 PM

"~~MDL-15424~~, fix html tag"

MODIFY

calendar/Attic/event_delete.html

Rev. 1.6.2.2

(+1 -1 lines)

Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 26/Jun/08 04:58 PM

"~~MDL-15424~~, fix html tag"

MODIFY

calendar/Attic/event_delete.html

Rev. 1.7.2.1

(+1 -1 lines)

Dongsheng Cai committed 1 file to 'Moodle CVS' - 26/Jun/08 04:59 PM

"~~MDL-15424~~, fix html tag"

MODIFY

calendar/Attic/event_delete.html

Rev. 1.8

(+1 -1 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 26/Jun/08 04:59 PM

Fixed, feel free to reopen

Dongsheng Cai made changes - 26/Jun/08 04:59 PM

Field	Original Value	New Value
Fix Version/s		1.8.6 [ 10270 ]
Fix Version/s		1.9.2 [ 10280 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Nicolas Connault made changes - 01/Jul/08 04:03 PM

QA Assignee

nicolasconnault

[ Permalink | « Hide ]

Nicolas Connault added a comment - 01/Jul/08 04:04 PM - edited

In 1.8, I still get

XML Parsing Error: mismatched tag. Expected: </td>.
Location: http://enterprise/moodle_18/calendar/event.php?id=157&action=delete&m=07&d=01&y=2008&confirm=1&repeats=0&course=15
Line Number 118, Column 3:
</div> 
--^

[ Permalink | « Hide ]

Nicolas Connault added a comment - 01/Jul/08 04:06 PM - edited

And in 1.9, I get

XML Parsing Error: mismatched tag. Expected: </td>.
Location: http://enterprise/moodle_19/calendar/event.php?id=9&action=delete&m=7&d=15&y=2008&confirm=1&repeats=0&course=0
Line Number 132, Column 3:
</div><div id="footer"><hr /><p class="helplink"></p> <div class="validators"><ul>
--^

Nicolas Connault made changes - 01/Jul/08 04:06 PM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 01/Jul/08 04:48 PM

Hi, Nicolas, the mismatched tags are caused by redirect function (see event.php 305 line), this function will output redirect JavaScript and HTML footer, IMO it is not necessary to fix this.

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 01/Jul/08 04:53 PM

Do you have any idea to solve this problem?

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jul/08 06:32 AM

hmm, redirect can not be used in random places - ideally it should be used before starting any html output, or you have to manually close all tables and divs before using it.

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 02/Jul/08 01:08 PM

There are several random calls of redirect, I will manually close the tags.

Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Jul/08 03:05 PM

"~~MDL-15424~~, close table tags manually before calling redirect"

MODIFY

calendar/event.php

Rev. 1.63.2.10

(+2 -1 lines)

Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Jul/08 03:08 PM

"~~MDL-15424~~, close table tags manually before calling redirect"

MODIFY

calendar/event.php

Rev. 1.74.2.5

(+2 -1 lines)

Dongsheng Cai committed 1 file to 'Moodle CVS' - 02/Jul/08 03:09 PM

"~~MDL-15424~~, close table tags manually before calling redirect, merged from MOODLE_19_STABALE"

MODIFY

calendar/event.php

Rev. 1.86

(+2 -1 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 02/Jul/08 03:10 PM

Close tags manually before calling redirect, please review, thanks

Dongsheng Cai made changes - 02/Jul/08 03:10 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 09/Jul/08 06:40 PM

thanks

Petr Skoda made changes - 09/Jul/08 06:40 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee	nicolasconnault	skodak

All content on this web site is made available under the GNU General Public License, unless otherwise stated.